[16.0][MIG] account_payment_order: Migration to 16.0 #972
Conversation
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
3364fb0
to
724c8c0
Compare
pedrobaeza
changed the title
|
#1000 should be needed, but first is to have green CI. Check also the proper PR title that I have put. |
|
#1000 was already included because of the review of dzungtran89 |
|
And what about the CI? |
|
CI in progress now |
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
ec4f57d
to
923ce50
Compare
|
@pedrobaeza done - anything else ? |
|
Yes, please check pre-commit changes that are not complete, and please squash all your migration commits into one (except the first one |
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
923ce50
to
d5e34fd
Compare
|
@pedrobaeza please /ocabot merge |
|
Hi @wpichler. Your command failed:
Ocabot commands
More information
|
|
I detected some wrong view in Create payment lines. |
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
d5e34fd
to
76fefa3
Compare
|
/ocabot migration account_payment_order |
I've corrected the wrong view
|
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
76fefa3
to
6e7bfc4
Compare
… communication If some movements have been reconciled with the original invoice, their references should be added in communication too. e.g.: Manual credit notes
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
ff43c4d
to
9b437af
Compare
|
Rebased - all checks are fine - requested changes are done. Please review and approve |
|
[FIX] Fixed bug from cherry-pick in the tests these commits should be squashed into the migration commit should be squashed into the pre-commit stuff before the migration or if they are just fixing your migrated changes, then they should be part of the original migration too i would also put the cherry-picked ones before the migration commit, in case anything has to be adapted to 16.0 |
[MIG] migration scripts [IMP] report account_payment_order use t-field [IMP] field company_id invisible on view account_payment_line
[IMP] create with @api.model_create_multi tag
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
4711bf7
to
7ae61e2
Compare
|
i've merge PR from @AnizR and pick squashed all commits into one migration commit. I hope this is the correct way do keep history of commits as it should be |
|
I'm afraid you have squashed too much. Commits like the account.payment generation should be isolated, or the extra fixes. Can you please undo that? |
wpichler
force-pushed
the
16.0-mig-account_payment_order
branch
from
7ae61e2
to
4711bf7
Compare
|
@pedrobaeza I've undone it - and have no idea how to squash these commits - any hint ? |
|
Need any help? |
Yes please |
|
Show a picture of the commit history to see how you currently have the branch. |
| @@ -161,6 +164,18 @@ def _insert_payment_line_payment_link(env): | |||
|
|
|||
| @openupgrade.migrate() | |||
| def migrate(env, version): | |||
| env.cr.execute( | |||
There was a problem hiding this comment.
Do we want to execute this when this has already been executed during 14.0.2.0.0 migration?
This looks valid only if migrating from 14.0.1.0.0 to 16.0.1.0.0.
Same applies to 14.0.3.0.0
|
I have put a bit of order + gather latest changes from previous branches on #1056, so closing this one and merging the other as soon as I get a green CI. Thanks all for your efforts. |
#964
Needs #969
Standard Migration - just one thing - it was necessary to add groups="base.group_multi_company" to the order_id field in account_payment_line_form. Without this i do get this error:
Field 'company_id' used in domain of field 'order_id' ([('company_id', 'in', [company_id, False])]) is restricted to the group(s) base.group_multi_company.
order_id is check_company - so company_id domain gets added indirectly and should be ok without this group. Maybe because of the related company_id this problem occours ?