Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_banking_mandate: migration to 16.0 #1028

Merged
merged 91 commits into from
Mar 13, 2023

Conversation

Reyes4711-S73
Copy link
Contributor

@Reyes4711-S73 Reyes4711-S73 commented Feb 7, 2023

Superseed from #1016 due to the fact that the PR was not migrated correctly
I remove the bank_payment_line model and complete the tests correcting some issues

depends #972

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_mandate branch from 648cf60 to 6ed3e82 Compare February 7, 2023 09:51
@AsierAcedo
Copy link

Hello there is an older PR #973

@Reyes4711-S73
Copy link
Contributor Author

@AsierAcedo This pass all tests and the older PR doesn't pass any test.

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_mandate branch from 3b9ba0a to 8129cd8 Compare February 7, 2023 17:12
@Reyes4711-S73 Reyes4711-S73 changed the title [16.0][IMP] account_banking_mandate: finishing migration [16.0][MIG] account_banking_mandate: migration to 16.0 Feb 7, 2023
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_mandate branch from 8129cd8 to 380c658 Compare February 8, 2023 09:12
@hildickethan hildickethan force-pushed the 16.0-migration-account_banking_mandate branch 2 times, most recently from 9d26ba3 to 49a5e1b Compare March 6, 2023 09:12
@pedrobaeza
Copy link
Member

/ocabot migration account_banking_mandate

Please squash administrative commits as stated in the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0. For example, last three commits before migration that belongs to the same translator.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 8, 2023
14 tasks
pedrobaeza and others added 18 commits March 13, 2023 08:58
* Bug OCA#96 bad use of new API
* [Usability] mandates: search by reference, add group_by, add seq type in tree view
* Add scheme in mandate tree+search view
* Replace tabs by spaces in mandate views
* account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format
* Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more
Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer
Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule.
Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers
* Bump version numbers
* es translations
* Add creditor identifier field to report mandate.
* Translate.
* Split basic and sepa mandate
* Use api.multi instead
* Make format field required
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided

Using same method as in upstream, mandate is filled on invoice creation if no
one is provided. This way, we don't need to install account_banking_mandate_sale
if we don't want to handle several mandates at sales level.
StefanRijnhart and others added 19 commits March 13, 2023 15:27
Currently translated at 92.0% (93 of 101 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/fr/
Tests were trying to write/access a field that does not exist in account.move.line, but in account.move

TT28423

account_banking_mandate 14.0.1.0.1
Translated using Weblate (French (France))

Currently translated at 79.6% (86 of 108 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/fr_FR/
Currently translated at 75.2% (76 of 101 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/nl/

Translated using Weblate (Dutch)

Currently translated at 77.2% (78 of 101 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/nl/

Translated using Weblate (Dutch)

Currently translated at 87.1% (88 of 101 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/
Currently translated at 100.0% (109 of 109 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/es_AR/
Fix bug in account_banking_mandate when a res.partner.bank is not attached to a particular company (company_id is NOT required on res.partner.bank)
Currently translated at 100.0% (109 of 109 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_mandate/ca/
[UPD] Update account_banking_mandate.pot

[UPD] README.rst
…n/Stable

[UPD] README.rst

account_banking_mandate 15.0.1.0.1
Currently translated at 78.8% (86 of 109 strings)

Translation: bank-payment-15.0/bank-payment-15.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_mandate/it/
Currently translated at 78.8% (86 of 109 strings)

Translation: bank-payment-15.0/bank-payment-15.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_mandate/it/

Translated using Weblate (Italian)

Currently translated at 78.8% (86 of 109 strings)

Translation: bank-payment-15.0/bank-payment-15.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_mandate/it/

Translated using Weblate (Italian)

Currently translated at 78.8% (86 of 109 strings)

Translation: bank-payment-15.0/bank-payment-15.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_mandate/it/
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_mandate branch from ea3807a to 2ff5461 Compare March 13, 2023 14:27
@Reyes4711-S73
Copy link
Contributor Author

@pedrobaeza Squashed more commits.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1028-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3a6c2db into OCA:16.0 Mar 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 087e8d5. Thanks a lot for contributing to OCA. ❤️

@Reyes4711-S73 Reyes4711-S73 deleted the 16.0-migration-account_banking_mandate branch March 13, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.