-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] account_payment_partner #969
[16.0] [MIG] account_payment_partner #969
Conversation
Hey @ThomasBinsfeld, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
/ocabot migration account_payment_partner |
@ThomasBinsfeld PR #968 is merged now. Could you please rebase this PR? I'd like to test it in runboat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the view error, other functionalities tested 👍
@@ -10,7 +10,7 @@ | |||
<field name="inherit_id" ref="account.view_move_line_form" /> | |||
<field name="arch" type="xml"> | |||
<xpath | |||
expr="//group[@groups='analytic.group_analytic_accounting,analytic.group_analytic_tags']" | |||
expr="//field[@name='analytic_distribution_stored_char']/.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting error with this Xpath
Change it to
<xpath
expr="//group[@groups='analytic.group_analytic_accounting']"
position="after"
>
Error detail
Element '<xpath expr="//field[@name='analytic_distribution_stored_char']/..">' cannot be located in parent view
View error context:
{'file': '/opt/odoo/appstest16-odoo/src/OCA/bank-payment/account_payment_partner/views/account_move_line.xml',
'line': 2,
'name': 'account_payment_partner.move_line_form',
'view': ir.ui.view(2118,),
'view.model': 'account.move.line',
'view.parent': ir.ui.view(568,),
'xmlid': 'view_move_line_form'}
@ThomasBinsfeld can you rebase? |
b43c326
to
836b5a8
Compare
Done |
Tests are failing due to some problems with a view. Can you check it? |
This should fix pre-commit #989 |
Hello @ThomasBinsfeld could you fix the view issue and make a new rebase ? |
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Clean files * Replace deprecated workflow calls * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices * FIX: Remove deprecated tag type
* move unused file + cleanup code * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data * Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
FIX tabs FIX translate
* Forgot to remove a usecase of debit_denied * Add ACL * Better filters on payment.order.create wizard * Add default values for those filters on payment.mode * FIX remove coma at end of line * Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers * Remove label field There's already a field in the payment mode called 'note' that is printed on the invoices, so there's no need of another field for that purpose. This field is added by account_banking_payment_export * Bump version numbers * es translations * Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order * Finalise the wizard of selection of move lines to pay * Add button "Add to payment/debit order" on invoice form view * Started to integrate payment transfer in account_payment_order (not finished at all though) * Copy payment mode and mandate from invoice to refund * Run dos2unix on the few files that had DOS carriage return * Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner) * Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange * Move field bank_account_required from module account_payment_partner to account_payment_mode
Currently translated at 97.3% (37 of 38 strings) Translation: bank-payment-15.0/bank-payment-15.0-account_payment_partner Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_payment_partner/ca/
Currently translated at 100.0% (38 of 38 strings) Translation: bank-payment-15.0/bank-payment-15.0-account_payment_partner Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_payment_partner/ca/
Add company permissions to the admin user to be able to create the demo data
Make payment_mode fields limited to the correct company TT28906
836b5a8
to
00ab7d0
Compare
Fixed |
This PR has the |
/ocabot migration account_payment_partner |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at bacb7d1. Thanks a lot for contributing to OCA. ❤️ |
#964
Needs #968