Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] account_payment_partner #969

Merged
merged 120 commits into from
Dec 6, 2022

Conversation

ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Oct 11, 2022

#964

Needs #968

@oca-clabot
Copy link

Hey @ThomasBinsfeld, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

  • Launchpad Translations on behalf of banking-addons-team (no github login found)

Appreciation of efforts,
OCA CLAbot

@adrienpeiffer
Copy link
Contributor

/ocabot migration account_payment_partner

@marylla
Copy link

marylla commented Oct 25, 2022

Needs #968

@ThomasBinsfeld PR #968 is merged now. Could you please rebase this PR? I'd like to test it in runboat.

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the view error, other functionalities tested 👍

@@ -10,7 +10,7 @@
<field name="inherit_id" ref="account.view_move_line_form" />
<field name="arch" type="xml">
<xpath
expr="//group[@groups='analytic.group_analytic_accounting,analytic.group_analytic_tags']"
expr="//field[@name='analytic_distribution_stored_char']/.."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting error with this Xpath
Change it to

            <xpath
                expr="//group[@groups='analytic.group_analytic_accounting']"
                position="after"
            >

Error detail

Element '<xpath expr="//field[@name=&#39;analytic_distribution_stored_char&#39;]/..">' cannot be located in parent view

View error context:
{'file': '/opt/odoo/appstest16-odoo/src/OCA/bank-payment/account_payment_partner/views/account_move_line.xml',
 'line': 2,
 'name': 'account_payment_partner.move_line_form',
 'view': ir.ui.view(2118,),
 'view.model': 'account.move.line',
 'view.parent': ir.ui.view(568,),
 'xmlid': 'view_move_line_form'}

@etobella
Copy link
Member

@ThomasBinsfeld can you rebase?

@ThomasBinsfeld
Copy link
Contributor Author

@ThomasBinsfeld can you rebase?

Done

@etobella
Copy link
Member

Tests are failing due to some problems with a view. Can you check it?

@etobella
Copy link
Member

This should fix pre-commit #989

@florian-dacosta
Copy link

Hello @ThomasBinsfeld could you fix the view issue and make a new rebase ?
If needed, I can superseed this PR to make the changes, you let me know

Alexis de Lattre and others added 16 commits November 29, 2022 14:15
- account_payment_partner
- account_payment_sale
- account_payment_sale_stock
- account_payment_purchase

Filter the selection of invoices per payment type.
Add active field on payment.mode and payment.mode.type.
Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA
* Clean files
* Replace deprecated workflow calls
* Translation template files
* Translations to spanish
* Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices
* FIX: Remove deprecated tag type
* move unused file + cleanup code
* Add sale_ok and purchase_ok filters in partner/sale/purchase form views
* Use widget=selection for payment_mode_id fields
* Update demo data
* Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
* Forgot to remove a usecase of debit_denied
* Add ACL
* Better filters on payment.order.create wizard
* Add default values for those filters on payment.mode
* FIX remove coma at end of line
* Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers
* Remove label field

  There's already a field in the payment mode called 'note' that is
  printed on the invoices, so there's no need of another field for
  that purpose. This field is added by account_banking_payment_export

* Bump version numbers
* es translations
* Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016

Improvements include:
- full re-organisation of modules and big re-organisation of the code
- simplification of the code related to the fact that support for direct debit is now in t
he base module, not added by an optional module account_direct_debit (module was removed)
- new design of the wizard to select move lines to pay
- support for non-SEPA file transfer-
- support for German direct debit SEPA files (fixes bug OCA#129)
- remove workflow of payment.order
* Finalise the wizard of selection of move lines to pay
* Add button "Add to payment/debit order" on invoice form view
* Started to integrate payment transfer in account_payment_order (not finished at all though)
* Copy payment mode and mandate from invoice to refund
* Run dos2unix on the few files that had DOS carriage return
* Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner)
* Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange
* Move field bank_account_required from module account_payment_partner to account_payment_mode
@ThomasBinsfeld
Copy link
Contributor Author

Hello @ThomasBinsfeld could you fix the view issue and make a new rebase ? If needed, I can superseed this PR to make the changes, you let me know

Fixed

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration account_payment_partner
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-969-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 24c4566 into OCA:16.0 Dec 6, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bacb7d1. Thanks a lot for contributing to OCA. ❤️

@ThomasBinsfeld ThomasBinsfeld deleted the 16.0-mig-account_payment_partner branch December 6, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.