[16.0][MIG] account_payment_sale #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SodexisTeam
force-pushed
the
16.0-mig-account_payment_sale
branch
from
191da88
to
7d2f99d
Compare
|
Hi @atchuthan Can you rebase please now that dependency has been merge ? |
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Remove duplicated files * Check if payment mode is set in the propagation * Clean files * account_payment_sale_stock: Split for removing stock dependency on sale * Remove old translations templates * Reorder on folder structure * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
Currently translated at 100,0% (4 of 4 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_payment_sale/es/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/zh_CN/
…d from a call to sale.action_invoice_create Into the normal process of the invoice creation from a sale order by odoo, the onchange_partner is called. In some case, this call will reset the specific payment_mode and/or partner_bank_id set on the sale_order. To fix this issue, we must override the _finalize_invoices method, take a snapshot of these values before the call to super and restore these values if these are changed. fixes OCA#536
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-12.0/bank-payment-12.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-12-0/bank-payment-12-0-account_payment_sale/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-13.0/bank-payment-13.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_payment_sale/
Currently translated at 85.7% (6 of 7 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_sale/sv/
Currently translated at 100.0% (7 of 7 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_sale/it/
Currently translated at 80.0% (4 of 5 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_sale/es/
Currently translated at 100.0% (7 of 7 strings) Translation: bank-payment-15.0/bank-payment-15.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_payment_sale/ca/
atchuthan
force-pushed
the
16.0-mig-account_payment_sale
branch
from
7d2f99d
to
e7b4edb
Compare
rebase done |
|
Great work, thank you. I'll approve it once you'll have integrated my PR sodexis#1 on this PR. It adds payment_mode_id to sale.report. |
@alexis-via Done |
florian-dacosta
approved these changes
Dec 13, 2022
alexis-via
approved these changes
Dec 13, 2022
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 13, 2022
|
Congratulations, your PR was merged at 252f151. Thanks a lot for contributing to OCA. ❤️ |
|
/ocabot migration account_payment_sale |
|
@alexis-via I think there is a missing block here: payment_mode_id should be added in invoice grouping here: https://github.com/odoo/odoo/blob/16.0/addons/sale/models/sale_order.py#L1045C5-L1046C59 What do you think ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #969
cc: @SodexisTeam