fix(gateway): regression causing display.streaming to override root gateway streaming config - #9799
Merged
Merged
Conversation
Contributor
|
This was referenced Apr 14, 2026
Closed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #8347 by @asheriif — cherry-picked onto current main.
Fixes a regression introduced by PR #8006 (per-platform display config) where the CLI-only
display.streamingconfig key leaks into gateway streaming decisions, causing streaming to be enabled on messaging platforms even whenstreaming.enabled: falseis set.The fix adds a guard in
resolve_display_setting()to skipdisplay.streamingat step 2 (global display settings), since that key only controls CLI terminal streaming. Gateway streaming is governed by the top-levelstreamingconfig, with per-platform overrides viadisplay.platforms.<platform>.streamingstill working.Fixes #8338
Changes
gateway/display_config.py— skipdisplay.streamingin global display resolution (step 2)tests/gateway/test_display_config.py— test that globaldisplay.streamingis ignored for gatewaytests/gateway/test_run_progress_topics.py— integration test:display.streaming: true+streaming.enabled: falsedoes NOT enable gateway streamingTest results
Credit: @asheriif (original implementation)