Skip to content

fix(gateway): regression causing display.streaming to override root gateway streaming config - #9799

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-5ea84e11
Apr 14, 2026
Merged

fix(gateway): regression causing display.streaming to override root gateway streaming config#9799
teknium1 merged 1 commit into
mainfrom
hermes/hermes-5ea84e11

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Salvage of PR #8347 by @asheriif — cherry-picked onto current main.

Fixes a regression introduced by PR #8006 (per-platform display config) where the CLI-only display.streaming config key leaks into gateway streaming decisions, causing streaming to be enabled on messaging platforms even when streaming.enabled: false is set.

The fix adds a guard in resolve_display_setting() to skip display.streaming at step 2 (global display settings), since that key only controls CLI terminal streaming. Gateway streaming is governed by the top-level streaming config, with per-platform overrides via display.platforms.<platform>.streaming still working.

Fixes #8338

Changes

  • gateway/display_config.py — skip display.streaming in global display resolution (step 2)
  • tests/gateway/test_display_config.py — test that global display.streaming is ignored for gateway
  • tests/gateway/test_run_progress_topics.py — integration test: display.streaming: true + streaming.enabled: false does NOT enable gateway streaming

Test results

  • 101 targeted tests passed (display_config + run_progress_topics + stream_consumer)
  • 2799/2799 gateway tests passed (7 pre-existing failures in unrelated areas)

Credit: @asheriif (original implementation)

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Supply Chain Risk Detected

This PR contains patterns commonly associated with supply chain attacks. This does not mean the PR is malicious — but these patterns require careful human review before merging.

⚠️ WARNING: Install hook files modified

These files can execute code during package installation or interpreter startup.

Files:

hermes_cli/memory_setup.py

Automated scan triggered by supply-chain-audit. If this is a false positive, a maintainer can approve after manual review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: (regression) display.streaming Enables Gateway Message Streaming Despite streaming.enabled: false

2 participants