fix(gateway): regression causing display.streaming to override root gateway streaming config - #8347
Closed
asheriif wants to merge 1 commit into
Closed
Conversation
1 task
asheriif
marked this pull request as draft
April 14, 2026 15:41
asheriif
marked this pull request as ready for review
April 14, 2026 15:41
This was referenced Apr 14, 2026
Merged
Contributor
|
Merged via PR #9799. Your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks for the clean fix — it was the best implementation of the three duplicate PRs that came in for this issue. 🎯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a regression where gateway token streaming could be enabled by the CLI-only
display.streamingconfig key.display.streamingis documented as controlling CLI streaming, while gateway streaming should be controlled by the top-levelstreamingconfig. After the per-platform display resolver was added, globaldisplay.streamingwas treated as a gateway display override, so a config like this could still stream/edit messages in Discord:This PR updates gateway display resolution so:
display.streamingis ignored for gateway streaming decisionsstreaming.enabled/streaming.transportremains the gateway defaultdisplay.platforms.discord.streamingstill workTesting
Passed:
python -m pytest tests/gateway/test_display_config.py tests/gateway/test_run_progress_topics.py tests/gateway/test_stream_consumer.py -q71 passed
Related Issue
Fixes #8338
Note: this is also the reason why so many issues related to streaming are now being opened. Because streaming suddenly got enabled for a lot of people.
Type of Change
Changes Made
gateway/display_config.pyso globaldisplay.streamingis treated as CLI-only and no longer overrides the gateway’s top-levelstreamingconfig.display.platforms.<platform>.streaming.tests/gateway/test_display_config.pyfor ignoring globaldisplay.streamingin gateway streaming resolution.tests/gateway/test_run_progress_topics.pyfordisplay.streaming: trueplusstreaming.enabled: false.How to Test
With root gateway streaming disabled:
Messaging platforms no longer receive progressively edited streamed messages unless they have platform specific overrides. This aligns with the documentation and fixes the regression and the unintended behavior.
Root
display.streaming: trueshould only affect the CLI terminal streaming display as per the docs.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A