fix(gateway): respect streaming.enabled: false even when display.streaming is true (fixes #8338) - #8635
Closed
iacker wants to merge 1 commit into
Closed
Conversation
…aming is true (fixes #8338) The streaming gate in the gateway message handler was treating display.streaming as a full override, bypassing the global streaming.enabled config. Now streaming.enabled remains a hard prerequisite — per-platform display overrides can only disable streaming that the global config has enabled, not re-enable it when the global config has disabled it.
Contributor
|
Closing in favor of #9799, which salvages #8347 (asheriif's implementation) onto current main. Your PR was also a valid fix — the difference is that your approach AND-gates per-platform streaming with global streaming, which would prevent per-platform overrides from enabling streaming when the global is off. asheriif's approach fixes the bug at the resolver level instead, preserving that flexibility. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway/run.pynow respectsstreaming.enabled: falseeven whendisplay.streaming: trueis set_scfg.enabledremains a hard prerequisite — per-platform display overrides can only disable streaming, not re-enable it when the global config has disabled itRoot cause
The ternary expression:
When
_plat_streamingwas not None (display override existed), the global_scfg.enabledcheck was completely bypassed.Fix
Testing
tests/gateway/test_display_config.py::TestStreamingGateGlobalOverride(6 test cases)pytest tests/gateway/test_display_config.py -q→ 33 passedFixes #8338