Skip to content

fix(tools): grok-imagine must not default upscale on (Aug 2026 policy) - #90067

Closed
andrexibiza wants to merge 1 commit into
NousResearch:mainfrom
andrexibiza:fix/image-upscale-optin
Closed

fix(tools): grok-imagine must not default upscale on (Aug 2026 policy)#90067
andrexibiza wants to merge 1 commit into
NousResearch:mainfrom
andrexibiza:fix/image-upscale-optin

Conversation

@andrexibiza

Copy link
Copy Markdown
Contributor

Summary

The FAL catalog entry xai/grok-imagine-image/v2.0/text-to-image is the only entry defaulting upscale: True, which violates the Aug 2026 opt-in-only upscaling policy. This fails tests/tools/test_image_generation.py::TestFalCatalog::test_upscale_defaults_are_all_off on every open PR right now (it's a pre-existing main bug, unrelated to the individual PRs that each hit it).

Change

  • tools/image_generation_tool.py: set the grok-imagine entry's upscale default to False. Per-call upscale=True still works via the explicit tool-schema path (tools/image_generation_tool.py honors an explicit upscale arg over the catalog default), so this only removes the default-on behavior.

Tests

  • test_upscale_defaults_are_all_off passes.

Why this PR

Fixes the pre-existing main regression at its source so it stops blocking unrelated PRs' CI. The same one-line change was temporarily carried on #89252 / #88875 / #86419 to get those green; this is the standalone home so each routing/MCP/Discord PR can drop its copy and be reviewed independently.

FAL catalog entry xai/grok-imagine-image/v2.0/text-to-image defaulted
upscale: True, the only catalog entry violating the opt-in-only upscaling
policy (Aug 2026). Per-call upscale=True still works via the explicit
tool-schema path; the catalog default is now off, matching every other
entry and restoring test_upscale_defaults_are_all_off.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/vision Vision analysis and image generation duplicate This issue or pull request already exists labels Aug 19, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #89933: both make the same one-line Grok Imagine catalog default-upscale change; #89933 is the earlier open canonical PR.

@alt-glitch alt-glitch added the provider/xai xAI (Grok) label Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Confirmed against the exact current heads: #90067 (a2215e3) is a line-level duplicate of #89933 (07f85f3), and #89933 is the better canonical home because it preserves the policy rationale beside the catalog entry. Closing this PR as superseded by #89933; no unique implementation from this branch needs to be retained.

I am transferring the unique topology instead of discarding it with the duplicate:

So the correct graph operation is: merge #89933 first, close the standalone duplicates, then rebase/drop the hitchhiking hunk from #88875 and #86419. The broader missing primitive is pre-open defect-class claiming/deduplication; post-hoc duplicate triage catches the fan-out only after the queue and attribution graph have already fractured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/xai xAI (Grok) tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants