fix(tools): grok-imagine must not default upscale on (Aug 2026 policy) - #90067
Closed
andrexibiza wants to merge 1 commit into
Closed
fix(tools): grok-imagine must not default upscale on (Aug 2026 policy)#90067andrexibiza wants to merge 1 commit into
andrexibiza wants to merge 1 commit into
Conversation
FAL catalog entry xai/grok-imagine-image/v2.0/text-to-image defaulted upscale: True, the only catalog entry violating the opt-in-only upscaling policy (Aug 2026). Per-call upscale=True still works via the explicit tool-schema path; the catalog default is now off, matching every other entry and restoring test_upscale_defaults_are_all_off.
Collaborator
Contributor
Author
|
Confirmed against the exact current heads: #90067 ( I am transferring the unique topology instead of discarding it with the duplicate:
So the correct graph operation is: merge #89933 first, close the standalone duplicates, then rebase/drop the hitchhiking hunk from #88875 and #86419. The broader missing primitive is pre-open defect-class claiming/deduplication; post-hoc duplicate triage catches the fan-out only after the queue and attribution graph have already fractured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FAL catalog entry
xai/grok-imagine-image/v2.0/text-to-imageis the only entry defaultingupscale: True, which violates the Aug 2026 opt-in-only upscaling policy. This failstests/tools/test_image_generation.py::TestFalCatalog::test_upscale_defaults_are_all_offon every open PR right now (it's a pre-existing main bug, unrelated to the individual PRs that each hit it).Change
tools/image_generation_tool.py: set the grok-imagine entry'supscaledefault toFalse. Per-callupscale=Truestill works via the explicit tool-schema path (tools/image_generation_tool.pyhonors an explicitupscalearg over the catalog default), so this only removes the default-on behavior.Tests
test_upscale_defaults_are_all_offpasses.Why this PR
Fixes the pre-existing main regression at its source so it stops blocking unrelated PRs' CI. The same one-line change was temporarily carried on #89252 / #88875 / #86419 to get those green; this is the standalone home so each routing/MCP/Discord PR can drop its copy and be reviewed independently.