Skip to content

fix(image_gen): disable default-on upscaling — opt-in only - #87883

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-f8241f8e
Aug 16, 2026
Merged

fix(image_gen): disable default-on upscaling — opt-in only#87883
teknium1 merged 1 commit into
mainfrom
hermes/hermes-f8241f8e

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Upscaling no longer runs by default on any image model — it is strictly per-call opt-in (upscale: true).

Root cause of the quality regression: 66ea4e6 (Aug 8) flipped upscale: True on every sub-2MP FAL/Krea model, chaining the Clarity Upscaler — an SD1.5 creative tile-diffusion enhancer (creativity 0.35, "masterpiece" prompt prefix) that redraws content — after 100% of generations. For models whose value is precise output (GPT Image 2 text/CJK rendering, Ideogram typography, photorealistic faces), every image came out visibly degraded.

Changes

  • tools/image_generation_tool.py: all 17 default-on FAL catalog entries → upscale: False; tool-schema description now documents opt-in + fidelity caveat
  • plugins/image_gen/krea/__init__.py: medium + medium-turbo per-model defaults → off
  • tests/tools/test_image_generation.py: catalog invariant now pins all-off; default-path cases assert no upscaler call
  • tests/plugins/image_gen/test_krea_provider.py: default-on cases updated to off
  • website/docs (en + zh): upscaling section rewritten to the opt-in policy

Validation

Before After
gpt-image-2 default generation (live E2E, managed FAL path) Clarity pass ran, output re-rendered upscaled: false, raw model output returned
Catalog default-on entries 17 0
Targeted tests (image gen + i2i + krea) 94/94 pass

Explicit upscale: true still chains Clarity (FAL) / Krea Enhance exactly as before.

Infographic

Upscaling off by default

The Aug 8 default-on upscaling policy (66ea4e6) chained the Clarity
Upscaler after every sub-2MP generation. Clarity is an SD1.5 creative
tile-diffusion enhancer (creativity 0.35, "masterpiece" prompt prefix) —
it redraws content, which degraded output on 100% of generations for
models like GPT Image 2 and Ideogram whose value is precise text
rendering, CJK, and photorealistic detail.

Policy now: no model upscales by default, on FAL or Krea. The `upscale`
tool param remains as a per-call opt-in (`upscale: true`); explicit
requests still chain Clarity (FAL) / Krea Enhance as before.

- FAL catalog: all 17 default-on entries flipped to upscale=False
- Krea plugin: medium + medium-turbo per-model defaults flipped off
- Tool schema: upscale param described as opt-in with a fidelity warning
- Tests updated: catalog invariant now pins all-off; default-on cases
  now assert no upscaler call
- Docs (en + zh) updated to the opt-in policy
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 871024f — fix(image_gen): disable default-on upscaling everywhere — op

⚠️ Warnings

OSV vulnerability scan · View job

5 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


debug info

CI timings

CI timings · View report · View job

Wall time 3m30s vs 4m25s (-20.8%). 14 job(s) slower, 9 faster, 2 unchanged.

  • Python tests / Run tests slice 9/12: +27.0s
  • OS-specific tests / macOS-only tests: +14.0s
  • Python tests / Run tests slice 4/12: -13.0s
  • Python tests / Run tests slice 3/12: +10.0s
  • OSV scan / Scan lockfiles / osv-scan: +7.0s

@teknium1
teknium1 merged commit f06c415 into main Aug 16, 2026
45 checks passed
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins tool/vision Vision analysis and image generation labels Aug 16, 2026
@teknium1
teknium1 deleted the hermes/hermes-f8241f8e branch August 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants