Skip to content

Main is green again: FAL Grok 2.0 upscale flag follows the opt-in policy - #89935

Closed
teknium1 wants to merge 1 commit into
mainfrom
fix/fal-grok2-upscale-optin
Closed

Main is green again: FAL Grok 2.0 upscale flag follows the opt-in policy#89935
teknium1 wants to merge 1 commit into
mainfrom
fix/fal-grok2-upscale-optin

Conversation

@teknium1

@teknium1 teknium1 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the main-branch red introduced by #87465: its grok-imagine-image-2.0 FAL catalog entry set upscale: True, violating the Aug 2026 opt-in-only upscale policy (f06c415). The entry was authored before the policy landed and its stale-base CI never exercised the policy test.

Changes

  • tools/image_generation_tool.py: upscale: False on the FAL Grok 2.0 entry

Validation

Before After
TestFalCatalog::test_upscale_defaults_are_all_off FAILED on main 5/5 pass

Infographic

one-line policy fix

@teknium1
fix(image-gen): FAL grok-imagine-image-2.0 upscale is opt-in per Aug …
581ec8a 
…2026 policy

The #87465 catalog entry predated the opt-in-only upscale policy
(f06c415) and its stale-base CI never ran the policy test, so main went
red on test_upscale_defaults_are_all_off after merge.
@github-actions

github-actions Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 581ec8a — fix(image-gen): FAL grok-imagine-image-2.0 upscale is opt-in

⚠️ Warnings

CI timings · View report · View job

Wall time 6m40s vs 4m4s (+63.9%). 21 job(s) slower, 2 faster, 1 unchanged.

  • Python tests / Run tests slice 3/12: +89.0s
  • Python tests / Run tests slice 12/12: +69.0s
  • Python tests / Run tests slice 2/12: +67.0s
  • Python tests / Run tests slice 5/12: +59.0s
  • OS-specific tests / Windows-only tests: +57.0s

OSV vulnerability scan · View job

7 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.

@teknium1 teknium1 mentioned this pull request Aug 19, 2026
Open
@alt-glitch alt-glitch added type/bug Something isn't working tool/vision Vision analysis and image generation provider/xai xAI (Grok) P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Aug 19, 2026
@alt-glitch

alt-glitch commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #89933: this applies the same Grok Imagine 2.0 default-upscale change. Please consolidate review on the earlier PR.

@Shotflame Shotflame mentioned this pull request Aug 19, 2026
Merged
@Christopher-Schulze Christopher-Schulze mentioned this pull request Aug 19, 2026
Open
7 tasks
@100yenadmin 100yenadmin mentioned this pull request Aug 19, 2026
Open
@jackulau jackulau mentioned this pull request Aug 19, 2026
Open
19 tasks
@andrexibiza andrexibiza mentioned this pull request Aug 19, 2026
Closed
@teknium1

teknium1 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Superseded — the identical fix landed on main minutes earlier (9b5e7a3). Closing.

@teknium1 teknium1 closed this Aug 19, 2026
@teknium1
teknium1 deleted the fix/fal-grok2-upscale-optin branch August 19, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/xai xAI (Grok) tool/vision Vision analysis and image generation type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teknium1 @alt-glitch