Repository navigation
fix(cli): don't warn on plugin toolsets; skip kanban TERMINAL_CWD deprecation - #88003
mattamundson wants to merge 1 commit into
Conversation
…recation Two startup false-positives that spam every kanban worker log: 1. cli.py: HermesCLI toolset validation reported 'Unknown toolsets: omh' for plugin toolsets. Plugins register their toolsets during plugin load, which happens AFTER this CLI startup validation (same timing problem as MCP names, which were already excluded). Exclude names declared in known_plugin_toolsets.<platform> the same way. 2. hermes_cli/config.py: warn_deprecated_cwd_env_vars() warned kanban workers that TERMINAL_CWD was a stale .env entry. Kanban workers deliberately pin TERMINAL_CWD to the task workspace (kanban_db.py worker spawn) so file tools anchor there. The HERMES_SESSION_SOURCE =kanban marker now suppresses the warning for workers only. Verified: fresh kanban worker (run 9, task t_84a6af4d) produces a clean log with neither warning; board stays healthy.
#88003 — Verified mergeable: fix CLI false-positive warnings for plugin toolsets and kanban worker TERMINAL_CWDVerdict: MERGE. Both changes correctly scoped; behavior verified; minor non-blocking test gap. Two independent false-positive fixes, both traced against real code:
Behavioral verification (worktree, PR head
|
Summary
Two startup false-positives that spam every kanban worker log (and any CLI run that enables a plugin toolset):
cli.py— 'Unknown toolsets: omh' for plugin toolsets.HermesCLIvalidates toolset names at startup, but plugin toolsets are registered during plugin load, which happens after this validation — the same timing problem as MCP server names, which were already excluded (see existingmcp_namesexclusion). This PR excludes names declared inknown_plugin_toolsets.<platform>the same way.hermes_cli/config.py— spurious TERMINAL_CWD deprecation warning in kanban workers.warn_deprecated_cwd_env_vars()warned thatTERMINAL_CWDwas a stale .env entry. Kanban workers deliberately pinTERMINAL_CWDto the task workspace (kanban_db.py worker spawn) so file tools and context-file loading anchor on the workspace. Workers are marked withHERMES_SESSION_SOURCE=kanban; the warning now skips that case only.Motivation
A kanban worker task (
t_fc43cdca) crashed twice at startup in July because its required skill was missing — but the only content in the worker log was these warning lines, which made the real error hard to spot. Clean worker logs make kanban diagnostics readable.Verification
python -m py_compile cli.py hermes_cli/config.py— clean.invalid = []forplatform_toolsets.cli(omh no longer flagged).