Skip to content

fix(cli): don't warn on plugin toolsets; skip kanban TERMINAL_CWD deprecation #88003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattamundson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): don't warn on plugin toolsets; skip kanban TERMINAL_CWD deprecation #88003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4939,8 +4939,14 @@ def __init__(
# Validate each toolset — MCP server names are resolved via
# live registry aliases (registered during discover_mcp_tools),
# but discovery hasn't run yet at this point, so exclude them.
# Same for plugin toolset names declared in known_plugin_toolsets:
# plugins register their toolsets during load, which happens
# after this validation, so a declared plugin toolset must not
# be reported as unknown.
mcp_names = set((CLI_CONFIG.get("mcp_servers") or {}).keys())
invalid = [t for t in toolsets if not validate_toolset(t) and t not in mcp_names]
known_plugin = (CLI_CONFIG.get("known_plugin_toolsets") or {}).get("cli") or []
excluded = mcp_names | set(known_plugin)
invalid = [t for t in toolsets if not validate_toolset(t) and t not in excluded]
if invalid:
self._console_print(f"[bold red]Warning: Unknown toolsets: {', '.join(invalid)}[/]")

Expand Down
6 changes: 5 additions & 1 deletion hermes_cli/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2205,7 +2205,11 @@ def warn_deprecated_cwd_env_vars(config: Optional[Dict[str, Any]] = None) -> Non
f" \033[33m⚠\033[0m MESSAGING_CWD={messaging_cwd} found in .env — "
f"this is deprecated."
)
if terminal_cwd_env and not config_has_explicit_cwd:
# Kanban workers deliberately pin TERMINAL_CWD to the task workspace so
# file tools anchor there (kanban_db worker spawn); that is a runtime
# bridge, not a stale .env entry — don't warn about it.
_is_kanban_worker = os.environ.get("HERMES_SESSION_SOURCE") == "kanban"
if terminal_cwd_env and not config_has_explicit_cwd and not _is_kanban_worker:
# TERMINAL_CWD in env but not from config bridge — likely from .env
lines.append(
f" \033[33m⚠\033[0m TERMINAL_CWD={terminal_cwd_env} found in .env — "
Expand Down