Repository navigation
Conversation
… before plugin registration cli.py validates the enabled-toolset list via validate_toolset() in the constructor, before plugin toolset registration runs. Plugin toolsets like 'a2a' or 'spotify' therefore look unknown at that early moment and produce a spurious 'Warning: Unknown toolsets: a2a' even though they register fine moments later (confirmed '✓ a2a connected' in gateway.log). Mirror the existing MCP-server-name exclusion: also exclude toolset names recorded in config's known_plugin_toolsets (a platform → list-of-names map written by the 'hermes tools' save flow). Those are plugin-provided toolsets that legitimately resolve later in startup.
Duplicate of #88003 for the same pre-registration plugin-toolset warning mechanism. |
12 of 13 tasks
12 of 13 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.pyprints a spuriousWarning: Unknown toolsets: a2a(andspotify) on startup even though those plugin toolsets load and work correctly moments later.Root cause
The
HermesCLIconstructor validates the enabled-toolset list viavalidate_toolset()before plugin toolset registration runs. Plugin toolsets likea2a/spotifyare registered at plugin load time (after this constructor), so they look unknown at this early point.The existing code already excludes MCP server names from the check for exactly this reason (MCP names resolve later during discovery). Plugin toolsets are the same class of "resolves later" name, but weren't excluded.
Fix
Mirror the MCP-name exclusion: also skip toolset names recorded in config's
known_plugin_toolsets(a platform → list-of-names map written by thehermes toolssave flow — seehermes_cli/tools_config.py).Verification
python3 -c "import ast; ast.parse(open('cli.py').read())"→ clean.a2ais present inknown_plugin_toolsetson a live config, so the warning is suppressed.✓ a2a connectedin gateway.log and thea2a_*tools present in the session catalog.Notes
hermes update(by design — it's an upstream change).