Skip to content

fix(gateway): include messaging in configurable toolsets - #9870

Closed
Ruzzgar wants to merge 2 commits into
NousResearch:mainfrom
Ruzzgar:fix/gateway-messaging-toolset
Closed

fix(gateway): include messaging in configurable toolsets#9870
Ruzzgar wants to merge 2 commits into
NousResearch:mainfrom
Ruzzgar:fix/gateway-messaging-toolset

Conversation

@Ruzzgar

@Ruzzgar Ruzzgar commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Root Cause

Gateway platform defaults include send_message through _HERMES_CORE_TOOLS, and toolsets.py already defines the messaging toolset. However, hermes_cli.tools_config._get_platform_tools() reverse-maps composite platform toolsets only through CONFIGURABLE_TOOLSETS. Because messaging was missing from that list, gateway defaults such as hermes-telegram resolved without the messaging toolset, silently dropping send_message.

Repro

  1. Use default gateway platform toolset resolution for Telegram.
  2. toolsets.py contains send_message and the messaging toolset.
  3. CONFIGURABLE_TOOLSETS does not contain messaging.
  4. _get_platform_tools({}, "telegram") cannot reverse-map send_message back to messaging.

Fix

Add messaging to CONFIGURABLE_TOOLSETS so default gateway composite toolsets resolve it like other built-in toolsets.

Tests

Added test_get_platform_tools_includes_messaging_for_gateway_defaults.

I attempted to run:

python -m pytest tests\hermes_cli\test_tools_config.py -q

@nidhishgajjar

Copy link
Copy Markdown

Orb Code Review (powered by GLM 5.1 on Orb Cloud)

PR #9870 — fix(gateway): include messaging in configurable toolsets

Summary of Changes

Adds ("messaging", "💬 Messaging", "send_message") to the CONFIGURABLE_TOOLSETS registry, making the messaging toolset visible in tool configuration for gateway sessions.

Review

Correctness

  • The send_message tool was likely already functional but not listed in CONFIGURABLE_TOOLSETS, meaning it couldn't be toggled or displayed in tool management. This registration fixes that gap.
  • Placed in logical alphabetical/grouped position between delegation and rl.

Testing

  • New test verifies that default gateway composites include the messaging toolset. The test is concise and targets the exact regression.

One minor observation: The test checks assert "messaging" in enabled which verifies the toolset name. This is correct for the current data structure, but worth noting that if the return format changes from a set of strings to something richer, this test would need updating. Not an issue — just a note for future reference.

Summary

Small, targeted fix that registers an overlooked toolset. Good test coverage.

Assessment: approve

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @Ruzzgar!

Closing this as a duplicate of #8626 (by @sgaofen), which targets the same fix/feature. We're consolidating on that PR for review.

If you want to help push it over the line, please jump in there — or if you think your approach is better for a specific reason that isn't covered in the other PR, let us know and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants