fix(gateway): include messaging in configurable toolsets - #9870
Conversation
|
Orb Code Review (powered by GLM 5.1 on Orb Cloud) PR #9870 — fix(gateway): include messaging in configurable toolsetsSummary of ChangesAdds ReviewCorrectness ✅
Testing ✅
One minor observation: The test checks SummarySmall, targeted fix that registers an overlooked toolset. Good test coverage. Assessment: approve |
|
Thanks for the contribution, @Ruzzgar! Closing this as a duplicate of #8626 (by @sgaofen), which targets the same fix/feature. We're consolidating on that PR for review. If you want to help push it over the line, please jump in there — or if you think your approach is better for a specific reason that isn't covered in the other PR, let us know and we can reopen. |
Root Cause
Gateway platform defaults include
send_messagethrough_HERMES_CORE_TOOLS, andtoolsets.pyalready defines themessagingtoolset. However,hermes_cli.tools_config._get_platform_tools()reverse-maps composite platform toolsets only throughCONFIGURABLE_TOOLSETS. Becausemessagingwas missing from that list, gateway defaults such ashermes-telegramresolved without themessagingtoolset, silently droppingsend_message.Repro
toolsets.pycontainssend_messageand themessagingtoolset.CONFIGURABLE_TOOLSETSdoes not containmessaging._get_platform_tools({}, "telegram")cannot reverse-mapsend_messageback tomessaging.Fix
Add
messagingtoCONFIGURABLE_TOOLSETSso default gateway composite toolsets resolve it like other built-in toolsets.Tests
Added
test_get_platform_tools_includes_messaging_for_gateway_defaults.I attempted to run:
python -m pytest tests\hermes_cli\test_tools_config.py -q