Fix misleading terminal tool description for Windows users - #7667
Closed
jiakeboge wants to merge 5 commits into
Closed
Fix misleading terminal tool description for Windows users#7667jiakeboge wants to merge 5 commits into
jiakeboge wants to merge 5 commits into
Conversation
The previous description mentioned "Linux environment" and "cloud sandboxes" which could confuse Windows users running in local mode into thinking the agent was executing remotely. Changes: - "Linux environment" -> "configured environment (local machine, Docker container, or cloud sandbox depending on setup)" - "cloud sandboxes" -> "Sandboxes (when configured)" This makes the description accurately reflect that the execution environment depends on the user's TERMINAL_ENV configuration. 🤖 Generated with [Qoder][https://qoder.com]
1 task
Update code_execution_tool.py to use the same sandbox persistence wording already applied in terminal_tool.py. This avoids implying that cloud sandbox backends are the default session behavior, which is misleading for local backend users. Related to NousResearch#7667
Ensures the execute_code tool schema doesn't unconditionally claim cloud sandbox usage, matching the terminal_tool fix for NousResearch#7672. 🤖 Generated with [Qoder][https://qoder.com]
alt-glitch
added
type/docs
Collaborator
teknium1
reviewed
Jul 12, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing a real cross-platform description defect. Current main still hardcodes "Linux environment" in tools/terminal_tool.py:958, although _get_env_config() and _create_environment() support local, Docker, SSH, Singularity, Modal, and Daytona (tools/terminal_tool.py:1260-1424).
Problems
- The
execute_codeaddition repeatsterminal() is foreground-only (no background or pty)immediately before the unchanged identical sentence (tools/code_execution_tool.py:1529-1532in this PR). - The public tools reference retains the same Linux-only statement at
website/docs/reference/tools-reference.md:170; the schema-only update leaves user-facing documentation inconsistent.
Suggested changes
- Keep one foreground-only sentence in
build_execute_code_schema(). - Carry the backend-agnostic wording into
website/docs/reference/tools-reference.md:170. - Prefer regression assertions for the durable no-Linux-only claim over incidental exact phrasing.
Automated hermes-sweeper review.
| f"Available via `from hermes_tools import ...`:\n\n" | ||
| f"{tool_lines}\n\n" | ||
| "Limits: 5-minute timeout, 50KB stdout cap, max 50 tool calls per script. " | ||
| "terminal() is foreground-only (no background or pty). " |
Contributor
There was a problem hiding this comment.
This sentence is duplicated by the unchanged next line. Keep the new sandbox-persistence wording if desired, but retain only one terminal() is foreground-only (no background or pty) sentence in the generated schema.
teknium1
added
sweeper:risk-platform-windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7672 by updating the
terminaltool description to reflect Hermes' configurable execution backends.The previous wording implied commands always ran in a Linux cloud environment, which was misleading for local
users, especially Windows users running with
TERMINAL_ENV=local.This PR makes the schema text backend-agnostic:
Scope
Text-only change in
tools/terminal_tool.py.No runtime behavior changes.