Skip to content

fix(terminal): don't hardcode 'Linux environment' in tool description (#7672) - #53323

Closed
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/7672-terminal-description-v3
Closed

fix(terminal): don't hardcode 'Linux environment' in tool description (#7672)#53323
iacker wants to merge 1 commit into
NousResearch:mainfrom
iacker:fix/7672-terminal-description-v3

Conversation

@iacker

@iacker iacker commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #7672. The terminal tool description opened with "Execute shell commands on a Linux environment", which is misleading for users running locally on Windows/macOS or against a non-Linux configured backend.

Fix

Reword the first sentence to frame the environment as configured — local machine, Docker container, or cloud sandbox depending on setup — without hardcoding Linux. Minimal one-line change to the description string; the rest of the prompt (read_file/search_files/patch guidance, the persistence contract) is untouched.

-Execute shell commands on a Linux environment. Filesystem, current working directory, ...
+Execute shell commands in the configured execution environment (local machine, Docker container, or cloud sandbox depending on setup — not necessarily Linux). Filesystem, current working directory, ...

Tests

Adds tests/tools/test_terminal_tool_description.py with invariant-style assertions (not a snapshot freeze):

  • description no longer contains "Linux environment"
  • it names the real configured options (local machine / Docker container)
  • the "persist between calls" persistence contract survives
3 passed in 1.09s

Note

Rebased reimplementation of #23242 onto current main (the base description string had since changed, so the old branch no longer applied cleanly). #23242 will be closed in favor of this one.

… (#7672)

The terminal tool description opened with 'Execute shell commands on a
Linux environment', which is misleading for users running locally on
Windows/macOS or against a non-Linux configured backend. Reword to frame
the environment as configured (local machine, Docker container, or cloud
sandbox depending on setup), without claiming Linux.

Minimal one-line change to the description string; the rest of the prompt
(read_file/search_files/patch guidance, persistence contract) is
untouched. Adds an invariant-style test asserting the description no
longer hardcodes Linux and names the real configured options.

Rebased reimplementation of #23242 onto current main.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/terminal Terminal execution and process management duplicate This issue or pull request already exists labels Jun 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #7667 — both reword TERMINAL_TOOL_DESCRIPTION in tools/terminal_tool.py from "Execute shell commands on a Linux environment" to a configured-environment phrasing for the same issue #7672 (#7667 is the earliest open competing fix; the canonically-titled #8364 is closed).

@iacker

iacker commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Re the duplicate flag: agreed #7667 targets the same issue (#7672) and is earliest — happy to defer if it lands. Two factual notes for whoever triages the cluster:

Whichever vehicle maintainers prefer — the point is just that #7672 is fixable today with a green, conflict-free diff.

@iacker iacker closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Terminal tool description is misleading for Windows users

2 participants