fix(terminal): don't hardcode 'Linux environment' in tool description (#7672) - #53323
Closed
iacker wants to merge 1 commit into
Closed
fix(terminal): don't hardcode 'Linux environment' in tool description (#7672)#53323iacker wants to merge 1 commit into
iacker wants to merge 1 commit into
Conversation
… (#7672) The terminal tool description opened with 'Execute shell commands on a Linux environment', which is misleading for users running locally on Windows/macOS or against a non-Linux configured backend. Reword to frame the environment as configured (local machine, Docker container, or cloud sandbox depending on setup), without claiming Linux. Minimal one-line change to the description string; the rest of the prompt (read_file/search_files/patch guidance, persistence contract) is untouched. Adds an invariant-style test asserting the description no longer hardcodes Linux and names the real configured options. Rebased reimplementation of #23242 onto current main.
Collaborator
Duplicate of #7667 — both reword |
Contributor
Author
|
Re the duplicate flag: agreed #7667 targets the same issue (#7672) and is earliest — happy to defer if it lands. Two factual notes for whoever triages the cluster:
Whichever vehicle maintainers prefer — the point is just that #7672 is fixable today with a green, conflict-free diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7672. The
terminaltool description opened with "Execute shell commands on a Linux environment", which is misleading for users running locally on Windows/macOS or against a non-Linux configured backend.Fix
Reword the first sentence to frame the environment as configured — local machine, Docker container, or cloud sandbox depending on setup — without hardcoding Linux. Minimal one-line change to the description string; the rest of the prompt (read_file/search_files/patch guidance, the persistence contract) is untouched.
Tests
Adds
tests/tools/test_terminal_tool_description.pywith invariant-style assertions (not a snapshot freeze):Note
Rebased reimplementation of #23242 onto current
main(the base description string had since changed, so the old branch no longer applied cleanly). #23242 will be closed in favor of this one.