-
Notifications
You must be signed in to change notification settings - Fork 52.2k
Fix misleading terminal tool description for Windows users #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jiakeboge
wants to merge
5
commits into
NousResearch:main
from
jiakeboge:fix-terminal-tool-description
+27
−1
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3abd5c3
Fix misleading terminal tool description for Windows users
jiakeboge 75780a5
Align execute_code sandbox description with terminal tool wording
jiakeboge 4583849
fix(terminal): clarify configured execution environment
iacker 0b12c61
test: add regression test for execute_code sandbox description
jiakeboge 70d16cd
Merge branch 'main' into fix-terminal-tool-description
jiakeboge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| from tools.terminal_tool import TERMINAL_TOOL_DESCRIPTION | ||
| from tools.code_execution_tool import build_execute_code_schema | ||
|
|
||
|
|
||
| def test_terminal_tool_description_mentions_configured_environment(): | ||
| assert "configured environment" in TERMINAL_TOOL_DESCRIPTION | ||
| assert "local machine" in TERMINAL_TOOL_DESCRIPTION | ||
| assert "Docker container" in TERMINAL_TOOL_DESCRIPTION | ||
| assert "Linux environment" not in TERMINAL_TOOL_DESCRIPTION | ||
|
|
||
|
|
||
| def test_terminal_tool_description_scopes_sandbox_warning(): | ||
| assert "sandboxes (when configured)" in TERMINAL_TOOL_DESCRIPTION | ||
| assert "cloud sandboxes may be cleaned up" not in TERMINAL_TOOL_DESCRIPTION | ||
|
|
||
|
|
||
| def test_execute_code_schema_scopes_sandbox_warning(): | ||
| """execute_code schema should not unconditionally claim cloud sandbox usage.""" | ||
| schema = build_execute_code_schema() | ||
| description = schema["description"] | ||
| assert "Sandboxes (when configured)" in description | ||
| assert "cloud sandbox" not in description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is duplicated by the unchanged next line. Keep the new sandbox-persistence wording if desired, but retain only one
terminal() is foreground-only (no background or pty)sentence in the generated schema.