Repository navigation
Conversation
validate_toolset() in HermesCLI.__init__ ran before discover_plugins(), so plugin-registered toolsets (e.g. beads, spotify) were always reported as "Unknown toolsets" on every startup — a false-positive warning because the toolsets were valid and worked at runtime. Run discover_plugins() before the validation block so the tool registry reflects plugin entries. MCP server names are still excluded from validation since MCP discovery hasn't run yet. Closes NousResearch#71650
Duplicate of #29774: both patches address the same CLI ordering defect by discovering plugin toolsets before validation. |
2 of 3 tasks
Author
|
Closing as duplicate of #29774. Please merge that PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HermesCLI.__init__calledvalidate_toolset()beforediscover_plugins(), so plugin-registered toolsets (e.g.beads,spotify) were always flagged asWarning: Unknown toolsetson every startup — even though they worked correctly at runtime.Root Cause
cli.py:4283-4290— the validation block queriestools.registryviavalidate_toolset() → _get_plugin_toolset_names(), but the registry isn't populated with plugin toolsets untildiscover_plugins()runs. The comment already noted that "discovery hasn't run yet" (referring to MCP), but the same gap applied to plugin-registered toolsets.Fix
Run
discover_plugins()(best-effort, exception-silenced) before the validation block so the tool registry reflects plugin entries.Live Proof
Test run
Risk
Low.
discover_plugins()is idempotent and already called elsewhere during startup. The call is exception-guarded so plugin discovery failure does not block CLI startup.