Skip to content

fix(cli): run plugin discovery before toolset validation #71729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linux2010 wants to merge 1 commit into from
Closed

fix(cli): run plugin discovery before toolset validation #71729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4281,9 +4281,16 @@ def __init__(
self.disabled_toolsets = CLI_CONFIG["agent"].get("disabled_toolsets") or []

if toolsets and "all" not in toolsets and "*" not in toolsets:
# Validate each toolset — MCP server names are resolved via
# live registry aliases (registered during discover_mcp_tools),
# but discovery hasn't run yet at this point, so exclude them.
# Validate each toolset — ensure plugins are loaded so
# plugin-registered toolsets are recognized. MCP server names
# are resolved via live registry aliases (registered during
# discover_mcp_tools), but discovery hasn't run yet either, so
# exclude them.
try:
from hermes_cli.plugins import discover_plugins
discover_plugins()
except Exception:
pass
mcp_names = set((CLI_CONFIG.get("mcp_servers") or {}).keys())
invalid = [t for t in toolsets if not validate_toolset(t) and t not in mcp_names]
if invalid:
Expand Down
Loading