Skip to content

fix(cli): discover plugin toolsets before validation - #29774

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-29532-plugin-toolset-warning
Open

LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-29532-plugin-toolset-warning

Conversation

@LeonSGP43

Copy link
Copy Markdown

Summary

  • run plugin discovery before HermesCLI validates explicitly requested toolsets
  • keep constructor-time validation from warning on plugin-provided toolsets outside the main entrypoint
  • add a regression test covering the plugin-toolset discovery path

Fixes #29532

Testing

  • uv run --frozen pytest -q -o addopts= tests/cli/test_cli_init.py\n- uv run --frozen ruff check cli.py tests/cli/test_cli_init.py\n- git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels May 21, 2026
@alt-glitch

Copy link
Copy Markdown

Related to #25714 — similar fix (discover plugins before toolset validation) but that PR bundles an entire code_intel feature with scope creep. This PR is the minimal targeted fix. Also related to closed #15499 (same pattern, different code path).

@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for isolating the constructor-time plugin discovery ordering issue. Current main still validates before discovery at cli.py:3883-3890, while the one-shot path already discovers and re-validates unresolved names at hermes_cli/oneshot.py:65-76.

Problems

Suggested changes

Automated hermes-sweeper review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Getting a weird error since I installed and now it's harassing me in tui about the warning

3 participants