Skip to content

feat(i18n): add Spanish (es) locale for desktop UI - #68836

Closed
valeracjva wants to merge 1 commit into
NousResearch:mainfrom
valeracjva:feat/desktop-i18n-spanish
Closed

feat(i18n): add Spanish (es) locale for desktop UI#68836
valeracjva wants to merge 1 commit into
NousResearch:mainfrom
valeracjva:feat/desktop-i18n-spanish

Conversation

@valeracjva

Copy link
Copy Markdown

Summary

Adds complete Spanish (es) locale support for the Hermes Desktop app, using defineLocale() for a partial locale that falls back to English for any untranslated keys (same pattern as ja.ts).

Changes

File Change
apps/desktop/src/i18n/es.ts New — 2,055 lines of Spanish translations covering all major UI sections
apps/desktop/src/i18n/catalog.ts Register es in TRANSLATIONS
apps/desktop/src/i18n/languages.ts Add es entry + 8 locale aliases
apps/desktop/src/i18n/types.ts Add 'es' to Locale type

Coverage

Translated sections include: common, fileMenu, boot, notifications, remoteDisplayBanner, titlebar, keybinds, language, settings (full), skills hub, starmap, agents, commandCenter, messaging, profiles, cron, artifacts, sidebar, composer, statusStack, updates, install, onboarding, modelPicker, shell, rightSidebar.

Testing

  • Untranslated keys gracefully fall back to English via defineLocale().
  • Locale aliases cover es, es-es, es-ar, es-mx, es-419 for broad regional support.
  • No unused imports; follows existing ja.ts partial locale pattern.

Closes #68822

Adds Spanish translations for the Hermes Desktop app using defineLocale()
for partial locale with English fallback.

- Adds apps/desktop/src/i18n/es.ts with 2055 translated strings
- Registers 'es' in languages.ts with locale aliases (es, es-es, es-ar, es-mx, es-419)
- Registers 'es' in catalog.ts TRANSLATIONS record
- Updates Locale type in types.ts to include 'es'

Closes NousResearch#68822
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) area/i18n Localization, locales, translations sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades duplicate This issue or pull request already exists labels Jul 21, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #41230: both implement the same Desktop Spanish locale catalog and registration surface. #54415 remains related because it also includes dashboard translation work.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the Spanish Desktop locale contribution. The underlying need remains real: current main has no apps/desktop/src/i18n/es.ts or Spanish locale registration.

Problems

  • This branch is based on a88512b114059fff642d60d54cbf30d5793c6c37 and is currently DIRTY. Current locale registration has since changed for Arabic in apps/desktop/src/i18n/catalog.ts:1-13, apps/desktop/src/i18n/languages.ts:32-37, and apps/desktop/src/i18n/types.ts:8 (commit 5b6990e7a0).
  • The diff changes no tests, despite adding Spanish aliases. Existing alias, exact-ID, and persistence expectations are covered in apps/desktop/src/i18n/languages.test.ts:6-46.

Suggested changes

  • Preserve any distinct Spanish copy or aliases by salvaging them into the current feat(desktop): add Spanish locale #41230 catalog and its current test coverage rather than applying this stale registration patch wholesale.
  • Add alias-normalization and config-selection coverage for es following the existing i18n tests.

Automated hermes-sweeper review.

@teknium1 teknium1 added the sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform label Jul 30, 2026
@valeracjva

Copy link
Copy Markdown
Author

Cerrando en favor de #41230 que tiene implementación más completa con tests, fix del placeholder y mayor cobertura de secciones. Gracias por la revisión.

@valeracjva

Copy link
Copy Markdown
Author

Duplicate of #41230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Localization, locales, translations comp/desktop Electron desktop app (apps/desktop/*) duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(i18n): add Spanish (es) locale for desktop UI

3 participants