feat(desktop): add Spanish locale - #41230
Conversation
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the Spanish Desktop locale contribution. The feature is still absent from current main: apps/desktop/src/i18n/languages.ts:7-32 and apps/desktop/src/i18n/catalog.ts:7-12 register only en/zh/zh-hant/ja.
Problems
- The locale-sensitive placeholder effect in this PR has moved. Current main owns it in
apps/desktop/src/app/chat/composer/hooks/use-composer-placeholder.ts:21-59; its effect only responds to a session change. Preserve the PR’s locale-change behavior there so an already-open composer does not retain English placeholder text after switching to Spanish. - The i18n contract has expanded materially since the PR base:
git diff --stat fa8fd513..HEAD -- apps/desktop/src/i18nreports 3,697 added lines. Rebase the Spanish overrides on currentTranslationsso newly added Desktop UI does not fall back to English unintentionally.
Suggested changes
- Salvage the locale catalog and aliases onto current main, then update
use-composer-placeholder.tsand add a locale-switch-without-session-change test. - Coordinate catalog choice with the related open Spanish locale PRs #49036 and #54970.
Automated hermes-sweeper review.
00fe600 to
bf411a7
Compare
|
Spanish native-language review requested for final head @pgsonic @mistaker47, could either of you review the current Desktop Spanish wording when you have a moment? The catalog has been rebuilt against the current contract (2,357 entries with no missing keys or parameter mismatches), and the automated checks and local Desktop smoke test have passed. I will wait for that language review and the new CI run before asking a maintainer to merge. |
|
Hola @sdyckjq-lab — acabo de cerrar mi PR #64793 como duplicado del tuyo. Llegué de forma independiente a las mismas correcciones contextuales que reportaron en triage (toggle on/off → Activado/Desactivado, muted → Silenciado, smart → Inteligente) y confirmé que ya están en tu catálogo, así que cerrar el mío no pierde nada. Gracias por llevar la implementación canónica del locale es; si quieres una segunda lectura o ayuda con el rebase contra main, avísame. ¡Buen trabajo! |
|
Hi @sdyckjq-lab, I opened PR #68836 with a Spanish Desktop locale implementation for issue #68822. I understand from the current triage that #41230 is the preferred canonical implementation, and I am happy to defer to it rather than maintain competing PRs. If useful, please feel free to salvage any wording or regional aliases from #68836. I am also available to review the Spanish copy or help validate the locale behavior from an Argentine Spanish perspective. Once #41230 is merged and the Spanish locale is verified, I will close #68836 as a duplicate. |
bf411a7 to
9538cef
Compare
|
Hi @valeracjva — thank you for offering to help from an Argentine Spanish perspective. I have rebased and refreshed #41230 on the current Could you please:
If you find anything to change, please leave the corrections here. If the copy looks good, an explicit confirmation that you reviewed the current head would help us complete the language-review gate before merge. |
|
Hi @sdyckjq-lab — yes, I’m a native Spanish speaker. My native variety is neutral Venezuelan Spanish, and I’ve also lived in Argentina for almost ten years. I reviewed the current head I only found a few small wording tweaks worth making:
Other than those minor adjustments, the locale looks good to me for neutral international Spanish and a natural |
Summary
Hermes Desktop can now be used in Spanish through the existing language picker, with English remaining the default. This refresh rebuilds the Spanish catalog against the current Desktop translation contract so the current interface does not silently fall back to English.
es) asEspañolin the Desktop language picker.Scope
es,es-ES,es_ES,es-419,es_419,es-MX,es_MX,es-AR, andes_AR, all persisted canonically ases.es-CLon the existing English fallback path.Verification
test:desktop:all; the final DMG also passed macOS disk-image verification.Español, confirmed the main UI and picker changed, and confirmed a typed draft stayed intact while switching languages.Tested on macOS 26.3.1 arm64.
Review status
A full native-Spanish copy review is still requested before merge.
Co-authored-by: Kiro 有点Yes 246816394+sdyckjq-lab@users.noreply.github.com