Conversation
Chytzo
force-pushed
the
i18n/es-es-dashboard-fix
branch
from
June 28, 2026 20:21
e73a336 to
4094997
Compare
13 tasks
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for extending Spanish support across the dashboard and Desktop.
Problems
apps/desktop/src/i18n/es.ts:5is a completeTranslationsobject, but current main now requirescommon.expand,common.formatJson, andcommon.tryHint(apps/desktop/src/i18n/types.ts:73-88). PR head4094997contains none of those keys, so it cannot typecheck against current main.- The alias additions in
apps/desktop/src/i18n/languages.tshave no corresponding update toapps/desktop/src/i18n/languages.test.ts; the existing suite covers alias normalization, support detection, exact IDs, and persisted values at lines 5-42.
Suggested changes
- Rebuild the Spanish catalog against the current
Translationscontract, then run the Desktop typecheck. - Add coverage for the new Spanish aliases and persisted locale value.
- Reconcile the dashboard wording independently during salvage; the branch is 3,522 commits behind current main from merge-base
5f6be7f31bd7.
This is an automated hermes-sweeper review.
|
|
||
| import type { Translations } from './types' | ||
|
|
||
| export const es: Translations = { |
Collaborator
There was a problem hiding this comment.
This strict Translations object is stale against current main: common.expand, common.formatJson, and common.tryHint are now required by apps/desktop/src/i18n/types.ts:73-88, but are absent from this catalog. Please regenerate/reconcile the catalog from current main before typechecking.
Chytzo
force-pushed
the
i18n/es-es-dashboard-fix
branch
from
July 15, 2026 16:30
4094997 to
17e07d8
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the existing Spanish translation of the Hermes web dashboard and adds full Spanish (es) locale support to the Hermes Desktop app.
Changes
Dashboard (web/src/i18n/es.ts)
Desktop App (apps/desktop/src/i18n/)
eslocale to the type system (types.ts), translation catalog (catalog.ts), and locale picker (languages.ts)Validation
tsc --noEmitpasses with zero errorsContext
This PR supersedes the earlier PR #28070, incorporating the maintainer feedback to rebase against current main.