fix(kanban): only guard open pull requests

[AlexeyZelenin]

Summary

• query GitHub through gh pr view before applying the active-PR respawn guard
• allow merged, closed, or unresolvable PR URLs to respawn work
• cover open, closed/merged, failed lookup, and dispatcher behavior

Tests

• uv run --with pytest --with pytest-xdist python -m pytest tests/hermes_cli/test_kanban_db.py -v --tb=short

[alt-glitch]

This was generated by AI during triage.

Related: the active-PR guard fixes #29458, but this PR also bundles unrelated batch-planning, configuration, workspace-default, dashboard, and documentation changes. Please review the scope as a combined feature set.

[teknium1]

Thanks for addressing the stale-PR respawn case. The premise is verified on current main: hermes_cli/kanban_db.py:7376 currently guards on URL presence alone.

Problems

• hermes_cli/kanban_db.py:7288 uses re.search, so it evaluates only the first PR URL in a comment. A closed URL followed by an open URL makes _is_open_github_pr() return false and allows respawn even though the task still has an open PR. This weakens the storm-prevention purpose introduced by 264e85b3.
• The PR combines the guard fix with batch planning, a new decomposition-budget configuration path, workspace-default behavior, dashboard bundle changes, and docs. The member triage comment also identifies this combined scope.

Suggested changes

• Scan every URL match and guard when any matching PR is open; add the mixed closed-plus-open URL regression case.
• Split the active-PR correction into a focused change before salvaging the independent features.

Automated hermes-sweeper review.

[teknium1]

re.search() examines only the first URL in this comment. If it is closed but a later URL is open, this returns false and permits a duplicate respawn. Iterate all URL matches and guard if any linked PR is open; add that mixed-status case to the regression tests.

[GottZ]

This was generated by AI during triage.

Summary

Nine PRs address or reference the active_pr respawn-guard complex. Their diffs cover PR-state validation, explicit unblock or audited continuation, an operator-clear path, first-spawn false positives, task-owned-link classification, and broad disabling or removal of the URL-derived guard.

Related pull requests

• fix(kanban): check GitHub PR state before applying active_pr respawn guard #29492 [closed] duplicate — (+34/-0) — n/a: Checks the first matched GitHub PR and releases the guard when it is closed or merged, but adds no unblock, operator-clear, or first-spawn path. Although closed, it remains relevant as an early state-check reference implementation superseded in scope by fix(kanban): active_pr respawn guard yields to deliberate follow-ups and dead PRs #72555.
• fix(kanban): narrow active PR respawn guard #35593 related — (+250/-3) — n/a: Requires PR-ownership language in addition to a URL, reducing reference-link false positives, but the contributor keep_open review shows that whole-comment matching can still associate ownership prose with an unrelated URL and requests URL-local correlation, a regression test, and canonical documentation updates.
• kanban: make active_pr respawn guard opt-in (default off) #42003 [closed] partial — (+61/-13) — n/a: Disables active_pr by default through HERMES_KANBAN_RESPAWN_GUARD_ACTIVE_PR, avoiding the wedge while also removing default duplicate-PR protection. Although closed, it remains relevant as a rejected configuration design; the automated close verdict cites the repository policy requiring config.yaml rather than a new HERMES_* behavioral setting.
• fix(kanban): let PR feedback unblock respawn guard #46204 best fix — (+113/-4) — n/a: Uses the latest unblocked event as an inclusive cutoff, allowing deliberate open-PR rework while conservatively guarding same-second and later PR comments. Its high-salvage keep_open verdict supports rebasing only this active-PR block while preserving the recent_success requeue behavior from 77db9d6.
• fix(kanban): stop guarding respawn on PR comment URLs #61196 [closed] partial — (+25/-41) — n/a: Removes URL-derived active_pr state entirely and updates English and Chinese documentation, eliminating the wedge but also the duplicate-PR safeguard. Although closed, it remains relevant as a tested implementation retained in the author's local fork after being opened upstream by mistake.
• fix(kanban): allow respawn after explicit unblock #62424 partial — (+76/-2) — n/a: Implements the same latest-unblock mechanism as fix(kanban): let PR feedback unblock respawn guard #46204, but its created_at + 1 cutoff can ignore a later PR comment written in the unblock second. Despite the keep_open review on fix(kanban): allow respawn after explicit unblock #62424, that reviewed defect remains in the diff, and contributor triage explicitly identifies it as a later duplicate of fix(kanban): let PR feedback unblock respawn guard #46204.
• fix(kanban): only guard open pull requests #65948 partial — (+532/-19) — n/a: Queries PR state before guarding, but checks only the first URL in each comment, so a closed URL can hide a later open URL, and the PR bundles unrelated planning, configuration, workspace, dashboard, and documentation work. Its contributor keep_open review supports only a focused split that scans every URL and adds mixed closed-plus-open coverage.
• fix(kanban): let an audited resume clear the active_pr respawn guard #71606 best fix — (+293/-6) — n/a: Uses one SQLite snapshot and strict ordering so newer audited unblock, ready-status, or actor-bound manual-promotion events override PR evidence while same-second ambiguity remains guarded. Consistent with its high-salvage keep_open verdict, the remaining documented action is to update the canonical English and Chinese respawn-guard documentation.
• fix(kanban): active_pr respawn guard yields to deliberate follow-ups and dead PRs #72555 best fix — (+1045/-14) — n/a: Combines a rowid-bound unguard path, strict post-PR unblock handling, supported state,mergedAt lookup, fail-closed unknown-state behavior, and a run-history check that releases never-run tasks. Despite its keep_open review, the current diff addresses both cited blockers with real-field validation and conservative same-second handling; contributor re-review is still needed for the corrected head.

Duplicates

#62424 is a direct later duplicate of #46204's latest-unblock mechanism. #29492 overlaps the PR-state portions of #65948 and #72555; #42003 and #61196 are broad guard-disabling alternatives, while #71606 and #72555 extend the unblock family with distinct audited-resume, operator-clear, state-check, or first-spawn handling.

Suggested consolidation

Keep #72555 open with a salvage path: obtain contributor re-review of the corrected state,mergedAt and rowid/strict-order implementation, then split the operator-clear, live-state, and first-spawn corrections if a narrower patch is required. Preserve #46204 as the narrow unblock alternative through author action to rebase onto main while retaining 77db9d6, and keep #71606 open for its requested English and Chinese documentation; close #62424 as duplicate of #46204 despite its keep_open review because its diff retains the contributor-identified +1-second defect. For #35593 and #65948, author action should respectively correlate ownership with each URL and split an all-URL state-check patch from unrelated features; leave #29492, #42003, and #61196 closed as reference or rejected alternatives.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I29458(["issue #29458 (open)"])
    subgraph Dup29492 ["PRs duplicating each other"]
        P29492["PR #29492 (closed)"]
        P65948["PR #65948 (open)"]
    end
    P65948 -.->|partial| I29458
    class I29458 open
    class P29492 closed
    class P65948 open
    class P65948 target
    click I29458 "https://github.com/NousResearch/hermes-agent/issues/29458"
    click P29492 "https://github.com/NousResearch/hermes-agent/pull/29492"
    click P65948 "https://github.com/NousResearch/hermes-agent/pull/65948"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 9 pull requests and 2 issues in this complex. Each diff was read against this issue; Assessment working set: 162 kB of PR diffs, 34 kB of issue/PR text, 27 kB of discussion (24 comments), 23 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.