Skip to content

fix(kanban): stop guarding respawn on PR comment URLs - #61196

Closed
nlachica wants to merge 2 commits into
NousResearch:mainfrom
Ahlnos-Inc:docs/t_c16223f1-respawn-guard
Closed

fix(kanban): stop guarding respawn on PR comment URLs#61196
nlachica wants to merge 2 commits into
NousResearch:mainfrom
Ahlnos-Inc:docs/t_c16223f1-respawn-guard

Conversation

@nlachica

@nlachica nlachica commented Jul 9, 2026

Copy link
Copy Markdown

Summary

  • Stop treating GitHub PR comment URLs in task/comment text as respawn guard liveness
  • Keep respawn guard reasons limited to blocker auth, rate-limit cooldown, and recent success state
  • Update Kanban docs in English and zh-Hans to match current guard reasons

Verification

  • Verifier t_0e0387b5 PASS on commit 570aff683dcb689b704caffebfae950135a3a0c7
  • Reviewer t_342a14fa approved docs remediation at d2037df0cd26e4ac5da14d4da342bc07ad918ba6
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py -k 'respawn_guard' (17 passed per reviewer/verifier handoffs)
  • ./venv/bin/pytest tests/hermes_cli/test_kanban_db.py (223 passed per verifier handoff)

Release gate notes

  • Local branch: docs/t_c16223f1-respawn-guard
  • Head SHA: d2037df0cd26e4ac5da14d4da342bc07ad918ba6
  • Code change SHA verified: 570aff683dcb689b704caffebfae950135a3a0c7
  • Do not merge until GitHub CI is green on this PR.

@nlachica
nlachica requested a review from a team July 9, 2026 00:34
@nlachica
nlachica force-pushed the docs/t_c16223f1-respawn-guard branch from d2037df to 1eb03ea Compare July 9, 2026 00:46
@nlachica

nlachica commented Jul 9, 2026

Copy link
Copy Markdown
Author

Rebased the PR head onto current upstream/main (56a8e81d33a524f0ba0d68b6d54c8786ed283fb8) and pushed Ahlnos-Inc:docs/t_c16223f1-respawn-guard to 1eb03ea8da6443f13bbea08b7b8dc0c731e5f82b.

Conflict resolution: kept the approved PR-comment-URL behavior (PR URLs in task/comment prose are diagnostic only), preserved workspace_collisions, and updated the DispatchResult.respawn_guarded docstring to list blocker_auth, rate_limit_cooldown, and recent_success only.

Verification run locally:

  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py -k 'respawn_guard' — 17 passed
  • scripts/run_tests.sh tests/hermes_cli/test_kanban_db.py — 223 passed
  • gh pr view 61196 --repo NousResearch/hermes-agent --json headRefOid,mergeStateStatus,mergeable,statusCheckRollup — head 1eb03ea8da6443f13bbea08b7b8dc0c731e5f82b, mergeable MERGEABLE, merge state BLOCKED, checks reported: 0

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cron Cron scheduler and job management labels Jul 9, 2026
@nlachica

nlachica commented Jul 9, 2026

Copy link
Copy Markdown
Author

Closing: this was opened upstream by mistake during local Hermes/Ahlnos fork release handling. We are keeping this fix in the Ahlnos/local Hermes fork instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants