kanban: make active_pr respawn guard opt-in (default off) - #42003
Closed
sergeikabuldzhanov wants to merge 1 commit into
Closed
kanban: make active_pr respawn guard opt-in (default off)#42003sergeikabuldzhanov wants to merge 1 commit into
sergeikabuldzhanov wants to merge 1 commit into
Conversation
Every PR in this deployment is human-reviewed and human-merged, so re-spawning a task that already produced a PR cannot silently land a duplicate/merged PR — the guard only created friction (tasks stuck 'ready' with no --force flag in this version). Gate it behind HERMES_KANBAN_RESPAWN_GUARD_ACTIVE_PR=1 (default off). blocker_auth and recent_success guards are unchanged. Tests updated to cover both default-off and explicitly-enabled behavior. (cherry picked from commit b93fcc3e10bfd673cfa509d917fb927b9b84dfc7)
Contributor
|
Thanks for isolating the This automated hermes-sweeper review is closing this under the standing configuration policy:
If maintainers want this behavior configurable, please re-scope it to a documented Closed as not-planned per standing maintainer policy ( |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
active_prrespawn guard defers re-dispatch of any ready task whose recent comments contain a GitHub PR URL (check_respawn_guard,kanban_db.py). It assumes a worker already opened a PR and re-spawning risks a duplicate.In a human-reviewed / human-merged workflow this is pure friction: a re-spawn can never silently land a duplicate or merged PR, yet a task that has produced a PR gets stuck in
readyindefinitely (no--forcedispatch flag exists in this version to override it). The other two guard reasons (blocker_auth,recent_success) remain useful and are unchanged.Change
Gate only the
active_prbranch behindHERMES_KANBAN_RESPAWN_GUARD_ACTIVE_PR(default off; set1/trueto restore the legacy behavior).blocker_auth,recent_success, andrate_limit_cooldownare untouched.Tests
tests/hermes_cli/test_kanban_db.pyupdated to cover both states:test_respawn_guard_active_pr_disabled_by_default— PR-URL comment does NOT defer by defaulttest_respawn_guard_active_pr_in_comment_when_enabled— opt-in flag restores deferraltest_dispatch_active_pr_spawns_by_default—dispatch_oncespawns a PR-commented task by defaultmonkeypatchAll 19 respawn-guard tests pass:
Backwards-compatible: anyone relying on the old behavior sets
HERMES_KANBAN_RESPAWN_GUARD_ACTIVE_PR=1.