test(line): regression coverage for typed media-cache routing

[jethac]

Summary

Scope change (2026-07-29): upstream 73e193c03 independently shipped a superset of this PR's original adapter fix (typed media-cache dispatch, fileName threading, (path, media_type) tuple returns), so the code changes here were dropped in the rebase. What remains — and what this PR now contributes — is the regression test coverage upstream doesn't have:

• TestDownloadMediaRouting: locks in typed media-cache routing for the LINE adapter — text/image/audio/video messages map to their correct MessageType enums and cached media resolves through the keyword-only filename= / (path, media_type) tuple signatures, with MIME-typed media_types.
• Guards the exact crash class the original fix addressed (AttributeError: IMAGE on non-text messages), so it can't regress silently.
• Plus the AUTHOR_MAP release-map line.

Original motivation (fixed upstream, now covered by these tests): the adapter crashed on any non-text message and mis-cached media by treating all downloads as untyped blobs.

Test evidence

tests/gateway/test_line_plugin.py + contributor-map suite: 113 passed on current main (f75b577b9).

[alt-glitch]

Duplicate of #34233 (and #27142). Same LINE adapter bug: MessageType.IMAGE doesn't exist (should be PHOTO), and media cache routing treats all media as images. #34233 has the same fix with proper type mapping and cache_media_from_bytes generalization.

[jethac]

@alt-glitch Thanks for flagging this as a duplicate! I’ve reviewed the previous attempts (#34233, #27142).

My implementation builds on those by explicitly ensuring backward compatibility—preserving the legacy image-cache aliases so we don't break the rest of the gateway or existing tests. It also enforces filesystem strictness by segregating generic media from images, which I found was required to pass the current e2e test suite.

Would love your feedback on whether this path is consistent with the current architectural direction.

[tonydwb]

Code Review Summary

Verdict: Approved ✅

🔍 What this does

Two fixes in the LINE platform adapter:

1. Message type mapping: Replaces the binary MessageType.IMAGE if msg_type == "text" else MessageType.IMAGE bug (which crashed on voice/video/image) with a proper dict-based mapping (text→TEXT, image→PHOTO, audio→VOICE, video→VIDEO).
2. Media caching: Introduces cache_media_from_bytes() / cache_media_from_url() as generalized media-caching utilities, refactoring cache_image_from_bytes() / cache_image_from_url() to delegate to them. LINE adapter now uses cache_media_from_bytes() for non-image media.

✅ Looks Good

• Correctness of type mapping: The dict-based approach is clean and handles all LINE message types. Falls back to MessageType.TEXT for unknown types — safe default.
• Refactoring quality: The generalization from cache_image_from_bytes → cache_media_from_bytes is well-structured. Backward compat aliases preserve all existing callers. The is_image flag differentiates cache/images vs cache/media subdirectories.
• Edge cases: The cache_image_from_bytes still validates image data via _looks_like_image() before delegating, preserving existing safety checks.
• LINE adapter: Proper use of cache_media_from_bytes(data, ext=ext, is_image=(msg_type == "image")) correctly routes image vs audio/video to the right cache dir.

💡 Suggestion (non-blocking)

Consider moving the inner import uuid and from hermes_constants imports in cache_media_from_bytes to module-level imports for readability. The current inline imports avoid circular deps but add cognitive overhead.

---

Reviewed by Hermes Agent (cron)

[jethac]

Rebased this PR onto current main and resolved the media-cache conflict.

Additional cleanup in this update:

• Preserved strict image sniffing/validation for cache_image_from_url / cache_image_from_bytes.
• Kept generic cache_media_from_url for non-image media payloads.
• Added regression coverage for image URL validation vs generic media URL caching.

Local verification:

uv run --with pytest --with aiohttp python -m pytest \
  tests/gateway/test_media_download_retry.py \
  tests/gateway/test_line_plugin.py \
  -q -o 'addopts='
# 115 passed

[jethac]

Quick follow-up on the attribution change: CI flagged jethachan@gmail.com as an unmapped contributor email. I also noticed this stack still had older commits authored as jetha@google.com, which was already mapped.

Since I’m leaving Google and want future attribution tied to my personal account, I rewrote this PR stack to use Jetha Chan <jethachan@gmail.com>, removed the old jetha@google.com AUTHOR_MAP entry, and kept the new jethachan@gmail.com -> jethac mapping.

No runtime code changed from that attribution-only rewrite; targeted tests were re-run after the rebase. The three PRs remain stacked locally: #35785 base, #40931 on top, #40933 on top.

[teknium1]

Thanks for preserving image validation while addressing a real LINE media path issue. Current main already contains the MessageType mapping fix from 7309f3bef (plugins/platforms/line/adapter.py:141-149); the remaining defect is that _download_media() still sends audio, video, and files through cache_image_from_bytes() at plugins/platforms/line/adapter.py:1070.

Problems

• The new cache_media_from_bytes / cache_media_from_url API duplicates existing cache infrastructure: typed helpers at gateway/platforms/base.py:826, :933, and :1553, plus the existing classifier/router cache_media_bytes() at :1651.
• The added tests cover the new URL helper, but the LINE production path calls the bytes helper. tests/gateway/test_line_plugin.py:650-676 currently tests only type mapping and does not cover _download_media().

Suggested changes

• Re-scope the salvage to route LINE payloads through the existing typed helpers (or cache_media_bytes()), retaining the established cache directories and validation behavior.
• Add mocked LINE download regressions for audio, video, and file messages.

Automated hermes-sweeper review.

[teknium1]

gateway/platforms/base.py already provides cache_audio_from_bytes (line 826), cache_video_from_bytes (line 933), cache_document_from_bytes (line 1553), and cache_media_bytes (line 1651). Please dispatch this method through those established helpers instead of introducing a parallel generic cache API; that preserves the existing cache contracts and avoids an otherwise-unused generic URL helper.

[jethac]

Done in 05a13e2 — the parallel cache_media_from_bytes/cache_media_from_url API is removed entirely (gateway/platforms/base.py is now byte-identical to main) and _download_media() dispatches directly on the LINE message type: image → cache_image_from_bytes, audio → cache_audio_from_bytes, video → cache_video_from_bytes, file → cache_document_from_bytes (threading LINE's fileName through, falling back to line_file.bin). I went with direct typed dispatch rather than cache_media_bytes() since LINE's content API already fixes the format per type — no classification needed — and it preserves the raw cache-path contract this adapter surfaces. Nine new mocked regressions in tests/gateway/test_line_plugin.py now cover the production path per type plus fetch/cache failure modes.

[jethac]

Thanks for the review — re-scoped exactly as suggested; specifics are in the inline reply. Rebased onto current main, so the MessageType-mapping half (already absorbed via 7309f3b) has dropped out of the diff; what remains is the real defect fix — audio/video/file payloads no longer round-trip through cache_image_from_bytes()'s image validation. One coordination note: the author-map line here also appears in #63560; whichever merges first, the other rebases trivially. CI is green and GitHub reports the PR mergeable.