Skip to content

perf(desktop): make session resume incremental - #62799

Closed
embwl0x wants to merge 4 commits into
NousResearch:mainfrom
embwl0x:agent/incremental-session-resume
Closed

perf(desktop): make session resume incremental#62799
embwl0x wants to merge 4 commits into
NousResearch:mainfrom
embwl0x:agent/incremental-session-resume

Conversation

@embwl0x

@embwl0x embwl0x commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes Desktop cold resume bounded and observable without changing the response contract for existing TUI or third-party clients.

Desktop opts into defer_history: true. The gateway immediately claims or reuses one live runtime and returns its descriptor, then loads replay/display history and starts agent/provider initialization on background threads. session.resume_progress events report history loading, completion, or failure. An early prompt waits off the RPC thread for the same per-session history event, so it cannot build an agent against an empty transcript.

Desktop now reads the existing REST transcript endpoint in 500-message pages and paints each accumulated page as it arrives. Backends that do not return pagination metadata remain compatible and are treated as a one-shot response.

Related Issue

Fixes #62456

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (opt-in incremental resume protocol)
  • ✅ Tests (adding or improving test coverage)

Changes Made

  • Add opt-in deferred history hydration to tui_gateway/server.py; legacy resume calls keep the existing synchronous full-history payload.
  • Reuse the same provisional runtime for concurrent/repeated resumes.
  • Gate agent construction on history readiness and recheck runtime ownership before building.
  • Make hydration failure release only the provisional claim, preserving the durable session for retry.
  • Make session.close cancel a waiting resume/build immediately.
  • Emit session.resume_progress events for loading, completion, and failure.
  • Page Desktop transcript prefetch at 500 messages while retaining older-backend fallback behavior.

How to Test

  1. Resume a large Desktop session. The initial session.resume response returns with hydrating: true and no full transcript payload; Desktop paints REST pages incrementally.
  2. Repeat resume while history is blocked. Both calls return the same runtime id and only one history load runs.
  3. Close during hydration. The wait is cancelled and no agent is constructed. Force a history-read failure and retry; the retry receives a fresh runtime and succeeds.
  4. Run:
    • uv run --extra dev pytest -q tests/test_tui_gateway_server.py tests/gateway/test_async_session_store.py (324 passed)
    • npm run test:ui -- --run src/app/session/hooks/use-session-actions.test.tsx src/app/session/hooks/use-prompt-actions/index.test.tsx src/app/session/hooks/use-message-stream/todo-cleanup.test.tsx (61 passed)
    • npm run typecheck (passed)
    • npm run build (passed)
    • uv run ruff check tui_gateway/server.py tests/test_tui_gateway_server.py (passed)
    • uv run python scripts/check-windows-footguns.py on staged files (passed)

Overlap Audit

Open PRs mentioning session.resume were inspected before work and again before publishing. #62187 covers TUI redraw, #51529 dashboard terminal remount, #43050 usage restoration, #39167 stale-id lookup, and #60394 confirmation sanitization. None implements deferred history hydration, paged Desktop transcript reads, cancellation, or idempotent provisional resume claims.

Checklist

Code

  • I've read the Contributing Guide
  • My commit message follows Conventional Commits
  • I searched for existing PRs and manually inspected keyword overlaps
  • My PR contains only changes related to this feature
  • I've run pytest tests/ -q and all tests pass (targeted/adjacent suites above: 324 passed)
  • I've added tests for acknowledgement, paging, retries, cancellation, and repeated resume
  • I've tested on macOS, Apple Silicon

Documentation & Housekeeping

  • Documentation update: N/A; protocol fields are documented in code and typed in Desktop
  • cli-config.yaml.example: N/A, no config keys changed
  • CONTRIBUTING.md / AGENTS.md: N/A
  • Cross-platform impact considered; Windows footgun scan passed
  • Tool descriptions/schemas: N/A

Screenshots / Logs

No visual layout change. Desktop production build completed successfully.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels Jul 11, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused resume-path work. The premise is verified on current main: tui_gateway/server.py:5705-5708 performs both replay-history reads before the cold-resume RPC returns, while hermes_cli/web_server.py:9633-9657 already provides the bounded paginated transcript transport this Desktop path uses. The PR keeps the new behavior opt-in via defer_history, preserves the legacy synchronous response for other clients, and adds coverage for reuse, hydration failure/retry, cancellation, and Desktop pagination.

Automated hermes-sweeper review.

@teknium1 teknium1 added sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 11, 2026
@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from b8a0bc7 to 8bc2cd9 Compare July 12, 2026 09:09
@embwl0x

embwl0x commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed this branch onto current main after the upstream history rewrite and resolved the adjacent Desktop workspace-target change while preserving both behaviors. New head: 8bc2cd94641f325fa85b2a0b83cf8480dd85a39e.

Revalidated on the refreshed head:

  • uv run --extra dev pytest -q tests/test_tui_gateway_server.py tests/gateway/test_async_session_store.py — 324 passed
  • focused Desktop session hook suites — 64 passed
  • npm run typecheck
  • npm run build
  • uv run ruff check tui_gateway/server.py tests/test_tui_gateway_server.py
  • Windows footgun diff scan, git diff --check, publish gate, and pushed-range gitleaks — clean

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch 2 times, most recently from 3638159 to 2fab3b0 Compare July 19, 2026 01:46
@embwl0x

embwl0x commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the new base-branch conflict and refreshed the branch while preserving the current Desktop reconnect/in-flight reconciliation behavior and the gateway's latest resume teardown locking. New head: 2fab3b04c0412e791feb8d98ec0a38994f299f55.

Revalidated on the refreshed head:

  • canonical gateway/session suites — 395 passed
  • focused Desktop session suites — 79 passed
  • aggregate Desktop suite — 1,977 passed, 2 skipped
  • Desktop typecheck and production build
  • Ruff, Windows footgun scan, git diff --check, publish gate, and gitleaks — clean
  • GitHub CI run 29669110093 — all required checks pass

main advanced again after CI started; a fresh merge-tree check against 7235592ad2bd637e508088c47f8794fa0d2e6f69 is clean, and GitHub reports the PR mergeable.

@teknium1 teknium1 added the area/sessions Session lifecycle, resume, persistence, history label Jul 19, 2026
@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from 2fab3b0 to 8e420a4 Compare July 22, 2026 03:54
@embwl0x

embwl0x commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest base-branch conflict and refreshed the branch onto current main. New head: 8e420a43c3703870fc3fd08d35bfd3dea9b9442e.

The only textual conflict was adjacent test insertion. I preserved both test blocks and also composed the deferred hydrator with current main’s SessionDB.get_resume_conversations() / get_ancestor_display_prefix() boundary so candidate-inclusive display history and the one-lineage-read contract remain intact.

Revalidated on the refreshed head:

  • canonical gateway/session suites — 402 passed
  • focused Desktop resume/API suites — 103 passed
  • aggregate Desktop suite — 2,509 passed, 3 skipped
  • Desktop typecheck, production build, and ESLint (no errors; existing warnings only)
  • Ruff, Windows footgun diff scan, Prettier, git diff --check, publish gate, and pushed-range gitleaks — clean
  • GitHub CI run 29889636628 — all required checks and both Docker architectures pass

GitHub reports MERGEABLE / CLEAN against d8bf3df255beccef4b55b85996884525e2ec28e3.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from 8e420a4 to 9dd8eb3 Compare July 23, 2026 02:49
@embwl0x

embwl0x commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Conflict resolution receipt (2026-07-23): rebased the feature onto current main at d63a1c4ccb1c06f3d5ed187136f36b6df3858fcd and lease-safely updated the PR to 9dd8eb3b2beb562c2e00bb912a30ee732622a462. The resolution preserves current-main duplicate-inflight reconciliation while retaining paginated REST hydration and deferred session.resume history. Local verification passed: 416 gateway tests, 2,632 Desktop tests, 32 focused session-action tests, all Desktop TypeScript configs, production build, Ruff, Prettier, ESLint (zero errors), publish gate, and gitleaks. CI run 29975397038 reports All required checks pass, including Desktop E2E and all eight Python slices; the optional AMD64 Docker build is still running.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from 9dd8eb3 to 46ad39a Compare July 25, 2026 08:06

embwl0x commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest base-branch conflict by rebasing onto current main at 760112adb6458417da8614d2269e5325f0739ed5. New head: 46ad39abefae78f659a6bcb2f3a29a2d1e23493e.

The sole textual conflict was in SessionResumeResponse; the resolution preserves both current main's crash-recovery auto_continue metadata and this PR's incremental-resume hydrating flag.

Local validation:

  • canonical gateway/session suites: 471 passed
  • focused Desktop resume hook: 37 passed
  • aggregate Desktop suite: 2,923 passed, 3 skipped
  • all Desktop TypeScript configs and production build
  • Ruff, Prettier, ESLint (zero errors), diff check, existing-PR publish gate, and gitleaks

GitHub now reports the PR mergeable. Run 30150529165 has All required checks pass, including all eight Python slices, Desktop E2E, Desktop/JS checks, security scans, and both Docker architectures.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from 46ad39a to 8b86817 Compare July 29, 2026 22:10
@embwl0x

embwl0x commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest base-branch conflict by rebasing onto current main at 1f70ba6bca71caa2c440607b06b74e596969e1b1. New head: 8b86817fd87fe1e8f44c92e03637a77d9088216a.

Upstream had extracted session.resume into tui_gateway/methods_session.py, so this resolution ports the incremental-resume handler changes into that live module instead of resurrecting the removed monolithic handler. Shared hydration/build lifecycle helpers remain in server.py. It also preserves current main behavior for first-prompt session-cap claims and profile-scoped secret handling.

Revalidated on the refreshed head:

  • canonical gateway/session matrix: 599 passed
  • focused Desktop resume/prompt suites: 145 passed
  • aggregate Desktop suite: 3,843 passed, 2 skipped
  • Desktop typecheck, production build, Prettier, and full ESLint with zero errors
  • Ruff, Windows production-path scan, diff check, existing-PR publish gate, and pushed-range gitleaks
  • GitHub CI run 30495185751: all 38 jobs passed, including all eight Python slices, Desktop E2E, JS/TS checks, security scans, and both Docker architectures

GitHub reports MERGEABLE / CLEAN.

@embwl0x

embwl0x commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Conflict resolved on current main (a991dfc25).

  • New head: 395165e1769dfc01efd4e9f063124e05de02e891
  • Composed upstream Desktop omit_messages transcript suppression with this PR's defer_history hydration path.
  • Added a test-only completion wait so deferred agent-build threads cannot leak JSON events across tests.
  • Local proof: 522 Python tests and 145 focused Desktop tests passed; Desktop lint, typecheck, production build, Ruff, Windows-footgun CI scan, publish gate, diff check, and gitleaks passed.
  • Replacement CI run 30855503241 passed completely: all eight Python slices, the full Desktop UI suite, security/lint gates, and both Docker architectures.
  • GitHub reports the PR mergeable; the prior conflict signal is gone.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from 395165e to e2c6046 Compare August 7, 2026 22:59
@embwl0x

embwl0x commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest base-branch conflict by rebasing onto current main at b3aa561faffd64f05436e429a6415d175e534ec9. New head: e2c60465e723a6943a859a6a743dbdae5b38ca6b.

The textual conflict was in the live tui_gateway/methods_session.py resume handler. The resolution preserves incremental Desktop history hydration while composing current main's crash-interrupted auto-continue behavior and profile-scoped SessionDB ownership/teardown invariants. The profile DB is handed to the hydration worker, remains open through the deferred read, and closes on completion or cancellation.

Validation:

  • canonical gateway/session matrix: 550 passed
  • focused Desktop resume hook: 42 passed
  • aggregate Desktop suite: 4,521 passed; three unrelated timeout cases each passed in a fresh isolated rerun (17 tests total)
  • Desktop typecheck, production build, Prettier, and full ESLint (zero errors)
  • Ruff, existing-PR publish gate, diff check, and gitleaks
  • replacement CI run 31225705268: All required checks pass, including all 12 Python slices, the full Desktop UI slice, security/lint gates, and both Docker architectures

GitHub reports MERGEABLE; the conflict signal is gone.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from e2c6046 to d4bfa49 Compare August 8, 2026 10:18
@embwl0x

embwl0x commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest base-branch conflict by rebasing onto current main at 52920747e17dc5e8ab18a41e4084ed28508b4e6c. New head: d4bfa49f06e05e117017ded2d146af5b94952f60.

Upstream now bounds ordinary Desktop transcript reads to the latest 500 messages to prevent oversized sessions from exhausting memory. This resolution preserves that safeguard while retaining the PR's incremental resume behavior: the bounded latest page paints as soon as REST returns, while opt-in gateway history hydration and agent construction continue off the RPC path. Deferred-history retry/cancellation, crash-interrupted auto-continue, and profile-scoped SessionDB ownership/teardown remain intact.

Validation:

  • canonical gateway/session matrix: 535 passed
  • focused Desktop resume/prompt suites: 143 passed
  • aggregate Desktop UI suite: 3,590 passed
  • Desktop typecheck, production build, Prettier, and full ESLint (zero errors)
  • Ruff, Windows-footgun CI scan, existing-PR publish gate, diff check, and gitleaks
  • replacement CI run 31252496371: all 41 executed jobs passed, including all 12 Python slices, full Desktop UI, security/lint gates, and both Docker architectures

GitHub reports MERGEABLE / CLEAN; the conflict signal is gone.

@embwl0x
embwl0x force-pushed the agent/incremental-session-resume branch from d4bfa49 to d21777a Compare August 15, 2026 09:38
@embwl0x

embwl0x commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the latest incremental-resume conflicts on current main in d21777a89.

The resolution keeps current main bounded transcript handling and delayed authoritative paint, while retaining opt-in off-RPC history hydration, idempotent live-runtime reuse, cancellation/retry, crash auto-continue, and profile-scoped database ownership. It also fixes a test-isolation race by preventing the hydration ownership test from launching an unrelated agent-build thread into the following test.

Local proof: 601 gateway/session tests, 165 focused Desktop tests, and all 4,271 aggregate Desktop UI tests passed; typecheck, full lint with zero errors, production build, Ruff, Prettier, diff/security gates, and publish gate passed. Replacement GitHub CI completed with every executed check green, and GitHub reports the PR mergeable.

@Enough1122

Copy link
Copy Markdown
Contributor

AI code review — automated review for reference, author can ignore or act on any point.

perf(desktop): make session resume incremental

The deferred-hydration design is sound: history reads move off the response path, cancellation is handled in _finalize_session, and the DB-ownership handoff to the worker thread is well tested. A few observations:

  1. tui_gateway/server.py (_build, ~line 2285): history_ready.wait(timeout=300.0) hard-codes a 5-minute stall. If the hydration worker dies without setting the event (thread kill, interpreter exit), agent build blocks for five minutes with no feedback. Consider a shorter/configured timeout plus an explicit failure emit, consistent with the gateway's other hard-interrupt bounds.

  2. tui_gateway/methods_session.py (deferred path, ~line 522): the acknowledgement introduces a new status value "resuming" in the session.resume response contract, and message_count is initially the stored count while the hydrated transcript (resume_message_count = len of display history) may differ. Clients that branch on status strings or use message_count to size their own pagination should tolerate the new value and the eventual count change — worth an explicit contract note.

  3. tests/test_tui_gateway_server.py (new deferred-history tests): several threading.Event.wait(timeout=1.0) bounds are below the repo's flake guidance (loose wall-clock bounds >= 2s). On a loaded CI runner these can flake; bumping to >= 2s or using event-based sync would harden them.

@alt-glitch alt-glitch added type/perf Performance improvement or optimization P2 Medium — degraded but workaround exists and removed type/feature New feature or request P3 Low — cosmetic, nice to have sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-caching Sweeper risk: may break/degrade prompt caching or cache-key stability (invariant) labels Aug 15, 2026
teknium1 added a commit that referenced this pull request Aug 16, 2026
Follow-up to the #62799 salvage: Desktop sends both defer_history and
omit_messages on a cold resume. Make explicit in the deferred branch that
defer_history supersedes omit_messages — the single history read happens in
the background hydration worker and the synchronous omit_messages read on
the cold-resume default path is skipped entirely, so the transcript is
never loaded twice for one resume.
@teknium1

Copy link
Copy Markdown
Contributor

Thanks @embwl0x — this work is now merged into main via #87522, which cherry-picked all four of your commits with your authorship preserved.

What landed from your PR: the defer_history: true opt-in on session.resume (immediate descriptor + background history hydration), session.resume_progress events, the agent build gating on history-ready, and the desktop opt-in with its tests. Measured on a real 297MB state.db, the resume RPC critical section dropped from ~33ms to ~0.6ms on a 1,175-message session — O(1) in transcript size now.

One half was dropped as redundant: deferring the agent build, which main had picked up independently via _schedule_agent_build since you authored this. Rather than ask for a rebase across the heavily-restructured methods_session.py, we salvaged directly onto current main — the standard flow here. A small follow-up commit of ours documents defer_history/omit_messages precedence.

Closing this PR since the work is in. Much appreciated!

vashkartik added a commit to vashkartik/hermes-agent that referenced this pull request Aug 17, 2026
* feat(config): wire compression.tail_mode + docs (en/zh)

#87326 shipped the lean-compaction capability on the compressor; this adds
the config.yaml surface (compression.tail_mode: legacy|lean, default
legacy), DEFAULT_CONFIG entry, and docs on both the dev-guide compression
page and the user-guide configuration page, with zh-Hans parity.

* fix(computer-use): zero-rect AX bounds serialize as unknown, not a position

KDE/Qt apps report [0,0,0,0] bounds for elements that are perfectly
clickable by index (live QA: all 50 of kcalc's zero-rect elements,
including every radio button). Serializing that as a plausible rect
invites a model to derive coordinate=[0,0] and click the screen corner.

- _element_to_dict: zero rect -> bounds: null
- _format_elements: '@ bounds-unknown (click by element index)' instead
  of the fake rect in the summary line
- malformed bounds fail open (unchanged serialization)

Live-proven on real kcalc (cua-driver 0.20.0): 50 elements now null, 0
zero-rect leftovers, summary annotated, real rects preserved, and a
null-bounds radio button still clicks fine by index.

* feat(desktop): drag-resizable panes on the Capabilities Skills tab

The Skills tab's three panes are now all drag-resizable:

- List/detail column seam: MasterDetail grows an optional resizeId that
  turns the seam between the rail and the detail pane into a vertical
  drag sash (same visual language as DetailPane's top-edge sash). The
  rail width persists in the shared pane store under that id;
  double-click resets to the default 0.75fr track. Skills and Tools
  tabs share one id so the split stays consistent across tabs.
- Skills Hub section: the embedded hub picker's top edge is now a drag
  sash — pull the hub pane up to grow it (the skills list above
  absorbs the change). Height persists through the same pane store,
  double-click resets, and the cross-origin iframe gets
  pointer-events:none during the gesture so it can't swallow the drag.
  Replaces the old native CSS corner-resize handle.
- The skill editor bottom pane already resized via DetailPane's sash.

MASTER_DETAIL_WIDE_COLS keeps its exported shape (MCP tab reads it) —
the --md-split var falls back to the declared track when unset, so
grids without a sash render exactly as before.

* feat(hooks): pre_tool_call content transformation via `modify` directive

Adds a `modify` response type to pre_tool_call hooks so a hook can
transform tool arguments before the tool executes, instead of repairing
results afterwards via post_tool_call.

- hermes_cli/plugins.py: _dispatch_pre_tool_call_hooks() fires hooks once
  and returns (block_message, modified_args); modify directives
  shallow-merge into an accumulated dict built from the original args.
- agent/shell_hooks.py: _parse_response() accepts both the canonical
  {"action": "modify", "args": {...}} and Claude Code-compatible
  {"decision": "modify", "tool_input": {...}} wire formats.
- model_tools.py, agent/tool_executor.py, agent/agent_runtime_helpers.py:
  dispatch sites migrated; modified args applied before execution.
- Docs + 10 new tests (merge semantics, precedence, block interplay).

Salvaged from PR #28953. Best fix for #18988.

* refactor(hooks): share fail-closed approve logic; update sibling tests

Follow-up to the #28953 salvage:

- Extract _resolve_block_from_details() so resolve_pre_tool_block and
  _dispatch_pre_tool_call_hooks share ONE fail-closed approval-gate
  implementation. This also gives the new dispatcher the observability
  context wrapping around request_tool_approval that the original PR's
  inlined copy lacked.
- Update sibling tests that patched resolve_pre_tool_block at the three
  migrated dispatch sites to patch _dispatch_pre_tool_call_hooks with the
  (block_message, modified_args) tuple contract.

Verified: 448 targeted tests green; E2E with a real shell hook in an
isolated HERMES_HOME rewrote a live write_file call (path + content)
through handle_function_call, with block and negative paths intact.

* chore: contributor mapping for NikolaRHristov

* fix(mcp): handle DCR clients with secrets across all OAuth paths

Some MCP OAuth providers (notably Supabase) return a client_secret from
dynamic client registration but omit token_endpoint_auth_method. The MCP
SDK defaults the missing method to "none", so the token exchange omits
client_secret and the server rejects it (HTTP 422 "Required parameter:
client_secret"), looping the browser consent page.

This resolves the whole class, not just one provider:

- Storage layer (HermesTokenStorage): coerce secret-bearing client info
  with missing/none auth method to client_secret_post on both read and
  write, persisting the corrected shape.
- Both live provider paths (tools/mcp_oauth.py HermesOAuthClientProvider
  and tools/mcp_oauth_manager.py HermesMCPOAuthProvider): coerce
  in-memory client info immediately before token exchange and refresh.
- Accept the full 2xx range on token and refresh responses (Supabase
  returns 201 Created), instead of the SDK's exact-200 check.
- Redact token response bodies from error messages and logs on
  malformed responses.

The Figma-specific request-time default (apply_oauth_provider_defaults)
remains; this generalizes the same bug class for every DCR provider.

Fixes #29680. Supersedes #34274 and #35700 (201-only variants).

* chore: map contributor email for 5Hyeons

* fix(compression): watermark commit — appends flow freely, concurrent tail survives compaction

Redesign of the #75316 class (supersedes the approach in PR #87307).

Root cause family: the compression lock fenced ORDINARY transcript appends
for the whole slow provider-summary call. Turns died as
session_persistence_failed whenever a message overlapped a compression
(#74568, #77386, #75083), stale dead-PID locks blocked writes for the full
TTL, and the busy-wait mitigation (#75264) was an order of magnitude shorter
than real summaries. Separately, the commit archived from a pre-call
snapshot, so rows appended mid-compression were swept into the archive.

Design: the commit transaction is already exclusive — no lock phases needed.

1. Appends never check compression_locks. The lock's only job is stopping
   two compressions colliding; it keeps that job. The whole stale-lock /
   busy-wait symptom family dies as a class.
2. Watermark captured in the DB at compression start
   (get_active_message_watermark = MAX(id) of active rows) — not from
   in-memory message dicts, which carry no row ids in production.
3. archive_and_compact(watermark=, lock_holder=): one transaction verifies
   the holder still owns an unexpired lease (a reclaimed lease cannot
   publish a stale compaction), archives the snapshot, inserts the compacted
   set, and re-sequences the concurrent tail (id > watermark) via a
   pure-SQL column clone — every column except id survives byte-exact
   (api_content, platform_message_id, reasoning sidecars, token counts),
   FTS triggers index the clones naturally, originals stay archived and
   recoverable. watermark=None preserves the historical behavior.

Removed: the append-side compression fence in _check_transcript_write_guards
(with rationale note), making the _COMPRESSION_BUSY_WAIT_S retry lane
unreachable from append paths (kept for other callers).

Tests: 12 new (watermark contract, column-exact clone, commit fence incl.
lease-lost/expired/rollback failure injection, append-vs-commit race);
busy-retry suite flipped to pin the new contract; sabotage-verified (5 fail
with the watermark disabled, 12 pass restored); E2E through the real
compress_context seam with a mid-summary append landing and surviving.

* fix(compression): rotation path clones the concurrent tail into the child

CI caught the sibling site the in-place fix missed: legacy (non-in-place)
compression rotates via publish_compression_child, where a mid-summary
append previously stranded in the closed parent. Same watermark + pure-SQL
column clone as archive_and_compact, with session_id rewritten to the child.
Lineage-guard test flipped to pin the appends-flow-freely contract; rotation
watermark tests added (tail follows the child; None = historical behavior).

* fix(compression): bound the rotation tail clone below the rotator's own flush

CI caught two rotation-path regressions from the unbounded clone: the #47202
pre-publish flush writes the rotator's OWN input transcript to the parent
(above the start-watermark), and the clone was duplicating it into the child
alongside the handoff. publish_compression_child gains watermark_ceiling —
the MAX(id) captured immediately BEFORE that flush — so only rows in
(watermark, ceiling] (genuinely foreign concurrent appends) clone across.
Ceiling capture failure falls back to no tail preservation (historical
behavior) rather than risking duplication. Ceiling-exclusion test added.

* fix(terminal): warn when exit_code 0 masks a piped build/test failure

`cargo build 2>&1 | tail -20` exits with tail's 0 even when the build
failed — bash without pipefail reports the last pipeline command's
status, and `cmd || echo failed` swallows the status the same way. The
model reads exit_code: 0 as a strong success signal and can conclude a
build passed while the visible output says it failed (community report,
Windows Rust builds; not platform-specific).

Two-part fix, mirroring OpenCode's prompt-side approach plus a
result-side backstop they don't have:

- Tool description now forbids piping builds/tests through
  tail/head/cat (output is already auto-truncated + spilled to a file)
  and warns that pipes/|| fallbacks mask exit codes.
- New annotate_masked_success() in tools/terminal_hints.py: when
  exit_code == 0, the command shape can mask an upstream status
  (top-level pipe into a passthrough consumer, or || echo/true), AND
  the output carries strong tool-specific failure shapes (rustc,
  cargo, pytest, gcc, npm, make, ninja), attach an advisory 'hint'
  telling the model to treat the run as failed and re-run bare.
  exit_code itself is never modified. Search/content heads
  (grep/rg/echo/printf/...) are excluded to avoid false positives on
  pipelines whose output legitimately contains error text.

E2E-verified through the real terminal tool path: hint fires on masked
cargo-style failures, silent on bare commands, clean pipes, and
grep/printf pipelines. 42 targeted tests pass.

* fix(desktop): defer credential-warning onboarding to the first chat attempt

Switching to a profile with no provider configured popped the blocking
onboarding overlay (Nous Portal / provider picker, "gateway isn't
ready") the moment the profile's runtime info arrived — punishing the
user for merely looking at an unconfigured bot/profile.

The passive credential_warning (session create/activate/resume info,
stream heartbeats) is now stashed instead of opening the overlay.
The submit path consumes it when the user actually tries to chat and
opens onboarding then, before the doomed send; the draft stays in the
composer. A warning-free session event clears the stash, so healed or
switched-away profiles never fire stale onboarding. Turn-error paths
(a real failed send) still open onboarding immediately, unchanged.

* fmt(js): `npm run fix` on merge (#87505)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(agent): reject masked verification results

* fix(cli): map all Ctrl/Alt/Shift+key combos under modifyOtherKeys level 2

Commit 4c34eeb416 stopped pushing the Kitty keyboard protocol (CSI >1u)
because Ctrl+C arrived as ESC[99;5u instead of \x03, breaking SIGINT.
But modifyOtherKeys level 2 (CSI >4;2m) was kept so Shift+Enter stays
distinguishable from Enter.

Under modifyOtherKeys=2, terminals re-encode EVERY Ctrl+key combo as
ESC[27;5;<codepoint>~ instead of the raw control byte. prompt_toolkit
3.x only maps ESC[27;5;13~ (Ctrl+Enter = Ctrl+M); all other Ctrl+letter
combos are unmapped and leak as literal text or get swallowed — breaking
Ctrl+A, Ctrl+C, Ctrl+D, Ctrl+E, Ctrl+K, Ctrl+R, Ctrl+U, Ctrl+W, Ctrl+Z,
etc. Shift+letter combos (ESC[27;2;<codepoint>~) have the same problem,
causing the 'caps locked sessions' symptom where typed text appears
corrupted or stuck.

Fix: add install_modify_other_keys_aliases() to pt_input_extras.py that
populates prompt_toolkit's ANSI_SEQUENCES dict with 294 mappings covering:
- Ctrl+letter (a-z): ESC[27;5;<code>~ and ESC[<code>;5u -> Keys.ControlA..Z
- Ctrl+digit (0-9): same formats -> Keys.Control0..9
- Ctrl+symbol ([ \ ] ^ _ @ Space): same formats -> matching Keys.Control*
- Alt+letter (a-z, A-Z): both formats -> (Escape, <letter>) tuple
- Shift+letter (a-z, A-Z): both formats -> uppercase character

Uses setdefault semantics — never clobbers existing mappings from
install_shift_enter_alias or install_ctrl_enter_alias. The Ink TUI
(Node.js) already handles this via a regex parser; prompt_toolkit 3.x
uses dict lookup only, so we populate the dict.

Refs #56684, #87711.

* refactor: extract _install_paired helper, fix misleading comment, isolate test fixture

Apply findings from /simplify-code 3-agent review:

1. Extract _install_paired() inner helper — the Ctrl, Alt, and Shift
   sections all repeated the same mok+csiu sequence generation pattern
   (~30 lines of duplication). Now each section builds a dict and
   delegates to _install_paired(modifier, mapping).

2. Replace 10 hardcoded Ctrl+digit lines with a loop matching the
   Ctrl+letter pattern above it.

3. Fix misleading comment: claimed 'Ctrl+0 doesn't produce a control
   byte' but chr(ord('0') & 0x1F) = 0x10 = ControlP. The code was
   correct (maps directly to Keys.Control0..9); only the comment was
   wrong.

4. Add comment explaining why Shift+letter maps both lowercase and
   uppercase codepoints (some terminals send the already-shifted
   codepoint with modifier=2).

5. Test fixture: snapshot/restore ANSI_SEQUENCES in teardown so 294
   mappings don't leak into sibling test files (global mutable state).

* chore: map justin@bowes.org to @justinbowes

Attribution mapping for the PR #84982 salvage. The commit email is not
linked to a public GitHub account, so contributor_audit --strict fails
without it; login confirmed from the PR author field.

* feat(desktop): unify MCP Servers and Catalog into one coherent list

The MCP tab's left column previously split the configured fleet and the
Nous-approved catalog behind a Servers/Catalog tab toggle. Installed
entries appeared in both views and the install button lived a tab flip
away from the list it fed.

Now one scrolling column: configured servers (live status, toggles,
probes) on top, a Catalog section below offering only entries not yet
installed. Installing moves the entry up into the fleet list; the
zero-servers empty state keeps the catalog visible beneath it instead
of hiding it behind a full-page invitation.

Bot Mode's Advanced view embeds this same McpTab via the plugin SDK, so
the unification mirrors there automatically.

- removed leftView state + TextTab toggle; section headers reuse the
  existing tabServers/tabCatalog strings (no i18n changes)
- availableCatalog memo filters installed/name-clashing entries
- catalog memoized to satisfy react-hooks/exhaustive-deps

* perf(desktop): make session resume incremental

* test(tui): wait for deferred profile DB close

* test(desktop): preserve bounded deferred resume

* test(tui): isolate deferred hydration worker

* docs(tui): document defer_history vs omit_messages precedence

Follow-up to the #62799 salvage: Desktop sends both defer_history and
omit_messages on a cold resume. Make explicit in the deferred branch that
defer_history supersedes omit_messages — the single history read happens in
the background hydration worker and the synchronous omit_messages read on
the cold-resume default path is skipped entirely, so the transcript is
never loaded twice for one resume.

* feat(desktop-sdk): host.deleteProfile — teardown-routed profile delete for plugins

Plugins deleting profiles via `cli.exec ['profile','delete',…]` bypass the
Electron-side DELETE /api/profiles interception (prepareProfileDeleteRequest),
so a live pool backend — e.g. one the roster's hover pre-warm just woke —
holds the profile dir open and the renderer's reconnect respawns it
mid-delete, recreating the directory (#52279). Bot Mode's right-click Delete
hits this every time because right-click hovers the row first.

Add host.deleteProfile(name) to the plugin SDK: routes through the same
teardown-routed REST path core's DeleteProfileDialog uses (backend teardown
first, next request routed away), rejects on 'default', and re-homes the app
to the default profile when the deleted profile was the live gateway's —
mirroring the core dialog's ordering.

Reported by @BkashJosi (Bot Mode: deleting a bot errors while its session
is awake).

* fix(gateway): release loop ticks after empty responses

* fix(gateway): isolate post-turn loop failures

* fix(install): capture npm output on failure for diagnosable errors (#87340)

Both install-blocking npm install call sites (browser tools and TUI) ran
with --silent and no output capture, so failures printed only a generic
error message with no npm diagnostics.

Apply the same pattern used by the camofox install path: redirect npm
output to a temp file and replay it on failure, so users can see the
actual error (EBADENGINE, ETARGET, network timeout, registry 5xx, etc.).

Fixes #87340

* fix(install): validate --commit SHA and fail hard on fetch/checkout errors (#87268)

Three problems with install.sh --commit:

1. No validation: non-hex or too-short arguments passed through to git,
   producing misleading errors.

2. Fetch failure swallowed by || true: abbreviated SHAs are refused by
   GitHub's server ("couldn't find remote ref"), but the error was
   silently ignored.

3. Checkout failure not checked: git checkout --detach with a missing
   object produces a misleading "does not take a path argument" error
   and the install continues unpinned, exiting 0.

Fix:
- Validate --commit is a 7-40 hex string up front
- Remove || true from fetch; fail with actionable message directing
  users to full 40-char SHAs
- Check git checkout --detach result and fail hard on error

Fixes #87268

* fix(webhook): authenticate Linear deliveries via linear-signature HMAC (#87348)

* fix: persist computer_use provider selection so Desktop picker survives refresh

The `computer_use` toolset (cua-driver) had no persistence branch in
_write_provider_config or _is_provider_active. When the Desktop GUI
sent PUT /api/tools/toolsets/computer_use/provider, the config write
was a no-op and _is_provider_active always returned False -- so the
"Use this backend" CTA reappeared on every refresh.

Add a computer_use_backend marker to the cua-driver provider entry
and handle it in the same pattern as web_backend / browser_backend:
- _write_provider_config now sets computer_use.backend = "cua"
- _is_provider_active now checks computer_use.backend
- _reconfigure_provider (interactive CLI) also persists the key

Fixes #86962

* fix(runtime): exempt loopback custom-provider pool credentials from the usable-secret floor

Fixes #86864.

Legacy custom_providers configs commonly used short/placeholder
api_keys ('123', 'm') for local no-auth services like Ollama --
harmless for the endpoint itself, since Ollama accepts any key or no
key. A stricter has_usable_secret(value, min_length=4) gate added
later now rejects these, but only the credential-POOL resolution path
lacked the same "no-key-required" exemption every OTHER resolution
path in this file already has for exactly this scenario:

- The config-based custom_providers fallback (non-pool path) already
  ends with `api_key or "no-key-required"`.
- The "actual" provider's local-offline path already injects
  ACTUAL_LOCAL_NOAUTH_PLACEHOLDER before the usable-secret gate for a
  loopback base_url.
- _try_resolve_from_custom_pool() was the one gap: it returned the raw
  short pool credential unchanged, which then failed the downstream
  has_usable_secret() gate with a generic "No usable credentials found
  for custom" error that contradicts setup.status ("configured
  credentials" vs "runtime failed"), sending users hunting in the
  wrong direction.

Fixed by substituting the same "no-key-required" placeholder when the
pool's stored credential fails has_usable_secret() AND the base_url
resolves to a loopback hostname (using the existing _loopback_hostname
helper, matching the exemption scope the issue itself requested:
localhost/127.0.0.1/::1 only, not arbitrary remote endpoints with a
genuinely-too-short key).

Added 4 regression tests extending the existing
test_runtime_provider_resolution.py file, following its established
credential-pool mocking pattern: the exact reported 3-char repro
('123'), a 1-char case, a non-loopback sanity check confirming the
exemption stays scoped (a short key for a remote endpoint is NOT
silently exempted), and a sanity check that a genuinely usable
loopback key passes through unmodified. Verified as a genuine
regression by reverting the fix and confirming 2 tests fail with the
exact raw short key leaking through unchanged.

59/59 pass in the extended test file; 14/14 across two more related
custom-provider test files (no regression).

* fix(cron): do not treat directories as unsafe lifecycle scripts (#86753)

Docker Desktop writes fpath=(~/.docker/completions ...) into .zshrc.
The referenced-script walk then opened that directory, saw a non-regular
file, and fail-closed — blocking source ~/.zshrc on every terminal
command. Directories are not scripts; devices stay fail-closed.

* fix(gateway): read routed profile model config

* fix(batch_runner): propagate fatal and validation errors as non-zero exit codes

Python Fire serializes the return value of a wrapped function but does not
use that value as the process exit code. Error paths in main() that used
 or  therefore caused the process to exit 0, swallowing
fatal errors and argument-validation failures.

Raise SystemExit(1) on every error path so batch_runner returns a non-zero
exit code when it cannot run. Success paths (e.g. --list_distributions) are
left unchanged.

Closes NousResearch/hermes-agent#86524.

* fix(gateway): surface actionable message for local model server connection errors

* fix(gateway): keep broad connection phrases out of the provider-error gate

Fixes #86570

* fix(gateway): catch BaseException in _process_message_background to notify on SystemExit

The fire-and-forget handler only caught asyncio.CancelledError and
Exception, so a SystemExit/KeyboardInterrupt escaping a turn (e.g. a
plugin calling sys.exit() in a tool call or summary-LLM path) skipped
the user-facing failure notification and surfaced only as 'Task
exception was never retrieved' — radio silence for the user.

Catch BaseException instead; send the failure notification first, then
re-raise SystemExit/KeyboardInterrupt to preserve shutdown semantics
for the loop's own signal handling. Other BaseExceptions stay contained.

Closes #86651

* fix(cli): use custom provider default_model when --provider is set

hermes chat --provider <name> without -m sent the global model.default
to the custom endpoint. Named custom entries already expose
default_model via _get_named_custom_provider(); honor that when the
user selected the provider and did not pass an explicit model.

Fixes #86978

* fix(cli): warn when --provider default_model cannot be resolved

A named --provider without -m used to swallow lookup failures and
silently keep the global model.default. Log the resolution error so
the fallback is visible.

* fix(cli): allow persisted contributor tier consent

* fix(mcp): prefer server-native tool over generated utility on name collision (#87112)

An MCP server exposing a native tool named read_resource (or
list_resources/list_prompts/get_prompt) collided with the auto-generated
resource/prompt utility of the same name. The registration collision
handler flagged the pair as ambiguous and skipped BOTH entries, so the
server's own tool became silently unavailable on every gateway boot.

Resolve this specific native-vs-utility collision in favour of the native
tool: keep it and drop the shadowed utility, which is only convenience
sugar for servers that expose no such tool of their own. The conservative
skip-everything path still applies to genuinely ambiguous collisions (two
or more native tools normalizing to one name), which we cannot
disambiguate. Add a regression test covering the native-tool-wins path.

Fixes #87112

* fix(desktop): restore mod-chord keybinds while typing in inputs

#86586 replaced the combo-based input gate (any Cmd/Ctrl chord fires
while typing) with an action allowlist that dropped session.new and
every other mod-chord not explicitly listed. ⌘N/⌘T/⌘⇧N and friends
became dead keys whenever focus was in the composer.

Restore the pre-regression rule: primary-modifier chords stay global
even in text fields; the allowlist now gates only bare/Shift/Alt combos,
so rebound letter keys can never hijack typing. Text-navigation chords
(Ctrl+Arrow/PgUp/PgDn) still stay with the input.

* fix(desktop): reject bare modifier combos in the input gate

Review NIT: a malformed stored binding of just 'mod'/'ctrl' (never
produced by comboFromEvent) could pass the shape-only mod/ctrl check.
Reject bare-modifier bases in actionAllowedInInput and pin it in the
suite.

* fix(agent): preserve local reasoning timeout opt-out

* fix(approval): deterministic approvals.single_query_mode for -q sessions

hermes chat -q sets HERMES_INTERACTIVE=1 (for interactive sudo prompts) but
runs one turn with no user waiting to answer approval prompts. Previously a
dangerous command triggered the interactive gate, waited the full 300s
timeout, then failed closed — and the agent was effectively forced to work
around the block, often silently auto-approving via execute_code (which
auto-approves in non-gateway mode).

Add approvals.single_query_mode (default deny, mirror of cron_mode):
  deny    — block dangerous commands and execute_code deterministically with
            a clear 'no user present' message (no 300s wait)
  approve — auto-approve dangerous commands/execute_code in -q mode

cli.py marks the session with HERMES_SINGLE_QUERY_SESSION; the shared gate
(_run_approval_gate, check_all_command_guards, check_execute_code_guard)
treats -q as a deterministic non-interactive context when that marker is set.
execute_code, the -q escape hatch, now honors single_query_mode instead of
auto-approving headlessly. Includes tirith parity in the combined guard and
docs. Fixes #86878.

* fix(gateway): treat Ready scheduled tasks as Windows supervisors

After the VBS/cmd launcher exits, Task Scheduler marks
Hermes_Gateway_* Ready while the detached gateway keeps running.
The orphan reaper only bailed on Running, then fail-opened the
parent-chain check and killed the live bot on desktop serve start.

Fixes #87001

* fix(gateway): preserve launchd supervisor marker across stderr_timestamp wrapper

launchd only stamps XPC_SERVICE_NAME on its direct child. The timestamp
wrapper is that child, so the grandchild gateway sees XPC_SERVICE_NAME=0
and the supervised-conflict guard refuses the service's own spawn.

Forward HERMES_GATEWAY_EXTERNAL_SUPERVISOR=1 when the wrapper itself is
launchd-supervised. Interactive XPC_SERVICE_NAME=0 starts stay unmarked.

Fixes #86893

* fix(gateway): put --external-supervisor on launchd gateway argv

hermes update decides restart ownership from the live grandchild argv,
not from an env marker. Newly generated plists now include the flag.
The stderr_timestamp wrapper upgrades only historical Hermes gateway
run shapes for stale plists and leaves arbitrary launchd children unmarked.

* fix(agent): preserve stalled-provider escalation

* fix(agent): cover provider wait teardown paths

* fix(sessions): surface open sessions skipped by prune

* fix(sessions): address prune skip review notes

* fix(sessions): align prune filter derivation

* fix(agent+discord): guard truncated-response continuation loops and cap Discord split delivery (#86581)

* fix(agent): bound worker finalization when iteration budget exhausted (#87096)

Adds a bounded fallback path in turn_finalizer.py that always records
a terminal timed_out outcome via _record_task_failure (CAS receipt path)
when the iteration budget is exhausted, regardless of whether the normal
fallback paths (interrupted/failed/anomalous exit_reason) were eligible.

Previously, a kanban worker whose budget was exhausted but whose turn was
interrupted, failed, or exited with an anomalous reason would silently
leave its task in an ambiguous lifecycle state — the dispatcher would
eventually detect it as a crashed or protocol-violation worker, but the
failure was not bounded and could take a full tick cycle to reconcile.

The CAS invariant in _end_run (WHERE ended_at IS NULL) guarantees
idempotence: if another path already closed the run, the call is a no-op.

Extracted the inline kanban-budget-exhausted recording into a shared
helper function (_record_kanban_budget_exhausted) used by both the
existing iteration_limit_fallback path and the new bounded fallback path.

Closes #87096

* fix: guard exit watchdog against mid-cleanup overlap

* fix(desktop): hard-exit a lock-losing second instance before ready

app.quit() does not stop a lock-losing instance from reaching whenReady:
the before-quit teardown coordinator defers the quit (event.preventDefault
+ async backend shutdown), and ready fires in that window. The losing
instance then runs the full startup whose reapOrphans() SIGTERMs the
running instance's live backend (#87295).

The lock-loser holds no state and no backend — requestSingleInstanceLock()
has already delivered the argv to the primary by the time it returns false —
so there is nothing to clean up. app.exit(0) terminates immediately, before
ready, so a second launch routes into the running window and never touches
backend machinery.

* fix(desktop): keep startHermes inert without the single-instance lock

startHermes() is the only entry point that can reap, spawn, claim, and
therefore destroy a backend. Belt-and-suspenders on the exact killing line:
even if some future path reaches it in a lock-losing process (a refactor, a
dev harness, a race), the instance stays inert — no reap, no spawn, no
claim — instead of SIGTERMing the running instance's backend (#87295).

* fix(desktop): never reap a backend whose parent Electron is alive

reapOrphans() treats any recorded backend with a matching process identity
as orphan-reapable — including a backend owned by another live instance. The
ownership file is shared across instances, so a second launch that reaches
reap (even without the lock) SIGTERMs the running instance's backend.

Claims now record the spawning Electron (parentPid + parentStartMarker, the
same values already passed to the backend as HERMES_PARENT_PID /
HERMES_PARENT_START_MARKER), and reapOrphans() skips any entry whose parent
is still running. Even a second instance that wins a stale lock can never
kill a live instance's backend. Legacy entries without parent data keep the
old behaviour.

Known tradeoff: a parent-liveness probe failure preserves the record, so a
genuinely orphaned backend under a still-running parent is leaked until it
dies naturally. That is preferable to killing a live instance's backend.

Tests: parent-aware reap in backend-ownership.test.ts (live parent
preserved, dead parent still reaped, probe failure preserved, parent
identity round-trips through claim/parse).

* fix(agent): include timezone and UTC offset in system prompt timestamp

The "Conversation started:" line carried a bare date (%A, %B %d, %Y). Tools
that accept instants -- nutrition, calendar and similar MCP servers -- reject
naive datetimes and require an explicit UTC offset, so the model had to infer
EST vs EDT from the date alone. Near a DST boundary that is a coin flip, and a
wrong guess does not error: it silently writes the record onto the wrong day.

Append the IANA zone (when configured), the zone abbreviation and the UTC
offset, e.g.:

  Conversation started: Saturday, August 15, 2026 (America/New_York, EDT, UTC-04:00)

get_timezone() returns None when no timezone is configured; in that case the
line falls back to the abbreviation and offset of the server-local (still
tz-aware) time, so behaviour is unchanged for users who never set one:

  Conversation started: Saturday, August 15, 2026 (EDT, UTC-04:00)

Daily byte-stability is preserved -- the property the date-only format exists
to protect (PR #20451). Zone name, abbreviation and offset are all constant for
the whole day; they shift only at a DST transition, where a change is correct.
The static-prefix reconstruction guard in _restore_plugin_sections matches on
"\n\nConversation started:" and is unaffected by a suffix after the date.

test_datetime_is_date_only_not_minute_precision used `re.search(r":\d{2}")`
over the whole line as a proxy for "no time-of-day". A UTC offset also matches
that pattern, so the check now applies to the date portion (everything before
the zone parenthetical) and the invariant is tightened rather than relaxed:

- test_datetime_includes_utc_offset asserts the offset is present
- test_datetime_line_is_stable_across_rebuilds asserts two rebuilds in the
  same day produce a byte-identical line

Fixes #87403

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(gateway): make managed Node suppress PATH fallback

* fix(agent): canonicalize duplicate tool call arguments

* fix(agent): harden canonical tool call deduplication

* fix(gateway): let an explicit workspace move win for a running session

session.workspace.move refused a running live session with 4009
(session busy), but the desktop's Move-to-project flow calls exactly
this RPC — so the UI updated its local grouping while state.db kept the
old cwd and the agent's tools kept running in the old workspace. Two
sources of truth disagreed (#86626).

An explicit move now wins: the stored row and the live session re-anchor
together. In-flight tool calls keep the cwd they were launched with; the
next tool call uses the new workspace.

* fix(ui): ignore inherited esbuild binary overrides

* fix(ui): scrub esbuild override during builds

* fix(codex): clamp xAI max/ultra aliases to the model's reasoning ceiling (#87279)

* fix(backup): bound locked database snapshot waits

* fix(gemini): raise maxOutputTokens when thinking is enabled

Gemini bills thought tokens against maxOutputTokens/max_tokens, so a
global 4096 cap can be fully consumed by thinking on the first
request, leaving zero content tokens and aborting after 4
continuations. When thinking is enabled, raise the effective output
cap to the 65,535 ceiling on both the native and chat-completions
paths.

Refs #83915

* fix(gateway): don't crash on a foreign XDG_RUNTIME_DIR in user-systemd preflight (#86558)

runuser/su/sudo -u from a root shell leaks XDG_RUNTIME_DIR=/run/user/0 into
the child. _user_systemd_socket_ready() stat-ed sockets under it with a bare
Path.exists(), which only suppresses ENOENT/ENOTDIR/EBADF/ELOOP — EACCES on
the 0700 root-owned dir escaped as a raw PermissionError traceback instead of
the documented UserSystemdUnavailableError remediation path.

- _path_exists_safe(): Path.exists() that treats EACCES as absent; used at
  both the readiness and DBUS-detection call sites.
- _ensure_user_systemd_env(): drop an XDG_RUNTIME_DIR that is unset or owned
  by another user in favour of our own /run/user/{uid}, so the restart
  actually succeeds after su/sudo -u instead of only failing cleanly.

Regression tests cover the EACCES readiness probe, foreign-dir replacement,
and that preflight raises UserSystemdUnavailableError (not PermissionError).

* fix(agent): do not let hygiene idle timeouts block in-agent compression

Session hygiene persists compression_failure_cooldown_until after a
30s no-progress watchdog so the pre-agent pass can skip. The
in-conversation compressor read the same column and then refused to
run even though its own budget is sufficient.

Ignore hygiene idle-timeout errors on the in-agent path. Real
aux-model faults such as rate limits still block.

Fixes #86972

* fix(agent): clear in-memory cooldown when hygiene overwrites the shared row

A later hygiene idle-timeout write can replace an aux-model cooldown on
the shared column. Drop the in-memory timer on that refresh so the
in-agent compressor is not still blocked after the DB row is hygiene.

* fix(gateway): persist hygiene failure cooldown rung

* fix(gateway): offload hygiene streak persistence

* fix(skills): resolve skills dir before relative_to so junction installs work (#86971)

* fix(telegram): honor group_allowed_chats in early auth under multiplex profiles (#87132)

With gateway.multiplex_profiles enabled, the primary Telegram message
handler is the closure returned by _make_default_profile_message_handler(),
so its __self__ is absent. The early intake filter
(_is_user_authorized_from_message) recovered the GatewayRunner via
self._message_handler.__self__ and, finding none, fell back to env-only
authorization — never evaluating the configured chat allowlist through
GatewayRunner._is_user_authorized(). Every non-global sender was then
default-denied in an explicitly allowlisted group.

Prefer the platform-bound authorization callback registered via
set_authorization_check(): it routes through the runner's full auth chain
(platform + group allowlists, pairing store, allow-all) and survives the
closure wrapping, whereas the bound-handler lookup does not. The bound
handler remains the fallback for setups without a registered callback, and
the pairing-passthrough guard for unknown DMs is preserved.

Fixes #87132

* fix(desktop): close safe preview blockers before update

* fix(desktop): identify unsafe update blockers

* fix(gateway): keep persisted model routes consistent

* fix(desktop): don't cancel the running turn on Esc while an overlay is open

The composer's global Esc-to-cancel listener (useComposerEscCancel) fires
whenever the turn is busy and the active composer matches — but overlays
(Settings, Command Center, agents, cron, …) cover the chat while the
composer stays mounted and 'active' beneath them, so pressing Esc on any
of those pages interrupted the session the user wasn't even looking at.
OverlayView's own escape-layer Esc-to-close fired too, but the stream was
already dead.

Stand Esc down with composerFocusBlockedBySurface() — the same signal the
type-to-focus path uses (BLOCKING_OVERLAY includes OverlayView's
[data-overlay-surface] marker). Esc on an overlay now closes the overlay
via its escape layer instead of canceling the stream beneath it.

Fixes #82618

* fix(caching): engage prompt caching for LiteLLM Claude on the OpenAI wire

anthropic_prompt_cache_policy() only granted Anthropic cache_control
markers to LiteLLM over the native Anthropic wire
(api_mode == "anthropic_messages"). A LiteLLM deployment exposing the
OpenAI-compatible surface instead (/v1/chat/completions, /v1/messages
-> 404) matched no grant branch and fell through to (False, False): no
cache_control injected, the system prompt sent as a plain string, and
the provider serving zero cache hits -- the entire prompt re-billed at
full price on every turn. Silent: no error, no warning, usage simply
shows 100% uncached input forever.

Add one branch after the is_anthropic_wire/is_claude case that grants
caching to Claude-family models on a LiteLLM endpoint regardless of
wire, with the native inner-block layout. Same failure class already
documented in-function for Qwen/DashScope.

Design:
- Gated on the Claude family only (is_claude); a Gemini/GPT/Qwen route
  through the same proxy must not receive markers (they may reject the
  cache_control block format -- cf. the DeepSeek/OpenCode exclusion).
- Matches on provider string OR base_url host, since provider naming
  varies per install (litellm, custom:litellm, or a bare custom alias
  pointed at a LiteLLM host).
- prompt_caching.cache_ttl: false still wins (the _cache_disabled early
  return is untouched).
- Generic strict OpenAI-wire custom providers (e.g. Fireworks) remain
  excluded -- verified by the existing over-reach regression test.

Tests: adds TestLiteLLMOpenAIWire covering the grant (several model
spellings x provider/host signals), no-over-reach (non-Claude on the
same proxy get nothing; operator disable wins), and adjacent behavior
(LiteLLM in Anthropic proxy mode still native layout). Full module:
43 passed.

Closes #84506. Original diagnosis, patch design, and measurements by
@ottosulin.

* fix(caching): use the envelope layout for LiteLLM Claude on the OpenAI wire

Follow-up to the salvaged LiteLLM cache grant. The grant itself is right;
four things about how it was scoped were not.

1. Layout. The branch returned the native inner-block layout
   (use_native_layout=True) on api_mode == "chat_completions". That layout
   writes a TOP-LEVEL msg["cache_control"] on role:tool and empty-content
   messages and depends on the Anthropic adapter to relocate it into the
   block — but that adapter only runs for api_mode == "anthropic_messages"
   (agent/transports/anthropic.py registers there), and the
   chat_completions transport does no relocation. Measured on a 3-tool-turn
   transcript: 2 of the 4 available breakpoints landed on markers the
   provider never sees. Worse, when LiteLLM itself relocates a top-level
   marker for an OpenRouter-backed Claude route
   (OpenrouterConfig._move_cache_control_to_content), the marker lands on
   an empty assistant turn and produces a cache_control-marked empty text
   block — the HTTP 400 "text content blocks must contain" shape already
   guarded in agent/anthropic_adapter.py (#69512). Switched to the envelope
   layout, matching every other OpenAI-wire grant in this function:
   4 of 4 breakpoints honored, zero empty blocks.

2. Host matching. `"litellm" in base_url_hostname(...)` is the substring
   false-positive class base_url_hostname's own docstring warns against; it
   granted Anthropic markers to notlitellm.example.com,
   foolitellmbar.example and friends. Replaced with a label-token match in
   a named helper, so "litellm" must be a whole dot- or hyphen-delimited
   token. All three of the original test hosts still match; a "litellm"
   path segment on an unrelated host still does not.

3. Transport gate. `not is_anthropic_wire` also swept in codex_responses,
   bedrock_converse and codex_app_server. Gated on
   api_mode == "chat_completions" explicitly.

4. Operator override. The grant is inferred from a provider/host name, but
   the custom-provider capability lookup was gated on is_anthropic_wire, so
   an explicit `prompt_caching: false` for the route+model was honored on
   /v1/messages and silently ignored on /v1/chat/completions. The lookup
   now also runs for a LiteLLM route, and its layout follows the transport
   rather than the declaration (an explicit `true` must not promote a
   chat_completions request to the native layout).

Tests: 64 passed. Adds the wire-shape contract the original matrix was
missing (asserts no breakpoint sits on the message envelope, rather than
only checking the returned tuple), plus lookalike-host, other-transport,
and both operator-override directions. All five guards mutation-checked —
reverting each fix turns the corresponding test red.

* fix(caching): match the litellm provider id token-wise too

Self-review follow-up. The previous commit fixed substring matching on the
HOST but left the provider-id side as a bare substring, so a user-named
provider like `custom:notlitellm` or `mylitellmthing` still matched and was
handed Anthropic markers — the same bug class, half-fixed.

Both signals now match `litellm` as a whole delimited token via a shared
helper. Real spellings (`litellm`, `custom:litellm`, `litellm-router`, and
the already-lowercased `LiteLLM`) still match; lookalikes no longer do.

Tests: 71 passed. Adds lookalike-provider and real-spelling guards; both
new guards mutation-checked. Differential matrix over 2688 configs vs
origin/main: 60 changes, every one a Claude model on a genuine LiteLLM
route getting the envelope layout, zero pre-existing routes altered.

* perf(caching): narrow the widened capability lookup to the LiteLLM grant

Self-review follow-up, caught by benchmarking the previous commit.

Widening the custom-provider capability-lookup gate to `is_anthropic_wire or
_is_litellm_route(...)` made EVERY chat_completions route with a litellm-ish
provider/host enter the lookup, including non-Claude models that the grant
branch below can never match. Measured on a route with no config.yaml
(the uncached worst case) that was ~7.5us -> ~1528us per evaluation.

Narrowed the gate to the exact condition the LiteLLM branch grants on
(chat_completions + Claude + litellm route), computed once into a local and
reused by the branch itself so the predicate no longer runs twice.

Measured with a realistic config.yaml present (mtime cache warm), vs
origin/main:
  live-agent policy      20.6us -> 61.7us
  destination planning  219.3us -> 347.7us

Sub-millisecond and scoped to the routes that actually opted in. The
earlier 1.5ms figures were a tempdir artifact: load_config_readonly's
mtime cache cannot engage when no config.yaml exists, which is never true
of a real install. Non-LiteLLM and non-Claude routes are unaffected
(openrouter Claude measured flat at ~7.9us).

Tests: 82 passed across the policy and TTL-propagation modules.

* test(caching): pin signal precedence and the openrouter-host opt-out

Review follow-up. Three coverage gaps in the LiteLLM matrix:

- The operator opt-out on a litellm-named provider pointed at an OpenRouter
  host. That route previously took the OpenRouter branch and ignored an
  explicit per-model `prompt_caching: false`; it is the only cell in the
  differential matrix where the salvage REMOVES caching, so pin it as
  intended rather than leaving it to be read as a regression.
- Signal precedence: an explicitly litellm-named provider grants even on a
  lookalike host, because the provider id is an independent signal and only
  the host-derived signal is token-gated. Intentional, now documented.
- A hyphen-delimited host label (`my-litellm-gw.internal.example.com`),
  which the token matcher handles but nothing exercised.

Traded the redundant `claude-3-7-sonnet` parametrize cell for the new host
case, so the matrix covers more shapes with the same cell count.

Tests: 83 passed. All three production fixes re-mutation-checked against
the final stack.

* fix(web_server): discover root user plugins under profile-scoped processes

When the backend is spawned profile-scoped (`--profile <name>` sets
HERMES_HOME=<root>/profiles/<name>), _discover_dashboard_plugins()
scanned only get_process_hermes_home()/plugins — the profile directory,
which has no plugins/ content. Pooled per-profile backends therefore
discovered zero user plugins, mounted no plugin API routes, and every
plugin REST call fell through to the SPA catch-all 404.

Also scan get_default_hermes_root()/plugins (which unwraps
<root>/profiles/<name> to <root> and leaves a custom HERMES_HOME
untouched when it is itself the root), matching how hermes_cli.plugins
resolves install locations. The profile home is scanned first, so a
profile-local plugin of the same name stays authoritative via the
existing seen_names dedupe.

Adds regression tests for root-plugin discovery under a profile-scoped
process and for profile-over-root precedence.

Fixes #87197 (plugin discovery half — the misleading /api/* catch-all
half is addressed separately in #87270).

* fix(telegram): keep /loop and synthetic sends in the active DM topic

Fixes #87051

* fix(desktop): show failed status for timed-out subagents in fallback stream path

Fixes #87200

* fix(desktop): match custom provider aliases in model catalog menu

Fixes #87035

* chore(contributors): map emails for P2-sweep salvage wave

* fix(desktop): avoid PowerShell parent marker boot gate

* fix(desktop): give Windows start-marker PowerShell probe a 30s budget

PowerShell 5.1 cold starts take 2.4-8s on affected Windows hosts, so the
shared 3s execText timeout hard-failed the parent start-marker probe for
any PID that still needs the PowerShell path (e.g. backend children).
Make execText's timeout overridable and raise the marker probe to 30s.

Fixes #87169

* perf(desktop): hydrate transcripts with a small tail page + on-demand older-page backfill

Replace the fixed 500-message REST hydration (getLatestSessionMessages)
with a 120-row newest-first tail page. When the page comes back full, a
new per-session tail store records "possibly truncated + next offset";
"Show earlier" — once the DOM budget and the in-memory store window are
both exhausted — fetches the next older page via the new
getOlderSessionMessages helper (order latest + offset, matching the
backend's back-from-newest paging semantics) and prepends it to the
session store, deduped by durable row id and race-guarded against
session switches. Legacy backends without pagination metadata fall back
to the one-shot full transcript and retire the action.

Tail-page refreshes (background sync, post-turn rehydrate, re-activate,
cold-resume prefetch) graft the refreshed tail onto any backfilled
prefix instead of clobbering it, preserving reference identity on
no-ops. includeCompacted stays on every read — compaction-archived rows
remain part of the durable display history.

* feat(desktop): MCP fleet cost/usage overlay with schema token estimates and 30-day usage

Each configured server row on the MCP Capabilities page now shows what it
costs and whether it earns its keep:

- ~per-call token estimate of the server's tool schemas, summed over ENABLED
  tools only (ceil(schema_chars/4) via the existing include/exclude filter)
- 30-day usage count from getUsageAnalytics(30), cached per scope profile
  like the Toolsets tab's toolCallsCache, mapped to servers via the
  mcp__<server>__<tool> registry-name convention (tools/mcp_tool.py)
- a subtle muted "unused" pill on enabled, probed-ok servers with nonzero
  schema cost and zero 30-day uses — never a dialog

Backend: the /api/mcp/servers/{name}/test probe now fills an additive
per-tool `schema_chars` (length of the SAME converted registry schema the
agent registers). Older backends omit it → renderer shows counts only;
older renderers ignore the extra key. Display-only: nothing changes what
schemas are sent to models, no config knobs.

i18n keys (costTokens/usage30d/unusedPill) added to types/en/zh/zh-hant/ja
(ar inherits en via defineLocale overrides). Pure math lives in
lib/mcp-cost.ts with unit tests; Python wire shape pinned in
tests/hermes_cli/test_web_server_profile_unification.py.

* fix(tui): map lineage edit ordinals past compression prefix

Desktop/TUI count full displayed lineage after compression, but
prompt.submit validated truncate ordinals against tip-only history.
Translate via display_history_prefix and recover stale 4018s on Desktop.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(desktop): hoist GatewayMock type into #82462 edit recovery suite

CI typecheck failed because GatewayMock lived only in the previous describe.

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(desktop): hermes:// deep link to install MCP servers with explicit confirmation

Adds hermes://mcp/install?name=NAME&config=B64 (base64url or standard
base64 JSON), mirroring Cursor's mcp/install deep link, so vendors and
docs can offer an "Add to Hermes" button.

- Electron: the existing generic hermes:// handler already forwards
  {kind, name, params}; only its comment is updated (no new handler).
- Renderer: use-desktop-integrations routes kind=mcp/name=install into
  a pending-install store; a new confirmation dialog shows the server
  name and the FULL pretty-printed config (attacker-controllable input),
  with a prominent caution for stdio command entries. Nothing is written
  until the user confirms; existing names require a rename or cancel.
  On confirm the server is merged over a fresh fetch of the current map
  via saveMcpServers, then navigation lands on /skills?tab=mcp&server=…
  so useDeepLinkHighlight focuses the new row.
- Validation: name ^[A-Za-z0-9._-]{1,64}$; config must decode to an
  object with a string http(s) `url` or a string `command` (never both);
  payloads over 32KB rejected; failures surface as a toast.
- Pure parser in src/lib/mcp-deeplink.ts with unit tests (url shape,
  command shape, bad base64, non-object, javascript: URL, oversized).
- i18n keys in types + en/zh/zh-hant/ja/ar.
- Docs: "Add to Hermes link" section in the MCP config reference.

* fmt(js): `npm run fix` on merge (#87599)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(desktop): background MCP health checks with re-auth nudges

MCP server problems (expired OAuth tokens especially) were only
discovered when the user visited the MCP page and a probe ran. Now a
renderer-side background checker (store/mcp-health.ts) sweeps the
active profile's enabled HTTP/SSE MCP servers on gateway connect and
every 30 minutes, and fires an in-app notification with a "Sign in"
action ("<name> MCP needs re-authentication") that navigates to the
MCP page with ?server=<name> so useDeepLinkHighlight focuses the
server and its Authenticate button. Navigation only — OAuth flows are
never auto-launched.

stdio servers are deliberately excluded: probing a stdio server SPAWNS
a local process, so a background timer must never touch them. Only
url-shaped servers (where OAuth expiry lives) are swept, sequentially.

The tab's probeCache/serverFingerprint/probeKey/NEEDS_AUTH_RE moved to
a shared lib/mcp-probe-cache.ts (behavior identical) so the page and
the checker share one probe cache and its 5-minute TTL — neither
surface re-probes what the other just learned.

Notifications fire only on a TRANSITION into needs-auth/error (pure
state machine, unit-tested), hard-capped at one per server per app
session, keyed per profile. Profile switches drop pending timers and
re-arm for the new profile; sweeps never run while the gateway is
disconnected. No new config knobs. i18n keys added across
en/zh/zh-hant/ja/ar + types.

* fmt(js): `npm run fix` on merge (#87607)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(desktop): scope messaging to active remote profile

Complete the sidebar profile-scope contract across remote Electron routing, older-backend fallbacks, standalone messaging refreshes, and pagination. Reject stale profile responses and keep the explicit all-profiles view unified.

Co-authored-by: 墨綠BG <s5460703@gmail.com>

Co-authored-by: liuhao1024 <sunsky.lau@gmail.com>

* fix(desktop): retain messaging totals per profile

Key resolved platform totals by Desktop profile and source so profile switches neither inherit another profile's count nor discard a count that was already resolved. Keep the full reset for connection configuration changes.

Co-authored-by: frendo <frendo.wu@gmail.com>

* fix(desktop): ignore stale messaging page responses

Sequence per-profile platform pagination so an older overlapping response cannot replace a newer, larger page.

* docs(desktop): document profile scope helpers

Add JSDoc to the exported helpers introduced by the profile-scoped sidebar change.

* fix(desktop): reject stale profile refreshes

* fix(desktop): harden profile-scoped refreshes

* fix(desktop): resolve sessions from sidebar caches

Consult messaging and cron caches before the by-id fallback so opening a sidebar row neither depends on a redundant network lookup nor duplicates it into regular recents.

Co-authored-by: protas-box <protas.box@icloud.com>

* fix(tools-config): stop reconfigure flow clobbering image_gen.use_gateway on managed FAL rows

The Nous Subscription image_gen row carries imagegen_backend="fal", so
_reconfigure_provider's post-model-picker step ran

    img_cfg["use_gateway"] = False

unconditionally at two sites, immediately after the managed branch had
written use_gateway=True. A user who picked Nous Subscription and then
re-entered `hermes tools` to change the model was silently flipped onto
their personal FAL_KEY.

Same bug class as fe63353cb, which fixed the plugin-provider selector
but missed these two legacy-backend sites in the reconfigure flow. Both
now write bool(managed_feature), matching the existing correct site in
_configure_provider.

Adds regression tests driven through the real TOOL_CATEGORIES managed
row; sabotage-verified (tests fail with the old behavior restored).

* feat(desktop): make the multi-gateway Connections registry discoverable

The multi-connection registry (Settings -> Connections) shipped with no
entry point outside the settings nav, and the product-owner report was
blunt: 'I didn't see any obvious way to hook up multiple gateways.'

- Profile rail: a plug pill pinned beside Manage ('Connect another
  Hermes gateway...') deep-links to /settings?tab=connections. Always
  visible, including for single-profile first-run users.
- Command palette: Settings -> Connections is now a searchable entry
  (keywords: add gateway, remote, ssh, cloud, instances, registry).
- i18n: profiles.connectGateway added to en/types/zh; other locales
  fall back through defineLocale.
- Tests: profile-rail-connect.test.tsx covers the deep link and the
  single-profile visibility guarantee.

* docs: full multi-gateway setup guide for Hermes Desktop

Expand user-guide/multi-connection-desktop.md into a complete setup
walkthrough: where to find the pane (settings nav, profile-rail plug,
command palette), the exact add-connection editor fields (Name,
Gateway URL, Authentication: Session token/OAuth, SSH host), Primary /
This device pills, Test semantics, agent roster + profile-rail
switching and per-profile session/cron/messaging scoping, token
storage via Electron safeStorage with the keyring-less Linux plain-
text opt-in, and troubleshooting. All quoted labels match the desktop
i18n strings. Cross-link the rail entry point from desktop.md.

* fix(desktop): never resolve a missing named gateway scope to the primary

activeGateway() fell back to the primary gateway when the active key named
a registry-agent scope (conn:<id>::<profile>) whose secondaries entry had
been evicted — e.g. closeSecondaryGateways() during a soft gateway switch —
so sends and session ops silently executed against the WRONG machine.

A named scope now resolves to its own socket or null, and every eviction
path (closeSecondaryGateways, pruneSecondaryGateways) explicitly restores
the primary as active when it evicts the active scope, keeping the
'activeKey always resolves' invariant with the atoms following.

* fix(desktop): sync connection atoms and share the switch mutex for agent activation

ensureGatewayForAgent (the SDK ensureAgent door) skipped the two invariants
the profile path provides:

- $connection / $activeGatewayProfile were only updated when a socket was
  freshly dialed (setConnection inside openSecondary), so activating an
  ALREADY-OPEN registry agent left both describing the previous backend —
  /api/fs, /api/media and image.attach routed to the wrong machine (same
  class as #46651) and newSessionInProfile targeted the stale profile.
- Activations bypassed the gatewaySwitch mutex, so a rapid agent/profile
  interleave could complete out of order with the earlier setActive()
  landing last.

Add profile.ts ensureGatewayAgent: the (connectionId, profile) analogue of
ensureGatewayProfile that shares the same gatewaySwitch mutex, moves
$activeGatewayProfile on every activation, and resyncs $connection from
getConnectionFor (best-effort, like the profile path). The SDK ensureAgent
now routes through it; local/null connectionId falls through to the
profile path unchanged.

* feat(desktop): expose busy turn flags on plugin SDK

Plugins can now read host.state.busy and host.state.awaitingResponse
for the focused chat. These follow the same session slice the chat pane
uses, so a draft falls back to the global flags and a background turn
does not leak.

* fix(desktop): make plugin SDK turn flags follow the focused chat

Follow-up to the salvaged #87558 commit: the PR's docs promised the flags
follow "the focused chat", but PRIMARY_SESSION_VIEW is the primary
workspace tab only — a focused session TILE would read the wrong chat.
Wire host.state.busy / host.state.awaitingResponse through the focused
slice ($focusedStoredSessionId / $focusedSessionState), same semantics
as the statusbar busy pulse, with the primary view (and its draft
fallback) while the workspace holds focus.

Adds a tile-focus vitest case and corrects the docs wording.

* feat(desktop): paste-anything MCP server import

Add a compact Import popover to the MCP Capabilities page that accepts
anything a user might copy from an MCP server README and infers the
server config:

- mcp.json snippets (mcpServers-wrapped, bare name->config maps, single
  unnamed server objects, Cursor/Claude `type` normalized to `transport`)
- bare npx/bunx/uvx/node/docker command lines (name inferred from the
  package basename, e.g. server-filesystem -> filesystem)
- `claude mcp add NAME [--transport http|sse] [-e K=V] [-H ...] [--] CMD
  ARGS...` and `claude mcp add NAME URL`
- bare http(s) URLs (name inferred from the hostname)
- Cursor deeplinks (cursor://anysphere.cursor-deeplink/mcp/install with
  a base64-encoded JSON config payload)

The parser is a pure module (src/lib/mcp-import.ts) with unit tests for
every format plus garbage input. The popover previews the inferred
name + config and, on confirm, merges the entries into the editor draft
exactly like addServer's starter entry: unique keys, dirty (unsaved)
draft, first new block focused. Placeholder env values (YOUR_KEY,
TOKEN_HERE, ...) are kept verbatim for the user to edit in the editor
before saving.

i18n keys added under settings.mcp for en, zh, zh-hant, ja (ar falls
back through defineLocale).

* feat(desktop): running is not busy

Gate composer submit and plugin host busy on the target session slice, not a leftover foreground busyRef. Staff can keep typing while a worker session is running.

Includes the follow-up test that submit uses the target session busy flag.

* fix(desktop): lint and map contributor email for running-is-not-busy

Drop the redundant Boolean() on selected in $primaryBusy and add the
professorpalmer9@gmail.com mapping so attribution CI can resolve the PR.

* feat(desktop-sdk): expose focused-session state atoms to plugins

Disk plugins read app state exclusively through host.state, which only
exposed the primary workspace tab ($activeSessionId). In the multi-tile
layout, clicking a tile never touches that atom — and tile focus is a
pure renderer concern, invisible to both gateway RPC and the event
stream — so a plugin cannot follow the session the user is actually
looking at.

The core statusbar solves this same problem by reading the focused-
session atoms (use-statusbar-items.tsx). Widen the generic plugin
surface with the same signals, per the contribution rubric:

- host.state.focusedSessionId — runtime id of the focused session
  (interacted tile, else the primary), the key for session.* RPC
- host.state.focusedStoredSessionId — durable id for navigation and
  session-list matching
- host.state.focusedUsage — live streamed UsageStats projection
  (context_used/max/percent, tokens, cost_usd), no RPC needed

Additive only; no existing behavior changes. tsc --noEmit clean.
Verified end-to-end with a disk plugin that now tracks the focused
session across tiles.

* test(desktop-sdk): contract-test the focused-session host.state atoms

Locks the plugin-facing contract: the focused atoms exist as readonly
nanostores, mirror the primary session while no tile is focused, project
the focused session's usage, and — the behavior this PR exists for —
follow the interacted tile while the primary-only $activeSessionId
stays put.

* fix(desktop-sdk): type focusedUsage as Partial<UsageStats>, fix expect arity

ClientSessionState.usage is Partial<UsageStats> (app/types.ts) — the
backend streams whichever fields changed — so the computed produces
ReadableAtom<Partial<UsageStats> | null>. Annotate the entry honestly
instead of claiming full UsageStats, and document the fallback rule for
plugin authors. Also collapse the three-argument expect() calls in the
contract test (vitest takes one message arg). Addresses triage review on
PR #80461.

* fix(desktop-sdk): address adversarial review — type honesty, real tile coverage, docs

Independent second-pass review found three gaps:

- focusedUsage is null | UsageStats, not Partial — ClientSessionState.usage
  is the full type (app/types.ts) and its only write site seeds the four
  required fields before merging (gateway-event.ts). The earlier Partial
  annotation traced the wrong type (SessionRuntimeInfo, an RPC payload).
  Comment now names the genuinely optional fields instead.
- The tile-focus contract test never seeded $sessionTiles/$sessionStates,
  so it proved focusedStoredSessionId…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sessions Session lifecycle, resume, persistence, history comp/desktop Electron desktop app (apps/desktop/*) comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/perf Performance improvement or optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Performance]: Make session.resume incremental or asynchronous to fit the Desktop RPC budget

4 participants