Fix dashboard session resume terminal remount - #51529
Closed
X1pheR wants to merge 1 commit into
Closed
Conversation
15 tasks
teknium1
reviewed
Jul 15, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for isolating the dashboard remount race. The current code still has the triggering sequence: web/src/pages/ChatPage.tsx:347-356 asynchronously rewrites ?resume=, while the PTY effect is keyed by channel/resumeParam at web/src/pages/ChatPage.tsx:1168.
Problems
- Removing the lookup drops the intentional latest-child behavior added in
b12a5a72b(Follow latest child session on dashboard resume). The comment says callers should resolve before navigation, but this PR does not add such a caller-side resolution. - The
showToolsbranches are stale against current main:ChatSidebarPropshas no such prop atweb/src/components/ChatSidebar.tsx:73-80, and both ChatPage call sites omit it atweb/src/pages/ChatPage.tsx:1364-1369and1484-1489. - There is no regression coverage for a delayed descendant lookup racing an already-connected PTY.
Suggested changes
- Preserve descendant canonicalisation before the live terminal mounts, and add a delayed-resolution remount regression test.
- Rework or omit the stale
showToolsportion against current ChatSidebar's actual API.
Automated hermes-sweeper review.
| @@ -169,6 +170,18 @@ export function ChatSidebar({ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Current main no longer declares or passes showTools: ChatSidebarProps is at current web/src/components/ChatSidebar.tsx:73-80, and both ChatPage call sites omit it. This branch must be reworked against the current sidebar API before salvage; a direct cherry-pick will not typecheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?resume=target instead of rewriting it after the PTY has already startedshowTools=falseTesting
npm run typecheck --workspace webnpm run build --workspace webnpx eslint src/pages/ChatPage.tsx src/components/ChatSidebar.tsx(passes with existing warnings only)/sessions/ right rail no longer turns the terminal black after the delayed refresh; text remains visible