Conversation
1 task
teknium1
reviewed
Jul 11, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for isolating the stale first-paint path and reusing the existing Ink redraw primitive.
Problems
- The
Closes #62170linkage is broader than this implementation. The helper is scheduled only after activation/resume (ui-tui/src/app/useSessionLifecycle.ts:322,:376), while #62170 separately reports normal live assistant responses staying invisible and says/redrawdoes not fix that symptom. This change cannot run for those later stream updates.
Suggested changes
- Keep this focused stale-resume repaint fix, but remove
Closes #62170or split the unresolved live-update symptom into a follow-up.
Automated hermes-sweeper review.
| if (!manuallyScrolledAfterResume && (index === 0 || scroll.isSticky())) { | ||
| scroll.scrollToBottom() | ||
|
|
||
| if (index === 0) { |
Collaborator
There was a problem hiding this comment.
This repaint is intentionally limited to the first resume snap. Since #62170 also reports a live-stream freeze after the resume completes, please avoid closing that entire issue with this PR unless that remaining symptom is split into a follow-up.
15 tasks
Collaborator
|
Merged via PR #86332 as part of the stale-repaint class fix (TUI focus regain / session resume / dashboard PTY reattach). Your commit was cherry-picked onto current main with your authorship preserved in git log. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #62170