Skip to content

fix(tui,dashboard): force clean repaint on focus regain, session resume, and PTY reattach - #86332

Merged
teknium1 merged 4 commits into
mainfrom
fix/tui-dashboard-repaint-class
Aug 14, 2026
Merged

fix(tui,dashboard): force clean repaint on focus regain, session resume, and PTY reattach#86332
teknium1 merged 4 commits into
mainfrom
fix/tui-dashboard-repaint-class

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Completes the stale/duplicated-chrome sweep on the two remaining surfaces after #86260 (classic CLI): the Ink TUI and the dashboard's embedded terminal now force a clean repaint at the three moments they previously trusted stale incremental state — terminal focus regain, session resume, and keep-alive PTY reattach.

Root cause across all three: differential renderers (Ink cell-diff, xterm ANSI-tail replay) repaint against a previous frame that no longer matches the physical surface, so the transcript shows ghosts, stale rows, or comes back blank.

Changes (salvages 3 contributor PRs, authorship preserved)

Validation

Suite Result
pytest: test_pty_session, test_pty_keepalive_ws, test_web_server_pty_reconnect 15 passed
vitest: App.focus.test, sessionResumeView.test, useSessionLifecycle.test 12 passed
tsc --noEmit (ui-tui) clean
attribution audit all mapped

Base current with origin/main at push time; each contributor commit cherry-picked individually (rebase-merge ready).

Infographic

TUI + dashboard repaint wireframes

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@teknium1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2362a454-128f-47c7-aa23-53af599adee4

📥 Commits

Reviewing files that changed from the base of the PR and between d29abb7 and dd44187.

📒 Files selected for processing (11)
  • contributors/emails/andrew.lg.ford@gmail.com
  • hermes_cli/pty_session.py
  • hermes_cli/web_server.py
  • tests/test_pty_keepalive_ws.py
  • tests/test_pty_session.py
  • ui-tui/packages/hermes-ink/src/ink/components/App.focus.test.tsx
  • ui-tui/packages/hermes-ink/src/ink/components/App.tsx
  • ui-tui/packages/hermes-ink/src/ink/ink.tsx
  • ui-tui/src/app/sessionResumeView.test.ts
  • ui-tui/src/app/sessionResumeView.ts
  • ui-tui/src/app/useSessionLifecycle.ts

Comment @coderabbitai help to get the list of available commands.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/dashboard Web dashboard / control panel UI (dashboard/, landing) sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on dd44187 — chore: contributor email mappings for salvaged PRs

⚠️ Warnings

OSV vulnerability scan · View job

5 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


debug info

CI timings

CI timings · View report · View job

Wall time 8m17s vs 11m22s (-27.1%). 15 job(s) slower, 21 faster, 1 unchanged.

  • Check contributors / check-attribution: -170.0s
  • Detect affected areas: -140.0s
  • OSV scan / Emit review status: -99.0s
  • Python tests / Generate slices: -95.0s
  • Python tests / Run tests slice 11/12: -78.0s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/dashboard Web dashboard / control panel UI (dashboard/, landing) comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants