fix(tui,dashboard): force clean repaint on focus regain, session resume, and PTY reattach - #86332
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Comment |
૮ >ﻌ< ა ci reviewran on dd44187 — chore: contributor email mappings for salvaged PRs
|
Summary
Completes the stale/duplicated-chrome sweep on the two remaining surfaces after #86260 (classic CLI): the Ink TUI and the dashboard's embedded terminal now force a clean repaint at the three moments they previously trusted stale incremental state — terminal focus regain, session resume, and keep-alive PTY reattach.
Root cause across all three: differential renderers (Ink cell-diff, xterm ANSI-tail replay) repaint against a previous frame that no longer matches the physical surface, so the transcript shows ghosts, stale rows, or comes back blank.
Changes (salvages 3 contributor PRs, authorship preserved)
Appwrapper to the renderer; on focus-in, reassert terminal modes and force one full redraw instead of trusting pre-blur incremental frame state (TUI twin of the classic-CLI focus fix in fix(cli): resolve the duplicated prompt/status chrome class (interrupt, resize, focus regain, tmux attach) #86260)evictInkCaches+forceRedraw) on the immediate resume snap after switching sessions, fixing the stale first paint ([Bug]: TUI shows stale session content after switching sessions (v0.18.1) #62170); resume-scroll helper extracted tosessionResumeView.tswith focused coverage. Conflict resolved to keep main's newersignalFreshSessionBoundaryalongside the moved helper/api/ptyrequests a complete TUI redraw (Ctrl-L to the bridge) when reusing a keep-alive PTY; a bounded raw ANSI tail is not a self-contained frame, so reconnects to long sessions restored only the recent status/prompt rows and left the transcript blank. First-attach behavior unchangedValidation
Base current with origin/main at push time; each contributor commit cherry-picked individually (rebase-merge ready).
Infographic