Skip to content

fix(gateway): normalize MSYS paths in validate_media_delivery_path - #57696

Closed
nankingjing wants to merge 1 commit into
NousResearch:mainfrom
nankingjing:fix/47767-msys-media-delivery-path
Closed

fix(gateway): normalize MSYS paths in validate_media_delivery_path#57696
nankingjing wants to merge 1 commit into
NousResearch:mainfrom
nankingjing:fix/47767-msys-media-delivery-path

Conversation

@nankingjing

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • pytest tests/gateway/test_platform_base.py::TestMediaDeliveryDefaultMode::test_accepts_msys_path_after_windows_normalization

Fixes NousResearch#47767

Git Bash MEDIA:/c/Users/... paths were rejected because pathlib
on Windows treats them as relative. Reuse _msys_to_windows_path from
tools.environments.local (same helper as terminal cwd resolution).
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/windows Native Windows-specific behavior or breakage P2 Medium — degraded but workaround exists sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages duplicate This issue or pull request already exists labels Jul 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #47821 — both fix #47767 by normalizing MSYS/Git-Bash paths via _msys_to_windows_path() inside validate_media_delivery_path() (gateway/platforms/base.py). Same file, same function, same mechanism. #47821 is the earlier canonical PR.

@nankingjing

Copy link
Copy Markdown
Contributor Author

Closing in favor of the earlier canonical fix path that the maintainer review identified in the comment thread.

Per the triage comment on this PR:

Keeping the narrower cluster open does not help the maintainer pick a canonical fix; closing these reduces the supersede noise so the maintainer can land the right one. Thanks to the alt-glitch triage for the cross-references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists platform/windows Native Windows-specific behavior or breakage sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Windows MSYS/Git Bash paths rejected by validate_media_delivery_path(), blocking MEDIA directive sends

2 participants