fix(kanban): terminate live workers on manual exits from running - #31365
Open
Dusk1e wants to merge 1 commit into
Open
fix(kanban): terminate live workers on manual exits from running#31365Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
This was referenced Jul 3, 2026
This was referenced Jul 4, 2026
Contributor
|
Thanks for addressing a real worker-lifecycle gap. Current Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
running -> done/blocked/scheduled/archivedtransitions now best-effort terminate the live claimed worker before clearing run metadata.hermes_cli/kanban_db.pyso CLI/core paths and dashboard direct-status moves use the same worker termination logic.complete_task,archive_task, and dashboard drag-drop offrunning.Validation
python -m pytest tests/hermes_cli/test_kanban_db.py tests/plugins/test_kanban_dashboard_plugin.py -q --timeout-method=thread -k "complete_task_terminates_foreign_running_worker or complete_task_skips_terminating_self_worker or archive_task_terminates_foreign_running_worker or patch_status_ready_terminates_running_worker or patch_status_archive_closes_running_run or patch_status_done_with_summary_and_metadata"Result:
6 passed, 257 deselectedResult:
complete_ok=True,status=done,worker_pid=None,run_outcome=completed,proc_exited=True,returncode=15Additional broader check
python -m pytest tests/hermes_cli/test_kanban_db.py tests/plugins/test_kanban_dashboard_plugin.py --timeout-method=thread -vv --maxfail=3Result before stop:
125 passed, 3 failed_resolve_hermes_argvexpectations on this Windows/Python shim environment:test_resolve_hermes_argv_prefers_path_shimtest_resolve_hermes_argv_hermes_bin_bare_name_uses_pathtest_resolve_hermes_argv_falls_back_to_module_form_when_no_path_shimNotes
--timeout-method=threadbecause this Windows environment does not support the defaultSIGALRMpath used bypytest-timeout.PermissionErrorat process exit on this machine; it does not affect the kanban fix itself.