fix(state): avoid double-encoding reasoning columns on fork round-trip - #57536
Closed
nankingjing wants to merge 1 commit into
Closed
fix(state): avoid double-encoding reasoning columns on fork round-trip#57536nankingjing wants to merge 1 commit into
nankingjing wants to merge 1 commit into
Conversation
Fixes NousResearch#57240 get_messages() leaves reasoning_details/codex_* columns as stored TEXT. replace_messages() must not json.dumps() those strings again or forked sessions silently lose reasoning replay on resume. Add _encode_json_column() and use it in append_message and _insert_message_rows so pre-serialized TEXT passes through unchanged.
Collaborator
Duplicate of #57248 — same write-path-only mechanism for #57240: a helper that passes already-serialized TEXT through unchanged (else |
This was referenced Jul 4, 2026
Contributor
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_messages()returns reasoning columns as stored TEXT;replace_messages()(used byPOST /api/sessions/{id}/fork) was callingjson.dumps()on those strings, double-encoding them so forked sessions silently lost reasoning replay on resume._encode_json_column()and use it inappend_messageand_insert_message_rows: live structures still serialize as before; pre-serialized TEXT fromget_messages()passes through unchanged.Test plan
pytest tests/test_hermes_state.py::TestMessageStorage::test_get_messages_roundtrip_preserves_reasoning_columnstest_reasoning_details_persisted_and_restoredstill passes