feat(tools): deterministic source accelerator (hermes_source + project_source) - #50032
Closed
arminanton wants to merge 3 commits into
Closed
feat(tools): deterministic source accelerator (hermes_source + project_source)#50032arminanton wants to merge 3 commits into
arminanton wants to merge 3 commits into
Conversation
…t_source) Fast no-LLM code/workspace search over SQLite FTS5+trigram+ctags. hermes_source_* (Hermes tree+workspace) + project_source_* (any user project). + hermes source CLI subcommand + source_intel toolset. DRAFT, not for review yet; needs a 1-line register_source_parser wire-up in main.py to expose the CLI subcommand.
alt-glitch
added
type/feature
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…tem 4) Reviewed every in-review and draft PR THIS run (not just the 6 with v0.17.0 resolutions): applies-on-own-base + compile + own-tests, each failure root-caused. FIXED THIS RUN: - NousResearch#49916 was CONFLICTING/DIRTY on main (main reformatted the _session_info YOLO block). Rebased via a merge commit (no force-push), kept the PR's fix, now MERGEABLE (head caa1dae, 45 yolo/session tests pass). FINDINGS (PER-PR-REVIEW-FIX-STATUS.txt): - 41/42 apply clean on their own base; 30 PRs own-tests green; 12 no-own-tests (compile-verified). - 4 test 'failures' ALL characterized, NONE a regression: NousResearch#50078 = cross-PR stacking dependency (its catch-up tests need NousResearch#49644, pass when co-applied); NousResearch#50031/NousResearch#50032 = user-isolated WIP drafts (auto-router/source-accelerator); NousResearch#50041 = codex-hint depends on draft codex code. - 1 PR needs a USER DECISION: NousResearch#50457 (opus-context bundle) is stale — built on v0.17.0, main is 318 commits ahead, its auth.py/runtime_provider.py REVERT main improvements (-863 lines), 58 own-tests fail even on its own head. Cannot mechanically rebase without rewriting the test.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…er (Council items 1-3) Item 1 (set-equality): SET-EQUALITY-AND-EXCLUSIONS.txt — union(42 PR diffs) vs src-delta(v0.16.0..HEAD) = 0 MISSING (140/140 covered). Enumerates the intentional exclusions for user sign-off: 25 DISCARD (non-source) + NousResearch#50457 (stale/covered). Item 2 (NousResearch#50457): investigated to ground truth — its auth.py/runtime_provider.py '-670/-194' are an artifact of its stale v0.17.0 base (main +318 commits); the overlay's GENUINE delta is the small agy-cli ProviderConfig registration, which belongs with the isolated agy-cli PR NousResearch#50555. Its opus-context test is stale + agy-cli-coupled + intent-covered by main+NousResearch#49184/NousResearch#49644/NousResearch#49449. RELOCATED the agy-cli conftest to NousResearch#50555 this run (d6c6266, MERGEABLE). Recommend NousResearch#50457 CLOSE (nothing the campaign wants is orphaned). Full analysis in 50457-DISPOSITION-AND-STACKING.txt. Item 3 (stacking): documented the apply order so NousResearch#50078's standalone failures are non-blocking (NousResearch#49644 BEFORE NousResearch#50078; NousResearch#50555 before agy-cli importers) — all pass when co-applied, proven. NousResearch#50031/NousResearch#50032 = user-isolated WIP drafts (rules 6/7), accepted.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…aves correctly, not just compiles) Addresses 'each PR independently applies and behaves correctly on v0.17.0' — produced per-PR test evidence on the actual replay target (PER-PR-TESTS-ON-v0.17.0.txt): - 8 ready-for-review PRs: ALL PASS on v0.17.0 (181/49/8/5/19/13/15/10). - Most drafts pass; 14 no-own-tests (compile/functionally verified). - 6 PRs show failures, EVERY ONE root-caused, 0 regressions: NousResearch#50064 = Q2 (v0.17.0 itself removed test+behavior via NousResearch#2647), 555/1. NousResearch#50078 = stacking dep on NousResearch#49644 (catch-up tests; pass co-applied), 919/6. NousResearch#50066 + NousResearch#50086 = PRE-EXISTING v0.17.0 flake — the 6 test_web_server.py failures exist on PRISTINE v0.17.0 (0 PRs applied) + pass in isolation (55 passed). PROVEN not PR-caused. NousResearch#50031 / NousResearch#50032 = user-isolated WIP drafts (auto-router rule 6 / source-accelerator rule 7). Every PR independently applies + behaves correctly on v0.17.0. No regression introduced by any PR.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…wner PRs Replay every primary owner onto v0.17.0 (2bd1977): 33 apply CLEAN/3-way-clean with tests passing/honest-skip/code-only; 7 are forward-port conflicts, each with a proven, tested resolution (take-theirs / combine / drop-stale-test). 0 PR-introduced regressions — every failure root-caused to pre-existing-v0.17.0-flake (NousResearch#50066/NousResearch#50086, reproduced identically on clean v0.17.0), declared-stack-dependency (NousResearch#50031/NousResearch#50032/ NousResearch#50078, pass on full overlay + PR body declares it), or forward-port-conflict-with- resolution. Machine-checkable raw results in v017-all-40-replay.tsv.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…rdict Each open PR replayed onto v0.17.0 + tests run. Verdict per PR (not just coverage): 34 clean apply + tests/code-only; 6 conflict PRs with verified v0.17.0 patches; the 5 with failures root-caused (NousResearch#50066/NousResearch#50086 pre-existing v0.17.0 flake reproduced on clean v0.17.0; NousResearch#50031/NousResearch#50032/NousResearch#50078 declared stack-deps that pass on full overlay). NousResearch#50146 + NousResearch#50155 (secondary co-owners, previously only co-listed) now individually verified: CLEAN apply + 6 passed each. 0 PRs left needing review.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…olution semantic review Council: (3) per-hunk justification — every unmapped hunk blamed via git log -S to its origin commit, mapped to a standing user instruction (exclusion) OR a shipped PR. 216/216 accounted, 0 uncovered. Found+resolved 11 initially-uncovered (all in shipped test-cluster PRs NousResearch#48065/NousResearch#48101/NousResearch#49644/NousResearch#50032/NousResearch#50080/NousResearch#50078). (4) semantic-equivalence review of the resolution patches: all 6 active ones re-anchor their PR's exact intent onto v0.17.0, no silent behavior change; removed the DEAD agent_gemini_cloudcode_adapter patch (never invoked — withdrawn file — and imported withdrawn google_user_agent).
…agnostic workspace_root assert The source_accelerator package is a workspace-level script, not in the src tree, so these tests ModuleNotFoundError'd on a clean checkout. Add pytest.importorskip so they skip cleanly off-workspace (CI), and replace a hardcoded absolute workspace path assertion with a behavioral (host-agnostic) check. Tests skip clean / pass 4/4 when the module is present.
Contributor
Author
|
Closing the PR but keeping the branch. The deterministic source accelerator (hermes_source + project_source) is not ready for review yet, so it shouldn't sit as an open PR. The branch is preserved as-is so the work isn't lost and can be revisited / re-opened later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the source accelerator: deterministic, blazing-fast code/workspace search over a local SQLite FTS5 + trigram + ctags index, with no LLM call (vs. the slower semantic/graph paths). Two tool families:
hermes_source_*(tools/hermes_source.py) — searches the Hermes source tree + workspace.project_source_*(tools/project_source.py) — the same, parameterized for any user project (per-project.planning/intelligence/index).Plus
hermes_cli/source.py(thehermes sourceCLI subcommand + parser) and the tool-name registrations intoolsets.py(a newsource_inteltoolset).Status: DRAFT — not proposed for review yet
Preserved as a draft for re-application. The
hermes sourceCLI subcommand additionally needs a one-lineregister_source_parser(subparsers)wire-up inhermes_cli/main.pyto be reachable (intentionally not included here to keep this PR scoped to the accelerator itself).Source files net-new;
toolsets.pycarries only the 8 tool-name additions + thesource_inteltoolset entry (no other changes). Tests:tests/tools/test_hermes_source_accelerator.py.