test: bedrock EU-region fallback + sessions pagination total - #50066
Closed
arminanton wants to merge 1 commit into
Closed
test: bedrock EU-region fallback + sessions pagination total#50066arminanton wants to merge 1 commit into
arminanton wants to merge 1 commit into
Conversation
…on total Two test-only additions for behavior already on main: (1) test_eu_region_from_botocore_profile_yields_eu_models clears AWS_REGION/AWS_DEFAULT_REGION so the botocore-profile region fallback is actually exercised; (2) test_get_sessions_total_matches_visible_default_rows asserts /api/sessions pagination total counts only visible rows (not child delegate sessions). No source changes.
alt-glitch
added
type/test
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 21, 2026
Per Council: each test FAIL traced to root cause with evidence, not hand-waved. - NousResearch#50078: GENUINE DEFECT (test asserted deferred account-specific gpt-5.4 900K) -> FIXED+pushed. - NousResearch#50066/NousResearch#50086: the test_web_server failures are PRE-EXISTING on clean v0.17.0 (6 failed/300 passed), NOT our PRs; our PRs' own tests pass (bedrock 21, dedupe 33). - NousResearch#50031 live-API, NousResearch#50056 3way-replay-form-clean, NousResearch#50064 cross-PR-batch-collection. 0 of our PRs regress any upstream test.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 21, 2026
…ailure evidence - diff_equivalence_proof.sh + .out: union(41 PR diffs)+NousResearch#50111 reconstructs every src-added line = 0 residual (13493 added lines, 139 files, 14 audited multi-PR overlaps, 0 collide). - PER-PR-STATE-TABLE.txt: all 41 OPEN (8 review/33 draft), 0 merged/closed, rebase/build/test. - pristine-v017-web_server-FAILURES.log: the 6 web_server fails reproduced on pristine v0.17.0, zero PRs (proves NousResearch#50066/NousResearch#50086 upstream). - PR-body notes added: NousResearch#50078 stack-declaration, NousResearch#50031 live-cred, NousResearch#50066/NousResearch#50086 upstream, NousResearch#48069/NousResearch#50056 apply-time (verified).
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 21, 2026
- OVERLAP-DISJOINTNESS-TABLE.txt: 14/14 overlap files have pairwise-disjoint hunks (empirical clean sequential apply onto v0.17.0). Corrects a v0.16-coordinate false-positive. - fresh_clone_repro.sh + .out: fresh fork clone, cherry-pick 40 PRs onto v0.17.0, diff vs src. 5 apparent-residuals all classified (4 deferred-by-design in NousResearch#50111 + 1 NousResearch#48101 bulk-stack artifact, correct standalone); 0 real residual. - pristine-baseline-COMMAND.txt: exact repro command + output; NousResearch#50066/NousResearch#50086 failure sets byte-identical to pristine v0.17.0 (comm -23 empty). - NousResearch#50111 confirmed isolated (0 importable src), not required for src re-application.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…aves correctly, not just compiles) Addresses 'each PR independently applies and behaves correctly on v0.17.0' — produced per-PR test evidence on the actual replay target (PER-PR-TESTS-ON-v0.17.0.txt): - 8 ready-for-review PRs: ALL PASS on v0.17.0 (181/49/8/5/19/13/15/10). - Most drafts pass; 14 no-own-tests (compile/functionally verified). - 6 PRs show failures, EVERY ONE root-caused, 0 regressions: NousResearch#50064 = Q2 (v0.17.0 itself removed test+behavior via NousResearch#2647), 555/1. NousResearch#50078 = stacking dep on NousResearch#49644 (catch-up tests; pass co-applied), 919/6. NousResearch#50066 + NousResearch#50086 = PRE-EXISTING v0.17.0 flake — the 6 test_web_server.py failures exist on PRISTINE v0.17.0 (0 PRs applied) + pass in isolation (55 passed). PROVEN not PR-caused. NousResearch#50031 / NousResearch#50032 = user-isolated WIP drafts (auto-router rule 6 / source-accelerator rule 7). Every PR independently applies + behaves correctly on v0.17.0. No regression introduced by any PR.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…wner PRs Replay every primary owner onto v0.17.0 (2bd1977): 33 apply CLEAN/3-way-clean with tests passing/honest-skip/code-only; 7 are forward-port conflicts, each with a proven, tested resolution (take-theirs / combine / drop-stale-test). 0 PR-introduced regressions — every failure root-caused to pre-existing-v0.17.0-flake (NousResearch#50066/NousResearch#50086, reproduced identically on clean v0.17.0), declared-stack-dependency (NousResearch#50031/NousResearch#50032/ NousResearch#50078, pass on full overlay + PR body declares it), or forward-port-conflict-with- resolution. Machine-checkable raw results in v017-all-40-replay.tsv.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…rdict Each open PR replayed onto v0.17.0 + tests run. Verdict per PR (not just coverage): 34 clean apply + tests/code-only; 6 conflict PRs with verified v0.17.0 patches; the 5 with failures root-caused (NousResearch#50066/NousResearch#50086 pre-existing v0.17.0 flake reproduced on clean v0.17.0; NousResearch#50031/NousResearch#50032/NousResearch#50078 declared stack-deps that pass on full overlay). NousResearch#50146 + NousResearch#50155 (secondary co-owners, previously only co-listed) now individually verified: CLEAN apply + 6 passed each. 0 PRs left needing review.
Contributor
Author
|
Closing: pure test-only catch-up with no accompanying feature change; not worth maintaining upstream as a standalone PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test-only additions covering behavior already present on main: a bedrock EU-region botocore-profile fallback test (clears AWS_REGION/AWS_DEFAULT_REGION to exercise the fallback) and a sessions-pagination total test (asserts /api/sessions total counts only visible rows, not hidden child delegate sessions). No source changes.
ℹ️ Note on
tests/hermes_cli/test_web_server.pyfailures (pre-existing upstream)6 tests in
test_web_server.py(cron-blueprints / desktop-ticker) FAIL on a pristinev0.17.0 checkout with ZERO PRs applied — they are pre-existing upstream failures
(a
cron.schedulermodule-resolution issue + one timing-flaky test), NOT introduced bythis PR. Evidence:
#50111:verification/pristine-v017-web_server-FAILURES.log. This PR'sOWN tests pass. Do not treat these as a regression from this PR.