fix(doctor): skip operator-declared optional integrations instead of warning - #50041
Draft
arminanton wants to merge 1 commit into
Draft
fix(doctor): skip operator-declared optional integrations instead of warning#50041arminanton wants to merge 1 commit into
arminanton wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…LE) + reproducible delta map - GITHUB-MERGEABLE-AUDIT.md: GitHub mergeable=40/41 (only NousResearch#50111 manifest conflicts). 6 PRs (NousResearch#50296/NousResearch#49644/NousResearch#50041/NousResearch#50073/NousResearch#50064/NousResearch#50033) genuinely conflicted on current origin/main (drifted past v0.17.0); each rebased (1-file complementary conflict), now MERGEABLE. - DELTA-MAP-v017.md: reproducible per-file map (PR diffs vs v0.17.0, fresh tips): 160 = 137 in-PR + 21 DISCARD + 2 upstream-NousResearch#29433 + 0 orphans, sum verified.
arminanton
added a commit
to arminanton/hermes-agent
that referenced
this pull request
Jun 22, 2026
…tem 4) Reviewed every in-review and draft PR THIS run (not just the 6 with v0.17.0 resolutions): applies-on-own-base + compile + own-tests, each failure root-caused. FIXED THIS RUN: - NousResearch#49916 was CONFLICTING/DIRTY on main (main reformatted the _session_info YOLO block). Rebased via a merge commit (no force-push), kept the PR's fix, now MERGEABLE (head caa1dae, 45 yolo/session tests pass). FINDINGS (PER-PR-REVIEW-FIX-STATUS.txt): - 41/42 apply clean on their own base; 30 PRs own-tests green; 12 no-own-tests (compile-verified). - 4 test 'failures' ALL characterized, NONE a regression: NousResearch#50078 = cross-PR stacking dependency (its catch-up tests need NousResearch#49644, pass when co-applied); NousResearch#50031/NousResearch#50032 = user-isolated WIP drafts (auto-router/source-accelerator); NousResearch#50041 = codex-hint depends on draft codex code. - 1 PR needs a USER DECISION: NousResearch#50457 (opus-context bundle) is stale — built on v0.17.0, main is 318 commits ahead, its auth.py/runtime_provider.py REVERT main improvements (-863 lines), 58 own-tests fail even on its own head. Cannot mechanically rebase without rewriting the test.
…warning hermes doctor warned about integrations the operator intentionally left unconfigured. Adds _config_string_set + operator-ignore handling so optional toolsets/auth rows declared as ignored are skipped rather than flagged. + 2 tests.
arminanton
force-pushed
the
fix/doctor-optional-integrations
branch
from
June 23, 2026 19:31
9103989 to
7ac5b43
Compare
teknium1
reviewed
Jul 14, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing the noisy optional-integration diagnostics. The premise still holds on current main: disabled/default-off toolsets are excluded only from the final summary, while their warning rows remain at hermes_cli/doctor.py:2187-2200.
Problems
ignore_auth_providersis presented as a provider list, but the diff only checks it for Nous Portal and MiniMax OAuth. OpenAI Codex and xAI OAuth still emit their own warnings athermes_cli/doctor.py:1115-1152.- The PR adds
doctor.ignore_toolsetsanddoctor.ignore_auth_providerswithout registering or documenting them.DEFAULT_CONFIGbegins athermes_cli/config.py:976, and this PR changes onlyhermes_cli/doctor.pyandtests/hermes_cli/test_doctor.py.
Suggested changes
- Apply the auth-ignore behavior to every Auth Providers row, or explicitly scope the setting to the supported rows.
- Add empty defaults and user-facing documentation for the new
doctorconfiguration section. - Cover output from
run_doctor, including the auth rows, rather than only helper predicates.
This is an automated hermes-sweeper review.
| @@ -1074,11 +1118,14 @@ def run_doctor(args): | |||
| get_minimax_oauth_auth_status, | |||
Contributor
There was a problem hiding this comment.
ignore_auth_providers is generic, but this diff only consumes it for Nous and MiniMax. Please also apply it to the OpenAI Codex and xAI OAuth warning paths, or narrow the setting to the providers it actually controls.
| @@ -77,6 +77,48 @@ def _safe_which(cmd: str) -> str | None: | |||
| return None | |||
Contributor
There was a problem hiding this comment.
This creates a new user-facing doctor.* config surface. Please add empty defaults to DEFAULT_CONFIG and document the accepted toolset/provider names so users can discover and configure it.
teknium1
added
sweeper:blast-contained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes doctorwarned about integrations the operator intentionally left unconfigured. Adds_config_string_set+ an optional-toolset/auth skip so operator-declared optional integrations are skipped rather than flagged as warnings.hermes_cli/doctor.py+ 2 tests. Draft for review.