feat(desktop): added Russian language - #40701
Conversation
| 'ru-md': 'ru', | ||
| ru_md: 'ru', | ||
| 'be': 'ru', | ||
| 'uk': 'ru', |
There was a problem hiding this comment.
🚨 Russian imperialism alert: this change claims that the Ukrainian, Belarusian, and Kazakh languages are actually Russian.
teknium1
left a comment
There was a problem hiding this comment.
Thanks for the Russian Desktop locale contribution. Current main still lacks ru: apps/desktop/src/i18n/catalog.ts:7-11 registers only en, zh, zh-hant, and ja; apps/desktop/src/i18n/types.ts:8 likewise excludes it. The linked maintainer triage on #53643 identifies this PR as the earliest canonical member of the duplicate cluster.
Problems
apps/desktop/src/i18n/languages.ts:83-85mapsbe,uk, andkkto Russian. Belarusian, Ukrainian, and Kazakh are distinct languages; these aliases should not selectru.- The diff changes no tests. Current coverage validates aliases, persistence, and runtime text for existing locales in
apps/desktop/src/i18n/languages.test.ts:6-42,context.test.tsx:187-209, andruntime.test.ts:31-47; add equivalentru/ru-RUcoverage.
Suggested changes
- Keep only Russian language tags in the
rualias set. - Add normalization, config-persistence, and runtime-translation tests for Russian.
- Salvage the semantic changes against current i18n files without the whole-file line-ending rewrites.
Automated hermes-sweeper review.
| ru_kz: 'ru', | ||
| 'ru-md': 'ru', | ||
| ru_md: 'ru', | ||
| 'be': 'ru', |
There was a problem hiding this comment.
be, uk, and kk are Belarusian, Ukrainian, and Kazakh rather than Russian. Please remove these aliases so configuring one of those language tags does not silently select the Russian UI.
|
@ponkalapon, я подготовил продолжение вашего PR поверх Ветка синхронизирована с current main, закрывает Russian Desktop i18n и проходит проверки. Upstream locale-PR не создавал — исходный #40701 и ваше авторство сохранены. |
feat(desktop): complete Russian locale for NousResearch#40701
Summary