feat(i18n): add Russian (ru) locale to Hermes Desktop - #70673
Open
saimon4eg wants to merge 1 commit into
Open
Conversation
Uses the defineLocale() partial-locale pattern (same as ja.ts) — any missing keys fall back to English, so the locale stays healthy as upstream adds new keys. Includes: - Desktop locale (apps/desktop/src/i18n/ru.ts) — 2889 lines - Locale type, catalog, languages, and aliases wired up
alt-glitch
added
type/feature
Collaborator
4 tasks
teknium1
reviewed
Jul 30, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the Russian Desktop locale contribution. There are two substantive issues before this older duplicate patch could be used.
Problems
apps/desktop/src/i18n/ru.ts:117uses an English-stylecount === 1/count < 5split. It renders incorrect Russian forms for 11 and 21. The active #40701 candidate has anIntl.PluralRules('ru')helper and tests those edge cases.- This four-file diff adds no tests. Current locale coverage is established in
apps/desktop/src/i18n/languages.test.ts:5-47,context.test.tsx:187-210, andruntime.test.ts:18-68; Russian needs equivalent alias, persistence, runtime, and plural coverage. - Current main now registers Arabic in the same integration files (
catalog.ts:1-13,languages.ts:32-82,types.ts:8), so this patch cannot be applied verbatim without preserving that work.
Suggested changes
- Consolidate on the maintained #40701 Russian implementation, which already carries plural handling and dedicated locale tests, rather than independently salvaging this older table.
Automated hermes-sweeper review.
| region: 'Уведомления', | ||
| hide: 'Скрыть', | ||
| show: 'Показать', | ||
| more: count => |
Contributor
There was a problem hiding this comment.
Russian plural categories are not 1 versus < 5: 11 needs уведомлений, while 21 needs уведомление. Please route count-bearing copy through an Intl.PluralRules('ru') helper and add edge-case tests (at least 11 and 21).
teknium1
added
sweeper:risk-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Russian language support to Hermes Desktop.
Uses the defineLocale() partial-locale pattern (same as ja.ts) — any missing keys fall back to English.
Changes
Closes #64929.