fix(launchd): use unconditional KeepAlive so gateway restarts after clean exit #37388 - #37534
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(launchd): use unconditional KeepAlive so gateway restarts after clean exit #37388#37534kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
…lean exit The launchd plist shipped with KeepAlive.SuccessfulExit=false, which meant launchd only restarted the gateway on non-zero exit. When 'gateway run --replace' triggered a clean exit (code 0), launchd did not relaunch it, leaving the gateway down indefinitely until manually restarted. Changed KeepAlive to unconditional true so the gateway always restarts regardless of exit code. Also updated docstrings to reflect the new KeepAlive policy. Fixes NousResearch#37388
Collaborator
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The launchd plist shipped with
KeepAlive.SuccessfulExit=false, which meant launchd only restarted the gateway on non-zero exit. Whengateway run --replacetriggered a clean exit (code 0), launchd did not relaunch it, leaving the gateway down indefinitely until manually restarted.Fix
Changed
KeepAlivefrom:To:
This ensures the gateway always restarts regardless of exit code, which is the correct behavior for a long-lived service managed by launchd.
Testing
<true/>KeepAliveFixes #37388