fix(gateway): use unconditional KeepAlive in launchd plist - #9689
Closed
digging-airfare-4u wants to merge 1 commit into
Closed
fix(gateway): use unconditional KeepAlive in launchd plist#9689digging-airfare-4u wants to merge 1 commit into
digging-airfare-4u wants to merge 1 commit into
Conversation
Author
|
ping — keeps launchd from silently dropping gateways on clean exit. one-liner, ready for review. |
Change KeepAlive from conditional SuccessfulExit-based to unconditional. This ensures launchd always restarts the gateway after any exit (including clean exits during restarts or config reloads), preventing the gateway from silently staying down. Fixes NousResearch#9659
digging-airfare-4u
force-pushed
the
fix/issue-9659
branch
from
April 16, 2026 01:48
945cba7 to
87d27bb
Compare
5 tasks
alt-glitch
added
type/bug
Collaborator
|
Likely duplicate of #14001 — both change launchd KeepAlive from SuccessfulExit-conditional to unconditional true for gateway restart reliability. |
This was referenced May 31, 2026
Contributor
|
This is an automated hermes-sweeper review: the requested launchd behavior is already implemented on current
Thanks for the focused fix and for documenting the clean-exit failure mode. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the generated launchd plist's
KeepAlivefrom a conditionalSuccessfulExit-based dictionary to an unconditional<true/>boolean.Problem
The previous
KeepAliveconfig only restarted the gateway after a non-zero exit code. When the gateway exited cleanly (e.g., during restarts, config reloads, or graceful shutdowns), launchd treated it as "job completed successfully" and did not restart it. With multiple profiles, all worker gateways could silently stay down until manually restarted.Changes
hermes_cli/gateway.py(generate_launchd_plist): use<true/>forKeepAlivehermes_cli/gateway.py(launchd_stop): updated comment to reflect the new unconditional KeepAlive behaviorRelated Issue
Fixes #9659