fix(cli): launchd KeepAlive unconditional restart (#37388) - #38796
Closed
ashishpatel26 wants to merge 1 commit into
Closed
fix(cli): launchd KeepAlive unconditional restart (#37388)#38796ashishpatel26 wants to merge 1 commit into
ashishpatel26 wants to merge 1 commit into
Conversation
Replace KeepAlive.SuccessfulExit=false dict with <key>KeepAlive</key><true/> so launchd restarts hermes-gateway on any exit, matching the documented drain-then-exit restart protocol used by --graceful-restart.
Closed
2 tasks
alt-glitch
added
type/bug
This was referenced Jun 4, 2026
Contributor
Author
|
Closing — fix merged upstream as c9b6206. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
KeepAlive.SuccessfulExit=falsedict with<key>KeepAlive</key><true/>so launchd restarts hermes-gateway on any exit.Root cause (fixes #37388)
KeepAlive.SuccessfulExit=falsemeans launchd only restarts on non-zero exits. But the--graceful-restart/ SIGUSR1 drain protocol exits with code 0 after draining in-flight runs. With the old plist, a graceful restart would drain correctly then exit 0 — and launchd would not respawn it.Test plan
tests/hermes_cli/test_gateway_service.py— asserts generated plist contains<key>KeepAlive</key>immediately followed by<true/>, not a dict🤖 Generated with Claude Code