shutdown_forensics: don't trust 'systemctl --user' defaults for system units - #34734
Open
rp-keeran wants to merge 1 commit into
Open
shutdown_forensics: don't trust 'systemctl --user' defaults for system units#34734rp-keeran wants to merge 1 commit into
rp-keeran wants to merge 1 commit into
Conversation
…m units check_systemd_timing_alignment queried 'systemctl --user show <unit>' first, which returns built-in defaults (TimeoutStopUSec=90s) with exit 0 even when the unit isn't loaded for the user manager. For system-managed units this produced a false 'stale unit / TimeoutStopSec=90s' warning. Require LoadState=loaded before trusting the value.
alt-glitch
added
type/bug
This was referenced Jul 3, 2026
Closed
Contributor
|
Thanks for isolating the systemd manager-scope false positive. The production guard is narrowly targeted and its diff applies cleanly to the current Problems
Suggested changes
Automated hermes-sweeper review. |
teknium1
added
the
sweeper:blast-contained
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_systemd_timing_alignmentqueriedsystemctl --user show <unit>first, which returns built-in defaults (TimeoutStopUSec=90s) with exit 0 even when the unit isn't loaded for the user manager. For system-managed units this produced a false "stale unit / TimeoutStopSec=90s" warning. Now requiresLoadState=loadedbefore trusting the value.