fix(gateway): query systemd timeout in owning scope - #61532
Closed
zzz163519 wants to merge 1 commit into
Closed
Conversation
Collaborator
Duplicate of #54396 — the earliest open PR fixing the same false-positive stale-systemd-unit warning at the same code site ( |
Contributor
Author
|
Closing in favor of the earlier canonical systemd-scope fix in #54396. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61003.
check_systemd_timing_alignment()currently probessystemctl --user showbefore the system manager. On system-scope gateway units,systemctl --user show <missing-unit>can still return success with the defaultTimeoutStopUSec=1min 30s, so Hermes reports a stale-unit warning even when the real system unit has a sufficient timeout.This change records the manager scope while reading
/proc/self/cgroup:/system.slice/...servicequeries systemsystemctl showonly/user.slice/...servicequeriessystemctl --user showonlyTests
Added regression coverage for a system-scope cgroup where the user manager would return the phantom 90s timeout but the system manager reports 4min.