Skip to content

fix: ignore missing user systemd unit in timeout check - #80160

Closed
asdfafadfadsfa wants to merge 1 commit into
NousResearch:mainfrom
asdfafadfadsfa:fix/systemd-user-unit-false-positive
Closed

fix: ignore missing user systemd unit in timeout check#80160
asdfafadfadsfa wants to merge 1 commit into
NousResearch:mainfrom
asdfafadfadsfa:fix/systemd-user-unit-false-positive

Conversation

@asdfafadfadsfa

Copy link
Copy Markdown

Summary

  • Ignore the user-manager default TimeoutStopUSec when the queried service has LoadState=not-found.
  • Fall through to the system-level unit, avoiding a false stale-unit warning for system services.
  • Add a regression test covering a missing user unit followed by a 240-second system unit.

Test plan

  • scripts/run_tests.sh tests/gateway/test_shutdown_forensics.py -v --tb=short (11 passed)

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists labels Aug 6, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Duplicate of #34734: both gate the systemd timeout check on LoadState before trusting a manager's synthesized default. #34734 handles all non-loaded states, while this is the narrower not-found variant.

@asdfafadfadsfa

asdfafadfadsfa commented Aug 6, 2026

Copy link
Copy Markdown
Author

Closing as a duplicate of #34734. Both changes address the same systemctl --user show false-positive: synthesized timeout defaults must not be trusted unless LoadState=loaded. #34734 handles all non-loaded states, whereas this PR covered only the narrower missing/not-found case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants