Skip to content

fix(acp): preload startup skills - #26602

Closed
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/acp-preload-skills
Closed

fix(acp): preload startup skills#26602
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/acp-preload-skills

Conversation

@haran2001

Copy link
Copy Markdown
Contributor

Summary

  • Add ACP --skills/-s parsing and normalize repeated or comma-separated skill names.
  • Pass startup skills into ACP session creation and inject loaded skill content through the agent's ephemeral system prompt.
  • Forward top-level Hermes --skills values when launching ACP mode.

Test Plan

  • python -m pytest tests/acp/test_entry.py tests/acp/test_session.py -q -o 'addopts='

Closes #24466

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/acp Agent Communication Protocol adapter comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists labels May 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #24474. Both pass --skills flag through to ACP sessions, fixing #24466. Four other competing PRs (#24521, #24526, #24635, #24683) have already been closed as duplicates of #24474.

@haran2001

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #24474, which covers passing --skills through to ACP sessions for #24466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/acp Agent Communication Protocol adapter comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: --skills not passed to acp command.

2 participants