feat(acp): pass --skills arg through to ACP session preloader - #24683
Closed
shanewas wants to merge 2 commits into
Closed
feat(acp): pass --skills arg through to ACP session preloader#24683shanewas wants to merge 2 commits into
shanewas wants to merge 2 commits into
Conversation
Closes #24466. Skills passed via `-s` / `--skills` on the `hermes acp` command were silently discarded because cmd_acp() called acp_main() with no arguments. The fix mirrors the existing TUI pattern: 1. hermes_cli/main.py — cmd_acp() now reads args.skills and writes HERMES_ACP_SKILLS=<comma-separated> into the environment before calling acp_main(). The argument uses action='append' so multiple `-s foo -s bar` or comma-separated values both work. 2. acp_adapter/session.py — _make_agent() now reads HERMES_ACP_SKILLS at session-creation time, calls build_preloaded_skills_prompt() (same function the TUI and CLI chat mode use), and injects the result as ephemeral_system_prompt on the AIAgent. Failures are logged at DEBUG level so they never crash the ACP server.
test_acp_skills_env_var_injects_ephemeral_system_prompt test_acp_no_skills_without_env_var test_acp_comma_separated_skills_parsed_into_list test_acp_missing_skills_log_at_debug_only
alt-glitch
added
type/feature
Collaborator
Author
This was referenced May 15, 2026
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New feature: pass
--skillsargument through to the ACP session preloader.Changes
hermes sessions start --acp, the--skillsflag is now forwarded to the session preloader, allowing skills to be preloaded at session creation time.skillsparameter.Files changed
hermes_cli/main.pyacp_adapter/session.pytests/acp_adapter/test_acp_skills_preload.py