fix(acp): pass --skills flag through to ACP sessions - #24474
Closed
luyao618 wants to merge 1 commit into
Closed
Conversation
alt-glitch
added
type/bug
3 tasks
This was referenced May 12, 2026
luyao618
force-pushed
the
fix/acp-skills-passthrough
branch
from
May 17, 2026 06:59
9121c70 to
04f522e
Compare
) cmd_acp() silently discarded args.skills — acp_main() took no parameters and HermesACPAgent / SessionManager never received the skill list. Thread the skills value from the CLI arg parser through acp_main() → HermesACPAgent → SessionManager._make_agent(), where it is resolved via build_preloaded_skills_prompt() and injected as prefill_messages into the AIAgent, matching the existing CLI chat-mode behavior. Closes NousResearch#24466 AI-assisted: implementation by Claude, review by human
luyao618
force-pushed
the
fix/acp-skills-passthrough
branch
from
May 18, 2026 05:02
04f522e to
f9d6a0d
Compare
Contributor
Author
|
Closing — DIRTY conflicts and stale. Will reopen with a fresh branch if the |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #24466 — the
--skills/-sglobal flag was silently ignored when runninghermes acp.Root Cause
cmd_acp(args)calledacp_main()with no arguments, discardingargs.skills.acp_main()accepted no parameters and createdHermesACPAgent()with no skill preloading.Changes
hermes_cli/main.pyargs.skillstoacp_main()acp_adapter/entry.pyskillskeyword arg, forward toHermesACPAgentacp_adapter/server.pyskillsinHermesACPAgent.__init__(), forward toSessionManageracp_adapter/session.pySessionManager, resolve viabuild_preloaded_skills_prompt()in_make_agent(), inject asprefill_messagesintoAIAgenttests/acp_adapter/test_acp_skills.pyHow It Works
The skills value is threaded through the full ACP startup chain:
In
SessionManager._make_agent(), skills are resolved using the samebuild_preloaded_skills_prompt()helper that the CLI chat mode uses, and injected asprefill_messagesinto theAIAgentconstructor.Testing
AI-assisted: implementation by Claude, review by human