Skip to content

fix(cli): add timeout and progress output to npm install during update (supersedes #24391, #18866) - #25990

Closed
shellybotmoyer wants to merge 2 commits into
NousResearch:mainfrom
shellybotmoyer:fix/npm-install-timeout-progress-resolve
Closed

fix(cli): add timeout and progress output to npm install during update (supersedes #24391, #18866)#25990
shellybotmoyer wants to merge 2 commits into
NousResearch:mainfrom
shellybotmoyer:fix/npm-install-timeout-progress-resolve

Conversation

@shellybotmoyer

Copy link
Copy Markdown
Contributor

This PR supersedes #24391 and the original #18866.

It applies the same fix (add timeout=300 to npm install during hermes update, switch from --silent to --loglevel=warn, and add _relay() progress output for build failures) on top of the latest origin/main.

What changed

Closes #18866
Supersedes #24391

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels May 14, 2026
@shellybotmoyer

Copy link
Copy Markdown
Contributor Author

Superseded by upstream commit c844d15 which merged a better fix for #18840 (stream npm install output with capture_output=False instead of --silent). This PR branch is now 149 commits behind main and has merge conflicts in hermes_cli/main.py. Closing in favor of the upstream solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants