fix(cli): add timeout and progress output to npm install during update (supersedes #24391, #18866) - #25990
Closed
shellybotmoyer wants to merge 2 commits into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #24391 and the original #18866.
It applies the same fix (add
timeout=300tonpm installduringhermes update, switch from--silentto--loglevel=warn, and add_relay()progress output for build failures) on top of the latestorigin/main.What changed
origin/mainto resolve the merge conflict inhermes_cli/main.py_relay()helper from the earlier merge is preserved alongside the timeout/loglevel changes from fix(cli): add timeout and progress output to npm install during update (supersedes #18866) #24391Closes #18866
Supersedes #24391