fix(cli): add timeout and progress output to npm install during update (supersedes #18866) - #24391
Closed
shellybotmoyer wants to merge 1 commit into
Closed
Conversation
Collaborator
This was referenced May 12, 2026
Contributor
Author
|
Superseded by clean rebase → #25990. Closing this one. |
Contributor
Author
|
Superseded by #25990 (clean rebase resolving the merge conflict in hermes_cli/main.py). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hermes updateappeared to hang indefinitely at "Updating Node.js dependencies..." because:--silentflag, suppressing ALL output (including progress from postinstall scripts likenpx Camofox-js fetch)subprocess.run()— if npm hangs, the update process hangs foreverFix
Added
timeout=300to_run_npm_install_deterministic()— prevents indefinite hangs. Bothnpm ciandnpm installnow have a 5-minute timeout per directory.TimeoutExpiredexceptions are caught and converted to meaningful error messages instead of hanging.Replaced
--silentwith--loglevel=warn— shows warnings and errors (useful for debugging) while still suppressing the noisy progress bars and audit messages. Users can now see if something goes wrong instead of staring at a blank screen.Added progress message — prints "Installing {label}... (this may take a moment during postinstall scripts)" before each npm install so users know what's happening.
Updated both call sites —
_update_node_dependencies()and_build_web_ui()both use the same function and both now pass timeout.Fixes #18840
Rebased onto current main (resolves merge conflict with
encoding="utf-8"addition in_run_npm_install_deterministic). Supersedes #18866 which was in DIRTY state.